Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <felipe.balbi@linux.intel.com>
To:     Sanket Parmar <sparmar@cadence.com>, gregkh@linuxfoundation.org
Cc:     sparmar@cadence.com, pawell@cadence.com, linux-usb@vger.kernel.org,
        rogerq@ti.com, linux-kernel@vger.kernel.org, kurahul@cadence.com,
        peter.chen@nxp.com, nsekhar@ti.com
Subject: Re: [PATCH] usb: cdns3: gadget: reset EP_CLAIMED flag while unloading
In-Reply-To: <20191029122441.5816-1-sparmar@cadence.com>
References: <20191029122441.5816-1-sparmar@cadence.com>
Date:   Wed, 30 Oct 2019 13:40:05 +0200
Message-ID: <8736fafomi.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Greg,

Sanket Parmar <sparmar@cadence.com> writes:

> EP_CLAIMED flag is used to track the claimed endpoints. While unloading the
> module, Reset EP_CLAIMED flag for all enabled endpoints. So that it can be
> reused.
>
> Signed-off-by: Sanket Parmar <sparmar@cadence.com>

if you want to take this as a patch:

Acked-by: Felipe Balbi <balbi@kernel.org>

> ---
> Hi Greg/Felipe,
>
> This can be used for -rc as it is bug fix.
>
> Regards,
> Sanket
>
>  drivers/usb/cdns3/gadget.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 9050b380ab83..2fb78322ed3c 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -2381,6 +2381,8 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>  		writel(EP_CMD_EPRST, &priv_dev->regs->ep_cmd);
>  		readl_poll_timeout_atomic(&priv_dev->regs->ep_cmd, val,
>  					  !(val & EP_CMD_EPRST), 1, 100);
> +
> +		priv_ep->flags &= ~EP_CLAIMED;
>  	}
>  
>  	/* disable interrupt for device */
> -- 
> 2.17.1
>

-- 
balbi