Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "wubo (T)" <wubo40@huawei.com>
To:     Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>,
        open-iscsi <open-iscsi@googlegroups.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        Chris Leech <cleech@redhat.com>, Lee Duncan <lduncan@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     "liuzhiqiang (I)" <liuzhiqiang26@huawei.com>,
        Mingfangsen <mingfangsen@huawei.com>
Subject: Antw: [PATCH v2] scsi: avoid potential deadloop in iscsi_if_rx func
Thread-Topic: Antw: [PATCH v2] scsi: avoid potential deadloop in iscsi_if_rx
 func
Thread-Index: AdWO9lESg1/320hTRWyI93hubYXiRQAAM+TA//+AUID//1OToA==
Date:   Wed, 30 Oct 2019 12:22:37 +0000
Message-ID: <EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915DFA4D6@dggeml505-mbs.china.huawei.com>
References: <EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915DFA0FE@dggeml505-mbs.china.huawei.com>
 <5DB946E1020000A100034B9C@gwsmtp.uni-regensburg.de>
In-Reply-To: <5DB946E1020000A100034B9C@gwsmtp.uni-regensburg.de>
Accept-Language: en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> >>> "wubo (T)" <wubo40@huawei.com> schrieb am 30.10.2019 um 08:56 in
> Nachricht
> <EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915DFA0FE@dggeml505-mbs.china.
> huawei.com>:
> > From: Bo Wu <wubo40@huawei.com>
> 
> ...
> > +			if (--retries < 0) {
> > +				printk(KERN_ERR "Send reply failed too many times. "
> > +				       "Max supported retries %u\n",
> ISCSI_SEND_MAX_ALLOWED);
> 
> Just for "personal taste": Why not simplify the message to:?
> +				printk(KERN_ERR "Send reply failed too many times
> (%u)\n",
>                                ISCSI_SEND_MAX_ALLOWED);
> 
> > +				break;
> > +			}
> > +
> 
> Maybe place the number after "many" as an alternative. I think as the
> message is expected to be rare, a short variant is justified.

Thanks for your suggestion. This problem occured when iscsi_if_send_reply returns -EAGAIN.
Consider possible other anomalies scenes. In order to get diagnostic information, it is better to replace "many" with error code.

Modify as follow:
if (--retries < 0) {
	printk(KERN_WARNING "Send reply failed, error %d\n", err);
	break;
}

> Also one could discuss wether the problem that originates "from external"
> should be KERN_ERR, or maybe just a warning, because the kernel itself can do
> little against that problem, and it's not a "kernel error" after all ;-)

You are right, This problem scene rarely appears .it is friendly to replace the error with warning.

> 
> Regards,
> Ulrich
> 
> 
> 

Thanks,
Bo Wu