Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1572440776-50318-1-git-send-email-zhongjiang@huawei.com>
In-Reply-To: <1572440776-50318-1-git-send-email-zhongjiang@huawei.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Wed, 30 Oct 2019 22:39:49 +0900
Message-ID: <CAC5umyhRiJ9LHD1fhhSUygmWtXMe28WL4KB9=5DXv0rU6rJ0vg@mail.gmail.com>
Subject: Re: [PATCH v2] fault-inject: Use debugfs_create_ulong() instead of debugfs_create_ul()
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=E5=B9=B410=E6=9C=8830=E6=97=A5(=E6=B0=B4) 22:10 zhong jiang <zhongjian=
g@huawei.com>:
>
> debugfs_create_ulong() has implemented the function of debugfs_create_ul(=
)
> in lib/fault-inject.c. hence we can replace it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  lib/fault-inject.c | 43 ++++++++++++++-----------------------------
>  1 file changed, 14 insertions(+), 29 deletions(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index 8186ca8..326fc1d 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -151,10 +151,13 @@ bool should_fail(struct fault_attr *attr, ssize_t s=
ize)
>  EXPORT_SYMBOL_GPL(should_fail);
>
>  #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
> +#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
>
> -static int debugfs_ul_set(void *data, u64 val)
> +static int debugfs_stacktrace_depth_set(void *data, u64 val)
>  {
> -       *(unsigned long *)data =3D val;
> +       *(unsigned long *)data =3D
> +               min_t(unsigned long, val, MAX_STACK_TRACE_DEPTH);
> +
>         return 0;
>  }
>
> @@ -164,26 +167,8 @@ static int debugfs_ul_get(void *data, u64 *val)
>         return 0;
>  }
>
> -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n=
");
> -
> -static void debugfs_create_ul(const char *name, umode_t mode,
> -                             struct dentry *parent, unsigned long *value=
)
> -{
> -       debugfs_create_file(name, mode, parent, value, &fops_ul);
> -}
> -
> -#ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
> -
> -static int debugfs_stacktrace_depth_set(void *data, u64 val)
> -{
> -       *(unsigned long *)data =3D
> -               min_t(unsigned long, val, MAX_STACK_TRACE_DEPTH);
> -
> -       return 0;
> -}
> -
> -DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
> -                       debugfs_stacktrace_depth_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
> +                        debugfs_stacktrace_depth_set, "%llu\n");
>

The commit message doesn't describe the s/SIMPLE/DEBUGFS/ change
for fops_stacktrace_depth.

It is better to prepare another patch and I think debugfs_create_file()
in debugfs_create_stacktrace_depth() can now be replaced by
debugfs_create_file_unsafe().