Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5db9a047.1c69fb81.85ac7.7aa1@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <87ec773e0d92571c4bbed44eeb65cff5@codeaurora.org>
References: <20191023090219.15603-1-rnayak@codeaurora.org> <20191023090219.15603-9-rnayak@codeaurora.org> <5db86b1b.1c69fb81.be45f.0bb2@mx.google.com> <87ec773e0d92571c4bbed44eeb65cff5@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH v3 08/11] arm64: dts: qcom: pm6150: Add PM6150/PM6150L PMIC peripherals
To:     kgunda@codeaurora.org
Cc:     Rajendra Nayak <rnayak@codeaurora.org>, agross@kernel.org,
        bjorn.andersson@linaro.org, robh+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, mka@chromium.org
User-Agent: alot/0.8.1
Date:   Wed, 30 Oct 2019 07:37:58 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting kgunda@codeaurora.org (2019-10-30 00:06:05)
> On 2019-10-29 22:08, Stephen Boyd wrote:
> > Quoting Rajendra Nayak (2019-10-23 02:02:16)
> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150.dtsi=20
> >> b/arch/arm64/boot/dts/qcom/pm6150.dtsi
> >> new file mode 100644
> >> index 000000000000..20eb928e5ce3
> >> --- /dev/null
> >> +++ b/arch/arm64/boot/dts/qcom/pm6150.dtsi
> >> @@ -0,0 +1,85 @@
> >> +// SPDX-License-Identifier: BSD-3-Clause
> >> +// Copyright (c) 2019, The Linux Foundation. All rights reserved.
> >> +
> >> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> >> +#include <dt-bindings/input/linux-event-codes.h>
> >> +#include <dt-bindings/interrupt-controller/irq.h>
> >> +#include <dt-bindings/spmi/spmi.h>
> >> +#include <dt-bindings/thermal/thermal.h>
> >> +
> >> +&spmi_bus {
> >> +       pm6150_lsid0: pmic@0 {
> >> +               compatible =3D "qcom,pm6150", "qcom,spmi-pmic";
> >> +               reg =3D <0x0 SPMI_USID>;
> >> +               #address-cells =3D <1>;
> >> +               #size-cells =3D <0>;
> >> +
> >> +               pm6150_pon: pon@800 {
> >> +                       compatible =3D "qcom,pm8998-pon";
> >> +                       reg =3D <0x800>;
> >> +                       mode-bootloader =3D <0x2>;
> >> +                       mode-recovery =3D <0x1>;
> >=20
> > Can this have status =3D "disabled"? Or is the idea that if the pmic=20
> > power
> > button isn't used it should be disabled in the board dts file?
> >=20
> Yes. The idea is to go with latter option. Disable it in the board dts=20
> file if the
> pmic power button is not used.

Ok. Thanks.

> >> +
> >> +                       interrupt-names =3D "pm6150_gpio1",=20
> >> "pm6150_gpio2",
> >> +                                       "pm6150_gpio3",=20
> >> "pm6150_gpio4",
> >> +                                       "pm6150_gpio5",=20
> >> "pm6150_gpio6",
> >> +                                       "pm6150_gpio7",=20
> >> "pm6150_gpio8",
> >> +                                       "pm6150_gpio9",=20
> >> "pm6150_gpio10";
> >=20
> > And this? And have gpio-ranges and use the irqdomain work. Basically,
> > should look like pm8998.
> Ok.. We can go ahead with the pm8998 way as well. We will address it in=20
> next series.

Yes please use the pm8998 way..