Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Oct 2019 09:39:49 -0500
From:   Rob Herring <robh@kernel.org>
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     sre@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        yuanjiang.yu@unisoc.com, baolin.wang7@gmail.com,
        zhang.lyra@gmail.com, orsonzhai@gmail.com
Subject: Re: [PATCH 4/5] dt-bindings: power: sc27xx: Add a new property to
 describe the real resistance of coulomb counter chip
Message-ID: <20191030143949.GA18637@bogus>
References: <cover.1572245011.git.baolin.wang@linaro.org>
 <00202f739348258555dcc40982c330542ac61863.1572245011.git.baolin.wang@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00202f739348258555dcc40982c330542ac61863.1572245011.git.baolin.wang@linaro.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 28, 2019 at 03:19:00PM +0800, Baolin Wang wrote:
> Add a new property to describe the real resistance of coulomb counter chip,
> which is used to calibrate the accuracy of the coulomb counter chip.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
>  .../devicetree/bindings/power/supply/sc27xx-fg.txt |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> index 0a5705b..fc042d0 100644
> --- a/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> +++ b/Documentation/devicetree/bindings/power/supply/sc27xx-fg.txt
> @@ -13,6 +13,7 @@ Required properties:
>  - io-channel-names: Should be "bat-temp" or "charge-vol".
>  - nvmem-cells: A phandle to the calibration cells provided by eFuse device.
>  - nvmem-cell-names: Should be "fgu_calib".
> +- sprd,calib-resistance: Specify the real resistance of coulomb counter chip in micro Ohms.
>  - monitored-battery: Phandle of battery characteristics devicetree node.
>    See Documentation/devicetree/bindings/power/supply/battery.txt

Needs a standard unit suffix.

>  
> @@ -52,5 +53,6 @@ Example:
>  			nvmem-cells = <&fgu_calib>;
>  			nvmem-cell-names = "fgu_calib";
>  			monitored-battery = <&bat>;
> +			sprd,calib-resistance = <21500>;
>  		};
>  	};
> -- 
> 1.7.9.5
>