Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
From:   Qian Cai <cai@lca.pw>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used
Date:   Wed, 30 Oct 2019 17:54:05 -0400
Message-Id: <5E00893B-D36C-446F-9E71-54FB32772DA0@lca.pw>
References: <03cacc16f2fcd7cc74cf15c57070c78e73206e68.camel@intel.com>
Cc:     "Williams, Dan J" <dan.j.williams@intel.com>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Busch, Keith" <keith.busch@intel.com>,
        "Weiny, Ira" <ira.weiny@intel.com>
In-Reply-To: <03cacc16f2fcd7cc74cf15c57070c78e73206e68.camel@intel.com>
To:     "Verma, Vishal L" <vishal.l.verma@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Oct 30, 2019, at 5:38 PM, Verma, Vishal L <vishal.l.verma@intel.com> wr=
ote:
>=20
> Good find! Since we're not really using rc later, we should just
> simplify this to:
>=20
>    if (btt_map_write(...))
>        dev_warn_ratelimited(...)
>    goto out_rtt;

Ah, I thought about printing the rc as well at first, but it seems only retu=
rn -EIO for errors, so I agree with you.=