Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp449032ybx; Wed, 30 Oct 2019 18:06:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzIWRbOPDAMDe2umtTM5eDL+BLOEZUtD1RvmuMRAJHl6W31eGR5TQ7FPjgUaK+sg7Zvduv6 X-Received: by 2002:a50:eb81:: with SMTP id y1mr3015492edr.119.1572483996885; Wed, 30 Oct 2019 18:06:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572483996; cv=none; d=google.com; s=arc-20160816; b=bT3DX4b6oY6D5BIh1ccMlBwsqZ+y7+mn53wl+g/VEBjf1tyy7jsukxuFKOAMKBc3Jb rKs5QCVa2fPgYH+1uG6QLxX5D71oqGIKZTrKrhBWWDeqoa2JnfLh4EfbfzitNVFLSOPu Ko6j9e9/WRUTp+CweFFvWrr2lL7H5UZ8oSNzg6NA+qAMsxND69JrkNf2HSjHhnbMtm99 D48SAvMFuRJ8sYM1VG3L4rwJLoWf1YMLMyuT9KW6K/FqZhL2WgjBz9/8omYV6gRHLx7u u76B+Um7eNOzTfjqrAg4NIEe1q2MhwJ/ndgNKySuz5VRO2zeRTa6EOPX8JHLDM/0XHjO qJ4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=A3paOZnkg4Waw7ymvFlVRo6JdlKrhEFk1kP+QPCn5XM=; b=xsxL+g3WR59uijD+IjjfUVVgdxfIdSIbKb8FTDGAOlyhJXGW12pC/4AAFop00jJeF5 dNVKrncspv1aYYqnWARQqQ6zsPE3/A3mpqxvq/iVmcg7F6ohL52Vx+ng40OwH/RoCfEM qE+M9zAlOSdbgQXDZeaktZceYobEBR/AqPpxuwLa5t0KtDv7KU2Ptdw2BAsSEIQHoklQ l2uCEbmHTiZ03W4hUPuXoOq7KydQaVLXaXMh0tviRNgLfnwD8aqEgqHisdVq8Vh4wibl ArG0bXWS4loDZtR0hQSUS9Z+cjIZ/s6rsl7EMDKh2fOf402+o1gr2IiEGIFGbxi5J+/8 Upzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ox3si2496592ejb.170.2019.10.30.18.06.13; Wed, 30 Oct 2019 18:06:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727952AbfJaAVz (ORCPT + 99 others); Wed, 30 Oct 2019 20:21:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48674 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727179AbfJaAVy (ORCPT ); Wed, 30 Oct 2019 20:21:54 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BA02F14E0FDB8; Wed, 30 Oct 2019 17:21:53 -0700 (PDT) Date: Wed, 30 Oct 2019 17:21:51 -0700 (PDT) Message-Id: <20191030.172151.339466224535362239.davem@davemloft.net> To: mcroce@redhat.com Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, sdf@google.com, daniel@iogearbox.net, songliubraving@fb.com, ast@kernel.org, paulb@mellanox.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 0/4] ICMP flow improvements From: David Miller In-Reply-To: <20191029135053.10055-1-mcroce@redhat.com> References: <20191029135053.10055-1-mcroce@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Oct 2019 17:21:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matteo Croce Date: Tue, 29 Oct 2019 14:50:49 +0100 > This series improves the flow inspector handling of ICMP packets: > The first two patches just add some comments in the code which would have saved > me a few minutes of time, and refactor a piece of code. > The third one adds to the flow inspector the capability to extract the > Identifier field, if present, so echo requests and replies are classified > as part of the same flow. > The fourth patch uses the function introduced earlier to the bonding driver, > so echo replies can be balanced across bonding slaves. > > v1 -> v2: > - remove unused struct members > - add an helper to check for the Id field > - use a local flow_dissector_key in the bonding to avoid > changing behaviour of the flow dissector Series applied to net-next, thanks.