Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp451339ybx; Wed, 30 Oct 2019 18:08:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDRfzWEh6+NMOU7uADQeeRnZQEWztlp2LTOdLQ4CYYezKNTw6XcLJi7maSPx21yPDSroPm X-Received: by 2002:a50:ac14:: with SMTP id v20mr2975537edc.291.1572484132630; Wed, 30 Oct 2019 18:08:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572484132; cv=none; d=google.com; s=arc-20160816; b=Iv0c3MDqyPPBFluyqcIxHVNERapmlVm4ezdgLDdD71nYTrgpwTCRGtwnD5LV+uz6iv WM77BlJ5jy7z9hLI32uFVI2LcU5yLu/4LnZYuaP5eytxBY9ZB1iXgo8vw9C+c2RM78FG ZLpAuVE2cFoOrkGVwDl43+92j2x/1obEmCBCc6/amLP5y7swntjQkDujO6mn167bdtIO H/cXoAeo7RX89lirwU3Ch0mytFGBKCoyO0L44Yeeu/pmPUMvUKyPGzZSBTBEXdkoVwU1 iX5QxZon0RQf7fQkvpfI/sphu57F1H2Y0dZK9bf0sjSgGT5gN07Se6HvAGFNAduEMlBZ yQrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=DGe2i9b7Rb8dGU0vIaZ6V88d/DX9cilS4sEwRPQYAwc=; b=Uzsmwzydt4ltAwDJ12cOguE4NU8fiPh17B40jrskR11x9aAdGQ7DhTjjgwcRvSbfCU V73UhzU0fcNQ5I3CsXZPKfeejIJvtsqxkZcIcLGOyd4ndZ9Q/NSAN06AAvVYIa9+m974 QsHZCD/HZNaO2fX8+ceqMbDOyHvUPjEBRE8enZKGdBdCTNxuHPDMEW6WzXJpndyZNHD4 TqMViEhb7EReeWHMvYCAFQiqoTry9HNnHlvLlQ00Q8xzqN5ODl1stQldb1ZEJq3eFf78 Bz0dkbPaJizCoJ3Tl8ukIh9AYO2aN9rzygf4yi3cbl5jfF/gZrZLrfVJinLBS6/NYkRg h1ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9si2187305ejk.158.2019.10.30.18.08.29; Wed, 30 Oct 2019 18:08:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbfJaA6o (ORCPT + 99 others); Wed, 30 Oct 2019 20:58:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49084 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbfJaA6o (ORCPT ); Wed, 30 Oct 2019 20:58:44 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B22B314E7C113; Wed, 30 Oct 2019 17:58:43 -0700 (PDT) Date: Wed, 30 Oct 2019 17:58:43 -0700 (PDT) Message-Id: <20191030.175843.1675423957559675418.davem@davemloft.net> To: zhongjiang@huawei.com Cc: linux-wimax@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wimax: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops From: David Miller In-Reply-To: <1572404134-45159-1-git-send-email-zhongjiang@huawei.com> References: <1572404134-45159-1-git-send-email-zhongjiang@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Oct 2019 17:58:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhong jiang Date: Wed, 30 Oct 2019 10:55:34 +0800 > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file > operation rather than DEFINE_SIMPLE_ATTRIBUTE. > > It is detected with the help of coccinelle. > > Signed-off-by: zhong jiang Applied.