Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Oct 2019 22:14:28 -0400
Message-ID: <20191030221428.GB140471@t480s.localdomain>
From:   Vivien Didelot <vivien.didelot@gmail.com>
To:     David Miller <davem@davemloft.net>
Cc:     linux-kernel@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/7] net: dsa: list DSA links in the fabric
In-Reply-To: <20191030.143949.809392632168787466.davem@davemloft.net>
References: <20191028195220.2371843-1-vivien.didelot@gmail.com>
 <20191028195220.2371843-2-vivien.didelot@gmail.com>
 <20191030.143949.809392632168787466.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David,

On Wed, 30 Oct 2019 14:39:49 -0700 (PDT), David Miller <davem@davemloft.net> wrote:
> From: Vivien Didelot <vivien.didelot@gmail.com>
> Date: Mon, 28 Oct 2019 15:52:14 -0400
> 
> > @@ -122,6 +124,29 @@ static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst,
> >  	return NULL;
> >  }
> >  
> > +struct dsa_link *dsa_link_touch(struct dsa_port *dp, struct dsa_port *link_dp)
> > +{
> > +	struct dsa_switch *ds = dp->ds;
> > +	struct dsa_switch_tree *dst = ds->dst;
> > +	struct dsa_link *dl;
> 
> Please fix the reverse christmas tree here, two suggestions:
> 
> 	struct dsa_switch *ds = dp->ds;
> 	struct dsa_switch_tree *dst;
> 	struct dsa_link *dl;
> 
> 	dst = ds->dst;
> 
> Or, alternatively, since the dst variable is used only once, get rid of it
> and change:
> 
> > +	list_add_tail(&dl->list, &dst->rtable);
> 
> to
> 
> > +	list_add_tail(&dl->list, &ds->dst->rtable);

No problem, I've sent a v2 using the first suggestion, since dst is in fact
used twice in this function.


Thank you,

	Vivien