Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 01/48] Input: introduce input_mt_report_slot_inactive
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Jiada Wang <jiada_wang@mentor.com>, jikos@kernel.org,
        benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, erosca@de.adit-jv.com,
        Andrew_Gabbasov@mentor.com
References: <20191029072010.8492-1-jiada_wang@mentor.com>
 <20191029072010.8492-2-jiada_wang@mentor.com>
 <b3de4c05-d2d1-58f8-a447-d5e127574ac0@bitmath.org>
 <20191030232311.GK57214@dtor-ws>
From:   Henrik Rydberg <rydberg@bitmath.org>
Message-ID: <8bcc16bc-3726-0766-6ec7-213b165faf7e@bitmath.org>
Date:   Thu, 31 Oct 2019 09:01:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191030232311.GK57214@dtor-ws>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dmitry,

On 2019-10-31 00:23, Dmitry Torokhov wrote:
> On Tue, Oct 29, 2019 at 06:13:09PM +0100, Henrik Rydberg wrote:
>> Hi Jiada,
>>
>>> input_mt_report_slot_state() ignores the tool when the slot is closed.
>>> which has caused a bit of confusion.
>>> This patch introduces input_mt_report_slot_inactive() to report slot
>>> inactive state.
>>> replaces all input_mt_report_slot_state() with
>>> input_mt_report_slot_inactive() in case of close of slot.
>>>
>>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>> NACK on this one.
>>
>> We already discussed this patch and the potentially changed behavior to
>> existing setups stemming from ignoring the MT state.
>>
>> On the upside, what I can see this patch does exactly no difference to the
>> cases where the MT state is set, so it can be safely dropped without
>> affecting the rest of the patch series.
> I guess Jiada's concern that we are forcing to pass tool type even
> though we end up ignoring it intervally, which confuses users of the API
> as they might not know what tool to specify.
>
> How about we do:
>
> static inline void input_mt_report_slot_inactive(struct input_dev *dev)
> {
> 	input_mt_report_slot_state(dev, 0, false);
> }
>
> This should not change any behavior.

Agreed, that will work.

Thanks,

Henrik