Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     Roman Gushchin <guro@fb.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Michal Hocko <mhocko@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-team@fb.com" <kernel-team@fb.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH v2] mm: slab: make page_cgroup_ino() to recognize
 non-compound slab pages properly
Thread-Topic: [PATCH v2] mm: slab: make page_cgroup_ino() to recognize
 non-compound slab pages properly
Thread-Index: AQHVj6H5mxzEf5Q4l0mAfuJEVZ8f/qdz59AA
Date:   Thu, 31 Oct 2019 09:38:40 +0000
Message-ID: <20191031093840.GA9178@hori.linux.bs1.fc.nec.co.jp>
References: <20191031012151.2722280-1-guro@fb.com>
 <20191030211608.29f8fc92e07fd2ac2ef4d1d3@linux-foundation.org>
In-Reply-To: <20191030211608.29f8fc92e07fd2ac2ef4d1d3@linux-foundation.org>
Accept-Language: en-US, ja-JP
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <4592DDEF39464440989A95B815E27759@gisp.nec.co.jp>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 30, 2019 at 09:16:08PM -0700, Andrew Morton wrote:
> On Wed, 30 Oct 2019 18:21:51 -0700 Roman Gushchin <guro@fb.com> wrote:
> 
> > page_cgroup_ino() doesn't return a valid memcg pointer for non-compound
> > slab pages, because it depends on PgHead AND PgSlab flags to be set
> > to determine the memory cgroup from the kmem_cache.
> > It's correct for compound pages, but not for generic small pages. Those
> > don't have PgHead set, so it ends up returning zero.
> > 
> > Fix this by replacing the condition to PageSlab() && !PageTail().
> > 
> > Before this patch:
> > [root@localhost ~]# ./page-types -c /sys/fs/cgroup/user.slice/user-0.slice/user@0.service/ | grep slab
> > 0x0000000000000080	        38        0  _______S___________________________________	slab
> > 
> > After this patch:
> > [root@localhost ~]# ./page-types -c /sys/fs/cgroup/user.slice/user-0.slice/user@0.service/ | grep slab
> > 0x0000000000000080	       147        0  _______S___________________________________	slab
> > 
> > Fixes: 4d96ba353075 ("mm: memcg/slab: stop setting page->mem_cgroup pointer for slab pages")
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Reviewed-by: Shakeel Butt <shakeelb@google.com>
> > Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> > Cc: Daniel Jordan <daniel.m.jordan@oracle.com>
> 
> Affects /proc/kpagecgroup, but page_cgroup_ino() is also used in the
> memory-failure code - I wonder what effect this bug has there?

hwpoison_filter_task() uses output of page_cgroup_ino() in order to
filter error injection events based on memcg.
So if page_cgroup_ino() fails to return memcg pointer, we just fail
to inject memory error.  Considering that hwpoison filter is for testing,
affected users are limited and the impact should be marginal.

> 
> IOW, should we backport this into -stable?

I think yes, because the patch is small enough and clearly fixes a bug.

Thanks,
Naoya Horiguchi