Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp941617ybx; Thu, 31 Oct 2019 03:23:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqymgA8ne4IKbslk8StVF14BUHIP15gp6uHWyxu3QZ4JPTCeHSTbx8zW/u5i/z7wcMrqqjqv X-Received: by 2002:a05:6402:6cc:: with SMTP id n12mr5198031edy.38.1572517412340; Thu, 31 Oct 2019 03:23:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572517412; cv=none; d=google.com; s=arc-20160816; b=JeUlnm/qIcfQtLiirGghyUH/CJGrMb85PYvw8m/wSFrYoU20dTtOJt9qE4nwOOBulu jP7/goOlJD1xqbAG4GrlxFqesB9WnS2X7SDFXuBmWIMWdMyGdFf3VC2N7kIJOcApnzPP 66sHp2e8ISeSDP/xt31zmEVEJifkOiZRx+5HkyyywI2C3vwB++lrimrMZavcAJ1/SL5E tS/XuluXSs0c4uGzIASIysyxq3ntifao1meP8icOUgPpXNKmZ9Lrk7PR4hGJHGrL6Ju2 5iuRT1KHraCdC1p6I7vxKoi4NTE2vmDYJ8cQFGWx0BaHEgp+YMkUOxS4p4WMsLy0EQbs PY+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AIPRTbz1vKYMEJ2syx60gILwl+AYqYSi+XaONiaS/s8=; b=VN8XVasxxlsXXV0xVpMn9NNPTH0UPgDag2fiHUeulz0/L4dfXUhrrc5VcxoGiC70dT v4+/whn9OZCvROtosA4HPSBUp1sv6BniY4H+K9+Y7KRdaZrLaAUNUFom4mRgoNPiQNKT ZVSysZj1OjvmheOQWkl6vBmMo+/xdQaowJo9ZOQ44qSAlR/CirvbxL7Sbo6Seemizxot jhT8QuE2TS4nEAvRuBoRl4Bcr14Z5rLKNbN3Kh/df5Ri6c8xe/1GrGuyMd+cSn5JQlEe 4fk45iAwK87OPCVtvX/A0TATpa88oqb9u94skAJZrRmOIQxzrUcy/V5DbFzs1lDyU9o1 AvPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Ycggx2U8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dx19si3284104ejb.113.2019.10.31.03.23.08; Thu, 31 Oct 2019 03:23:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Ycggx2U8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbfJaKWe (ORCPT + 99 others); Thu, 31 Oct 2019 06:22:34 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:60534 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbfJaKWe (ORCPT ); Thu, 31 Oct 2019 06:22:34 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9VAMPx8165363; Thu, 31 Oct 2019 10:22:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=AIPRTbz1vKYMEJ2syx60gILwl+AYqYSi+XaONiaS/s8=; b=Ycggx2U85q5A81uE3ok4s9kutMZ3oZVrWzG6uHq3Uze8EjiUrKMTrc35pZjPvADumEfr qL8Fd4EckoPseP1QI21Ow88avnq4v/R/lj8Z4vcuU72YwlEHos1K63IjeJbWJ8UxI0IL dIMRFqhg5w6R6s1SEf1UDt99W6rxM07dWoY0C0AZoLSsFLTAdJrAmhezlWGfHQB6nJjb OU1BNooxcW4G4/SkNlJEajIRwEaljEMCSVPO3qdxuU57ABDXYw5Hph8kU+KutbpJz3Px JFE5uBJtaXlPweLc4USCYk+aj3vTxwNqFdYjhxz2nlksbIn2I5Vy+BV9oKy3KpnxJC3N 7Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2vxwhft77x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Oct 2019 10:22:25 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9VAJRUU151087; Thu, 31 Oct 2019 10:20:23 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2vyqpdtyht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Oct 2019 10:20:23 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9VAKLJw022953; Thu, 31 Oct 2019 10:20:21 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 31 Oct 2019 03:20:21 -0700 Date: Thu, 31 Oct 2019 13:20:10 +0300 From: Dan Carpenter To: Brendan Higgins Cc: Joe Perches , shuah , David Gow , Andrew Morton , Kees Cook , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List Subject: Re: [PATCH linux-kselftest/test v6] lib/list-test: add a test for the 'list' doubly linked list Message-ID: <20191031102010.GF18421@kadam> References: <20191024224631.118656-1-davidgow@google.com> <0cb1d948-0da3-eb0f-c58f-ae3a785dd0dd@kernel.org> <20191030104217.GA18421@kadam> <42a8270d-ed6f-d29f-5e71-7b76a074b63e@kernel.org> <20191031085129.GA217570@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031085129.GA217570@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9426 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=882 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910310105 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9426 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=964 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910310105 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 01:51:29AM -0700, Brendan Higgins wrote: > static void list_test_list_for_each_prev(struct kunit *test) /* checkpatch: disable=for-each-format */ These comments defeat the purpose of checkpatch which is to make the code cleaner. regards, dan carpenter