Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp980150ybx; Thu, 31 Oct 2019 04:02:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvL7UL+85DBKgUSo20KpdxFaq/WAbfyjbZPKvDOxAuhn37gkLtj1ffMkO2+l7LckxGvoXe X-Received: by 2002:a17:906:6d4f:: with SMTP id a15mr2545887ejt.33.1572519737151; Thu, 31 Oct 2019 04:02:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572519737; cv=none; d=google.com; s=arc-20160816; b=a5p+MhaHxViewkUo/VmNvsiPV4weRMv05JxOjfP4eAR81xshQ+JsPtPaLc8YwYGPth XiXSIdXLGugb3NGL7z2nKloVVcf2DpKasS5zP/0OhPOcfuSBQaXt26atstOHpn7Ua2CE RH97+vaxRiIDIdDczNua2zXuGnMeNeliq9KLi6JzeJOVyNTSbZYH7Irvrxe3yyx3mxWf 3X31mW/lH+mmiZYbL9V9iGbj7ZgVPZUylkqbTTzq6NoZFXgcpHdaL/jz/Hbw/IzBY+UF 1sHmDTp6aKOSrvvW2kgyj+8I2qXW5rpPr0Zk4FlnmJ9k/Jr91LsjEZ1QimpIqoF41/gU 1gvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=rumQz+exsMOqih3jmSr+cClo25KdynN4hILa2nqgsAU=; b=FaLSK0+arzCIgf1uQCZVHAshlimeM/l4C8okPHKzJ7z+RkR/eBFzgkew1m9c7y8ehz DgrhkJWOL+aMfGU2kW3cFHDMTKNtUdELzJuaWWg7eak6PZdYfFxfy1jgBJ0y7pdWggVE j4cP2luiaIxK3O912NX8jvsL9qdTiQS02TgpKCWXZOwEisMn9EDuIoXGjwi0Bmz9lgjD 10FmqAvA664aS0HGc5pP4jIUMvc8omNkv7fbdWJz7okJmolvM2MSEi4QuMUPNhVhlrAn JeeNj2OE3nP99pE8iSpdKzz/uzWprHDaBJvs3ubAKU0AKOtWXZImu0gNyYFQ6P0sORPU 26Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=DN7z4MUM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i33si3458917ede.317.2019.10.31.04.01.53; Thu, 31 Oct 2019 04:02:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=DN7z4MUM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbfJaLBL (ORCPT + 99 others); Thu, 31 Oct 2019 07:01:11 -0400 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:59404 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727330AbfJaLBD (ORCPT ); Thu, 31 Oct 2019 07:01:03 -0400 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 6C9D1C08AD; Thu, 31 Oct 2019 11:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1572519662; bh=AAMOx6e5D47bkbXqXrtoDHy1k1iDqzrTt/zXJAhG2jI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=DN7z4MUMKRPVBbpT/IdvnwCsXEICMS/lTXrDaZVM4zU8llpWvVcGDA7XSi8Rgs9UH SfKSwjrSq0MH62XSA5Mp9uBdBSSDqTnl42/e03glpNL6aD4guL9+2BLUJMiJizBNaq Q4lYz4oLwsEGqXddaiMwnAKNuxgwLWFhddWK56qRS1vAbqrpr1HO25SmVBNkSwB9K7 f987f6bw8OGM/TsEjxNDLYnvGA4GQzbio8Mk8N/pB2twPaTpTnHlDUK58nxDsDi0lb okfK+hqClwsmWV9wHmDO2I/IieR+YvJdVc0tT/Xz7XbBUn7hpqxAhni56hGfiv3V9U lmb8Sx5tjkHAw== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 042CDA0069; Thu, 31 Oct 2019 11:01:00 +0000 (UTC) From: Jose Abreu To: netdev@vger.kernel.org Cc: Joao Pinto , Jose Abreu , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 03/10] net: stmmac: xgmac: bitrev32 returns u32 Date: Thu, 31 Oct 2019 12:00:41 +0100 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bitrev32 function returns an u32 var, not an int. Fix it. Fixes: 0efedbf11f07 ("net: stmmac: xgmac: Fix XGMAC selftests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c index e24382d00e62..b58522b8f782 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -463,7 +463,7 @@ static void dwxgmac2_set_filter(struct mac_device_info *hw, value |= XGMAC_FILTER_HMC; netdev_for_each_mc_addr(ha, dev) { - int nr = (bitrev32(~crc32_le(~0, ha->addr, 6)) >> + u32 nr = (bitrev32(~crc32_le(~0, ha->addr, 6)) >> (32 - mcbitslog2)); mc_filter[nr >> 5] |= (1 << (nr & 0x1F)); } -- 2.7.4