Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp982773ybx; Thu, 31 Oct 2019 04:04:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqyouHDHPQreKh4LbMkaaAzcNkEBenLD+oOdf9LmHSbs3vEHhH4SRbvRjkjbiSRrXE4r3uBn X-Received: by 2002:a05:6402:19ae:: with SMTP id o14mr3982097edz.241.1572519856805; Thu, 31 Oct 2019 04:04:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572519856; cv=none; d=google.com; s=arc-20160816; b=xv48WN4/uL/3E3ISDusCw7pHGsD9zj7K2zX6Km//grYQ8yx/x5ka5NfFrq82QTOnwf ivVYIIQ3d6z3acIkwuLef2gFId5xJFRGfCtv13g9RqYgcAcdEEJoPyh1ULiWh2wilveC g2cbvqJXkk6wUHOJg6ddi9ncUwe4TNb7GOL9LhVTIU/VwNIgcxJh73lLSuw3Pzmjvk7r dMQllr1KsA8rv/yEUInGgwBwv5Z9bzpge6b1HNMEc4Vghv8/omzW7LIJ+jkUCKs1SNJD x4xzBkvMkgE9q4D1CiBSwZ0bavn6+RMJ1XRB1ZUHLAM/5E6CTKiaftFkx9RdU54ViuPw XdXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=SSD5FkNG9rL257cTPL1UIct+YuQOF4NuXnstvuLp+gs=; b=vEYifGmL8C1aRizPyCGuAKI4S9IawAhxIMrKL+fmBDB9u1VRnCvRHCULB/rLfse95d PW2K4IaYFtjjvXGYr9K/035dgqCn09Iu0YNd0gyvqgGq0wLQIncNlUDkHOwL8Z6ZR4cl T2QtGemiFgLSOMmbLmkgQwOflEtez+W+vQLRDS8qMWj16EsHn5pNFfT17IimmGSLNcX4 jfka3FelY4s0EwFgaaSfNtr2wGq4hzbt5YTHKeX5QY7OR1O8edWXWNGDWmJ0FS7gLDJ8 94HNhHjiC+p7/aNwt5PC44QcjjaWKsOX4AdwnJkMjFUeCvIxKtimYrckeqptPaa4MZg2 ahsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=jUF9OEbk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id um11si3073647ejb.263.2019.10.31.04.03.53; Thu, 31 Oct 2019 04:04:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=jUF9OEbk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727393AbfJaLBD (ORCPT + 99 others); Thu, 31 Oct 2019 07:01:03 -0400 Received: from us03-smtprelay2.synopsys.com ([149.117.87.133]:59372 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727279AbfJaLBD (ORCPT ); Thu, 31 Oct 2019 07:01:03 -0400 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 6F0A2C08AE; Thu, 31 Oct 2019 11:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1572519662; bh=evZvvLApro5hVwuymO7sh6uSbwgwXdDeSzUoyB4odvQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=jUF9OEbkEjXwuDbMHuZ70RnPxHxJgnjH9Rtt3C67/RLVpTT97kUPFnQ3WkBVSfEbB 3mimPr7Re3x1Uv7YdZXVbOWjITJznpZYTRp6+19A3m76FqITT8ouEvpTFZVGgnMYao Iu0yiwG4U06FQ0B/rVoGUBTmCARqs4gIGDzvUCsNTLgD3QzP/Pyvw3TuZv8V/RrP88 +cYljxDzm32ACV/al8Mvg4pRyIGy0fAt2B7wH7Tfq60z7zMdFx5hXllXLqqxWgpiB0 2s7CteSSbdTLl3J2qOt5XacIqnA2wW6846eoixfulYUsiLH9P7LjbkE6IEKU5xDc1d ymQBjUxPwJ/5Q== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id E4388A0065; Thu, 31 Oct 2019 11:00:59 +0000 (UTC) From: Jose Abreu To: netdev@vger.kernel.org Cc: Joao Pinto , Jose Abreu , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 02/10] net: stmmac: gmac4: bitrev32 returns u32 Date: Thu, 31 Oct 2019 12:00:40 +0100 Message-Id: <897a8a6291b1533e6b64f2b85fc5a782983ccfe9.1572519070.git.Jose.Abreu@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bitrev32 function returns an u32 var, not an int. Fix it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index 365e607f07cd..40ca00e596dd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -432,7 +432,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw, * bits used depends on the hardware configuration * selected at core configuration time. */ - int bit_nr = bitrev32(~crc32_le(~0, ha->addr, + u32 bit_nr = bitrev32(~crc32_le(~0, ha->addr, ETH_ALEN)) >> (32 - mcbitslog2); /* The most significant bit determines the register to * use (H/L) while the other 5 bits determine the bit -- 2.7.4