Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <be4803c67e2e1f9e91e59bfd7b23f938619f66e8.camel@perches.com>
Subject: Re: [PATCH] mm/ioremap: Use WARN_ONCE instead of printk() +
 WARN_ON_ONCE()
From:   Joe Perches <joe@perches.com>
To:     zhong jiang <zhongjiang@huawei.com>, Borislav Petkov <bp@alien8.de>
Cc:     peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 31 Oct 2019 05:00:13 -0700
In-Reply-To: <5DBAC74E.5080001@huawei.com>
References: <1572425838-39158-1-git-send-email-zhongjiang@huawei.com>
         <20191031110304.GE21133@nazgul.tnic> <5DBAC74E.5080001@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-10-31 at 19:36 +0800, zhong jiang wrote:
> On 2019/10/31 19:03, Borislav Petkov wrote:
> > On Wed, Oct 30, 2019 at 04:57:18PM +0800, zhong jiang wrote:
> > > WARN_ONCE is more clear and simpler. Just replace it.
[]
> > > diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
[]
> > > @@ -172,9 +172,8 @@ static void __ioremap_check_mem(resource_size_t addr, unsigned long size,
> > >  		return NULL;
> > >  
> > >  	if (!phys_addr_valid(phys_addr)) {
> > > -		printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
> > > -		       (unsigned long long)phys_addr);
> > > -		WARN_ON_ONCE(1);
> > > +		WARN_ONCE(1, "ioremap: invalid physical address %llx\n",
> > > +			  (unsigned long long)phys_addr);
> > Does
> > 	WARN_ONCE(!phys_addr_valid(phys_addr),
> > 		  "ioremap: invalid physical address %llx\n",
> > 		  (unsigned long long)phys_addr);
> > 
> > work too?
> > 
> Thanks, That is better. Will repost.

Perhaps this is not good patch concept as now each
invalid physical address will not be emitted.

Before:
	each invalid physical address printed
	one stack dump

After:
	one stck dump with first invalid physical address.