Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1145565ybx; Thu, 31 Oct 2019 06:22:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZAgPWzHFqUKfZ7h7nSRg0aDGkbZ2azaT733DbM8kGEBg4AWML3BbpS5oEzVgoZd/IqjmZ X-Received: by 2002:a17:907:41ae:: with SMTP id of22mr3969075ejb.30.1572528165509; Thu, 31 Oct 2019 06:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572528165; cv=none; d=google.com; s=arc-20160816; b=FzJPenlBazbXLJETxtm+5BzbEe6VigfdbN8741ECDeLxepi8R8tBaT+9TFpTGAhO+B YMpyvRc9Zbgeb7yTvK+9O9gh4+oqRCEDylbLA0jrCRC1VNBhRNpd50ua49Lm0L1wO66y LVWpgwPsaL0HA3aLrVxRQwBjaF0J96SbMG+TSB32/pvwrJ2KjUhjY3vLKmnoNN5gkNEv u6DroUJXJhOfQSVa+IxzcITpUndN6IpjiEH2yMGpT86hbSs178IT67OVL59a/pL9eoSb sbT7q5Quxi4cTUg+C+Ao7FWWBtFQAtXZDU9CKXRox6BMtQdP3yhkEobD7b+1m92mDKi2 Uh4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2ifd5ovM9AoSL8d0s/U0l8+nqR4uIYQi1wR5b3uhayg=; b=KCvQoI+yjwKy0KwRDaFHlV5zdT9UEFP0l4YqVDyYQ3cVj5NQp6brJIVqlua13L0TsK V5wWSfeJZHtOmwHMUfL8FtsMk1INR+4QrO6DRD2txpDzYiSmjH1J6V6R6dYqLZLtN74A s8wiomEahJJgkn6DXgadJf6aLwTqYCCH01tg52pCT9fPC3fVy2qrB+E+rhO282EbPCYs DUilZEc4+xO4F9dKvikROL/B1pcdSGcyIYb550gVufz3HVQ6YXVzFWIfVClFGCWAe3eq HV60j3rioq+3p53DURVToSja7Ov6uJjG6V0oNqQY41Fyh4lIFrO/5YzmF8X5ef9+mBaa mamQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=TV2PGLT1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si4357739edi.445.2019.10.31.06.22.21; Thu, 31 Oct 2019 06:22:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=TV2PGLT1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbfJaNUb (ORCPT + 99 others); Thu, 31 Oct 2019 09:20:31 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:50524 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbfJaNUa (ORCPT ); Thu, 31 Oct 2019 09:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2ifd5ovM9AoSL8d0s/U0l8+nqR4uIYQi1wR5b3uhayg=; b=TV2PGLT1/fHPYrJ/nfvyb0+E+ PQ/PahNER7WR6MT0LmH/Fto0m0OO2VI/TgxF3PxDHxfb5Nw8bYWjsbVBZqtVID79eCdE44rVef5BU SGydLykO10UggutBB84CDGrrOWLskk3E95Bp3ym0H1bCktphOAH1KtPGbi4e5jnsKEotM=; Received: from [91.217.168.176] (helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iQAN0-0007nu-Jy; Thu, 31 Oct 2019 13:20:10 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 298D4D020AA; Thu, 31 Oct 2019 13:20:10 +0000 (GMT) Date: Thu, 31 Oct 2019 14:20:10 +0100 From: Mark Brown To: zhong jiang Cc: bardliao@realtek.com, oder_chiou@realtek.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static Message-ID: <20191031132010.GR4568@sirena.org.uk> References: <1571919319-4205-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XQ/JOjNzrAcf1KaA" Content-Disposition: inline In-Reply-To: <1571919319-4205-1-git-send-email-zhongjiang@huawei.com> X-Cookie: Keep out of the sunlight. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XQ/JOjNzrAcf1KaA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 24, 2019 at 08:15:19PM +0800, zhong jiang wrote: > The GCC complains the following warning. >=20 > sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_pag= e' was not declared. Should it be static? It looks like this has been fixed already in the latest code. --XQ/JOjNzrAcf1KaA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2634kACgkQJNaLcl1U h9A8KQf+PSbdofWiY5XFUVrKIJ6TvYvhkCTXoer7zqBiSsIZSptCLsR62aLe2Z+m 2dXj5FW5Y6JaDnFc+k/078SEiQW4bSOP5h6iyijF6Yj8LRpoen2YE22roMvzqsDR EpBiFoaRYTwhnVFE69/XT/bnPK3wMzKblk2+ENCMTTvfc5VS6pXDBMueO64G25C/ IaMuarHobO/oY1iUj+FJeHbIz9tJIwGPDKMYwfTVJjcmxlhMkfHsIFnCNq0tcy1O dwl+sQoVZ96hLeH7fC/v5bEO3n0xJ+eClpYsgIPDVqNSfC/3A2R5KPnZp7wLvEGF KLUdT/zuMdYe3s3NGBIH9xzhiRrT/w== =OAyt -----END PGP SIGNATURE----- --XQ/JOjNzrAcf1KaA--