Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1170475ybx; Thu, 31 Oct 2019 06:44:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtTa4R2SLlZQ9d5XlEyjNNM0MIN2uhfu2ywCyPaxzzSdBF9PxFaCwt+lNDbq9zcAojoemg X-Received: by 2002:aa7:d483:: with SMTP id b3mr6124704edr.178.1572529458437; Thu, 31 Oct 2019 06:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572529458; cv=none; d=google.com; s=arc-20160816; b=glwXOziFqyiwA4J1ZrngOpKNQz+ZL4WmJw2YsTprCVDvhPRzxiJU/5ShtAFVGycqOT +CvAIWRyJI7uCw/66finA3XEwP40PbWAfKB1i+XYDpECWf1JMz6Puw9wyNhZj/aJQa/W +1K35NhvEDUt9gFpFRpPDOn61ZdiEijOcXy3kUyXMi6GBuYCc1gkn5k5MoRdk3PaTaR/ WfAEpJ/gkSUFcD935eOo079d/HXxf2IPfTkkDQXMPnt36ba5WPxUaCVOeMcd6PdXTmnB 4tdZh4W78ccOMXpKl5eAL6eI7Em9kdOgJ8YrW66ceP7ZkKOw2jWCg/ENe6hsGk3Lls+S LLkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id; bh=GMKU3zUub3Q6j42f/cYSSfg6ROx4cfvoY0vplaQwW+s=; b=VaGf37PfS5sQQwJUWe4qo1WuozfHMvUrLrl7WOfMjzNkMaD8yDOIiMHyJ/DK4+87lE JDgBzIqppRyADYqHJTR1G/Qaf/m5JEubHZ5nIcxlJJe/kjCe6bB2iG/ledpjpheuIlWT 8B0I061rtg/ZS0bhzvDHs6AcMQoMii194M38ANHRd0YfuOzFljQrfmZw7yLPwcnqq+1B 4yJkhSDAuAblLJun5ToE3AfPYWadDBkmjgNESrnySEFZ9jNUcWC+sjuYOF0VTzjOr6/7 NfXMlo3cPuix4EpYfT1yKBMFHN6iTc1uxLExjtjsdv30aATZztE/KVz72gAxifZlH9Pp uAZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si4098819ejc.104.2019.10.31.06.43.54; Thu, 31 Oct 2019 06:44:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727549AbfJaNkr (ORCPT + 99 others); Thu, 31 Oct 2019 09:40:47 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:40512 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726803AbfJaNkr (ORCPT ); Thu, 31 Oct 2019 09:40:47 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 670877ED1617A348749B; Thu, 31 Oct 2019 21:40:43 +0800 (CST) Received: from [127.0.0.1] (10.133.219.218) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Thu, 31 Oct 2019 21:40:38 +0800 Message-ID: <5DBAE455.30406@huawei.com> Date: Thu, 31 Oct 2019 21:40:37 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Mark Brown CC: , , , , , Subject: Re: [PATCH] ASoC: rt5677: Make rt5677_spi_pcm_page static References: <1571919319-4205-1-git-send-email-zhongjiang@huawei.com> <20191031132010.GR4568@sirena.org.uk> In-Reply-To: <20191031132010.GR4568@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.219.218] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/31 21:20, Mark Brown wrote: > On Thu, Oct 24, 2019 at 08:15:19PM +0800, zhong jiang wrote: >> The GCC complains the following warning. >> >> sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static? > It looks like this has been fixed already in the latest code. Yes, I has noticed that. Thanks, zhong jiang