Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1223084ybx; Thu, 31 Oct 2019 07:27:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoWEiYD8XyOH+b7quPQyWlt1dogSDz8t7zbdKtZNkPceN96ISZ6icVV4UQ+IEHJyvLizem X-Received: by 2002:a17:906:1e55:: with SMTP id i21mr4426584ejj.47.1572532033858; Thu, 31 Oct 2019 07:27:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572532033; cv=none; d=google.com; s=arc-20160816; b=QnIuU/UG78YM4zSzIq0tBJQ89BrslGVCxdGYM6UxP1DK2KXhyOpaD6yGoESuvwfzQr lCeudqrzcDjaVhBFm6xKJDU4bqVscYH4YBn9Hte4YsFs7l7wH8tqxAlMzEFqSHWvxg/i Ej6LNhHhI3fMpxLXFtiVmQqivrcQk0dcBBio7+R6/fWoEkTEZVeJ4mFkW0AaWQHFrOQR MxyUitOOblCpG3yQb12oKMOaOG9u7ucfZsUvZjQGew2PAF9irQtxGQFAwxMxJLl8DodS ev1ybC33wCY545Y62Q/18L4MyxxPQzAbpXza8vak0Ax4Vmm0RPhZAXelCHRa50jpN0kv 2ZsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=rqP3g3fFmphpvY+0VVsjpXrhNP9u16xKGtZWsaQjFVM=; b=RaBBdvc6bLUerr+1+KxX43IkexfFGO1iMA1YtsiYv008Jg6gWQYQ0LdUuoGC5XMSmG +1aMTbT8cE+zW2/17z5nXMpXMCo4urHQCvzXKqpQSqZqSnuCnldLLFQPnw1XW17fCI9F eXCOajCVS4aOnr2zKdiFRsc3WiNeG64QO+E6w5srWPMSY4xc/NE8TCzL0qKN3bC23lK8 UTc6quDOVndoW11mDJKMBEEi1BtZ2VbMIYkd8E9HDM+KQvbQWd0+K3A40vbMHRSUfZ/c z81KetHAkdIxitCFhQYHQCQUgMuegE2WBkgCGfMEUNqQMACp1vU1mSmYomcFG6029dEL f8Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si1635497edr.194.2019.10.31.07.26.50; Thu, 31 Oct 2019 07:27:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbfJaOZG (ORCPT + 99 others); Thu, 31 Oct 2019 10:25:06 -0400 Received: from foss.arm.com ([217.140.110.172]:49428 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727705AbfJaOZE (ORCPT ); Thu, 31 Oct 2019 10:25:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 621671F1; Thu, 31 Oct 2019 07:25:04 -0700 (PDT) Received: from [172.20.53.248] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B183F3F71E; Thu, 31 Oct 2019 07:25:00 -0700 (PDT) Subject: Re: NULL pointer dereference in pick_next_task_fair From: Valentin Schneider To: Ram Muthiah , Quentin Perret Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, aaron.lwe@gmail.com, mingo@kernel.org, pauld@redhat.com, jdesfossez@digitalocean.com, naravamudan@digitalocean.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, kernel-team@android.com, john.stultz@linaro.org References: <20191028174603.GA246917@google.com> <20191029113411.GP4643@worktop.programming.kicks-ass.net> <20191029115000.GA11194@google.com> <75e99374-0bd6-a7d7-581e-9360a1f90103@arm.com> <8d8fe4e9-1905-cde1-9ced-0a860e5a961b@arm.com> Message-ID: <4f743a74-9b9c-d7e4-bae8-c7ad1d2aeee6@arm.com> Date: Thu, 31 Oct 2019 15:24:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8d8fe4e9-1905-cde1-9ced-0a860e5a961b@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/10/2019 11:54, Valentin Schneider wrote: > On 31/10/2019 02:33, Valentin Schneider wrote: >> For wakeups, select_task_rq_fair() can only ever pick prev_cpu or this_cpu >> since there are no sched domains. I don't see many candidates that could >> wakeup on a secondary (thus have non-zero this_cpu) this early there. And another fail here, this doesn't have to be at secondary bringup, it's just that the bringup will always be in the idle task's callstack (if the timestamps weren't enough of a clue already). I guess I'll stop writing nonsense and keep staring in silence.