Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Michal Hocko <mhocko@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Shakeel Butt" <shakeelb@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        "Waiman Long" <longman@redhat.com>,
        Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH 09/16] mm: memcg/slab: charge individual slab objects
 instead of pages
Thread-Topic: [PATCH 09/16] mm: memcg/slab: charge individual slab objects
 instead of pages
Thread-Index: AQHVhUr89wbCEoSSmkSojIAthXBDTadrzcEAgAhDaACAANbqgIAABwOA
Date:   Thu, 31 Oct 2019 15:07:02 +0000
Message-ID: <20191031150657.GA31765@tower.DHCP.thefacebook.com>
References: <20191018002820.307763-1-guro@fb.com>
 <20191018002820.307763-10-guro@fb.com> <20191025194118.GA393641@cmpxchg.org>
 <20191031015238.GA21323@castle.DHCP.thefacebook.com>
 <20191031144151.GB1168@cmpxchg.org>
In-Reply-To: <20191031144151.GB1168@cmpxchg.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::1:3748]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 70d1a8bd-6c31-4f76-45f6-08d75e13fbcf
x-ms-traffictypediagnostic: BN8PR15MB2627:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR15MB262741F515E27A2B812D4344BE630@BN8PR15MB2627.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 02070414A1
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(136003)(346002)(39860400002)(189003)(199004)(54906003)(7736002)(8936002)(6486002)(8676002)(486006)(25786009)(46003)(6436002)(476003)(5660300002)(2906002)(446003)(81156014)(81166006)(9686003)(11346002)(6512007)(305945005)(1076003)(6916009)(6116002)(186003)(33656002)(386003)(66446008)(99286004)(6506007)(64756008)(86362001)(102836004)(14454004)(4326008)(66946007)(316002)(52116002)(76176011)(478600001)(229853002)(66556008)(6246003)(14444005)(71200400001)(256004)(71190400001)(66476007);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB2627;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: jsUUQ3J8FN+o+qLV7nLWcymO6uSkat4vVm6clT8al88FlIvEXeEzcjOGjzDSLqEpkZK3mFGkFCkWHIDNiO0t1lxGwuzzsKbQxFNaZJLC+h1vdud4G85F2IC9ax6RFMkujIaTat99ApS2zN2w8Wu6uqmkd4Bpyz+9IT1D4snb8v2p3/feXmYMzGtwjMhKr9iRX/1v+GC7c08zYqnI3ohyYS7mL2ValkKY1mT/T9zpkOkJlBil+qgnl1xgKz7+fTCQ+j+tbkjikkIwRqcAhllOXQWe/oZFCiFAQ//y3QRRgEtYk+XlEe4Fs6z2dTiMEFqIk53lDToIxD9JXA7Nz/ag4/kIAqpioDI84JYV7LtrpfIw7jVxdcOSK5tj0cinGA1drKIvvrfe07Zvr+O6w98EBVbUu1hRgxjv709fBBFDrkVSrxmytPScBV2tudBkf9xj
Content-Type: text/plain; charset="us-ascii"
Content-ID: <599C994690A61041AD935BB8453A9F22@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 70d1a8bd-6c31-4f76-45f6-08d75e13fbcf
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 15:07:02.1197
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zKqY43CPRRpnob01h8AI2HObGd+OjfpX7b89fQJRHiGST00VZ5WVQA4WvcSLpsLg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2627
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-31_06:2019-10-30,2019-10-31 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 suspectscore=0
 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1910310155
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 31, 2019 at 10:41:51AM -0400, Johannes Weiner wrote:
> On Thu, Oct 31, 2019 at 01:52:44AM +0000, Roman Gushchin wrote:
> > On Fri, Oct 25, 2019 at 03:41:18PM -0400, Johannes Weiner wrote:
> > > @@ -3117,15 +3095,24 @@ void __memcg_kmem_uncharge(struct page *page,=
 int order)
> > >  	css_put_many(&memcg->css, nr_pages);
> > >  }
> > > =20
> > > -int __memcg_kmem_charge_subpage(struct mem_cgroup *memcg, size_t siz=
e,
> > > -				gfp_t gfp)
> > > +int obj_cgroup_charge(struct obj_cgroup *objcg, size_t size, gfp_t g=
fp)
> > >  {
> > > -	return try_charge(memcg, gfp, size, true);
> > > +	int ret;
> > > +
> > > +	if (consume_obj_stock(objcg, nr_bytes))
> > > +		return 0;
> > > +
> > > +	ret =3D try_charge(objcg->memcg, gfp, 1);
> > > +	if (ret)
> > > +		return ret;
>=20
> > The second problem is also here. If a task belonging to a different mem=
cg
> > is scheduled on this cpu, most likely we will need to refill both stock=
s,
> > even if we need only a small temporarily allocation.
>=20
> Yes, that's a good thing. The reason we have the per-cpu caches in the
> first place is because most likely the same cgroup will perform
> several allocations. Both the slab allocator and the page allocator
> have per-cpu caches for the same reason. I don't really understand
> what the argument is.

I mean it seems strange (and most likely will show up in perf numbers)
to move a page from one stock to another. Is there a reason why do you want
to ask try_charge() and stock only a single page?

Can we do the following instead?

1) add a boolean argument to try_charge() to bypass the consume_stock() cal=
l
at the beginning and just go slow path immediately
2) use try_charge() with this argument set to true to fill the objc/subpage
stock with MEMCG_CHARGE_BATCH pages

In this case we'll reuse try_charge() and will have all corresponding benef=
its,
but will avoid the double stocking, which seems as a strange idea to me.

>=20
> > > +
> > > +	refill_obj_stock(objcg, PAGE_SIZE - size);
> >=20
> > And the third problem is here. Percpu allocations (on which accounting =
I'm
> > working right now) can be larger than a page.
>=20
> How about this?
>=20
> 	nr_pages =3D round_up(size, PAGE_SIZE);
> 	try_charge(objcg->memcg, nr_pages);
> 	refill_obj_stock(objcg, size % PAGE_SIZE);

Ok, this will work.

>=20
> > This is fairly small issue in comparison to the first one. But it illus=
trates
> > well the main point: we can't simple get a page from the existing API a=
nd
> > sublease it in parts. The problem is that we need to break the main pri=
nciple
> > that a page belongs to a single memcg.
>=20
> We can change the underlying assumptions of the existing API if they
> are no longer correct. We don't have to invent a parallel stack.

Ok, this makes sense. And thank you for the patch, I'll take it into the se=
t.

Thanks!