Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1279809ybx; Thu, 31 Oct 2019 08:15:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/Yp0pCccJe/4acVdeZ3T5JynCdcQWkKvDO3XN3cnCVf5U9HZkfqRC2QNPJKEn3tCd7O2V X-Received: by 2002:aa7:cad0:: with SMTP id l16mr3310508edt.82.1572534946314; Thu, 31 Oct 2019 08:15:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572534946; cv=none; d=google.com; s=arc-20160816; b=gl6cvQF1k4tCl6ptIP5A3UNt/v6GT11MQRe29yp/+FaV9obgw4IYcbcNIO4U8BHsQ9 tXrVaIA6TUeBTGZVElbC9EsLy9UrqbfwhhtiHHWVRvIqywNauNF5ZxDxOj2K+y8eRBnx WVoBs1jqJABwoOxFtRiqvWku02GXMQkQCrS15d1EAJCDw2HSsE7DMGhL4PlqihinBhAP 4jLpEKsHZhEnFeNiXrWiYn+CIXtsbSGsW89fIO1ei1Bnmw7NQ2/vy/V+16NKJFZxHRAS 3qBRZgJGLfjtCuecXmjqdG7lMkite52hX1WwLFZEujkp1x5D2XTStgTzayEAFHoC4oSh 4Vow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id:date :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=FNwFRZjnDpMMCUFzfJOSVzkAkD/c1c7Ojt9o9rhUq2Y=; b=mjBs+2qBmIWMmBLQflmRWuMHDjsszzzyHP/5ehDjVIuuujrsNxP7fBd/K3VAOyQgfg DAWOos967R25o4CnKPpbM1PqbLgpxOGOj9qlRwZsQjxx4i8sWMEL2EQ+hqnzGVbjcVC3 UyIIoWix6gXjDHsml/32airdAMl6MYdw19+YgfUD4U5mPQp42iSwCULxc2UX1hmpnaAW 6Pa3csvaSlmlmRopLVzFfQQj9frAie8ZjPGxMMd8WzIXlmvVMDAkQevvMknQbFCSJWf7 fzMGNqlrs6d9gHBEd/CTmPkN+q5iTWisoiOSuLQdtT7harn03M3BjaJPQkhp4ynwf41Z 8hhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eTisoTQL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27si4117704eji.207.2019.10.31.08.15.22; Thu, 31 Oct 2019 08:15:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eTisoTQL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbfJaPN1 (ORCPT + 99 others); Thu, 31 Oct 2019 11:13:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50607 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726566AbfJaPN0 (ORCPT ); Thu, 31 Oct 2019 11:13:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572534805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNwFRZjnDpMMCUFzfJOSVzkAkD/c1c7Ojt9o9rhUq2Y=; b=eTisoTQLr5iStvNrpLpqaYPe2y5YzdvVpdoNVUAZHcB8GQw7qHmMzdGmj1/Nnd+8Brlg6r bgDhkeGG+3GXa5bjzRAAVCR2c4R7LEmlYvxg+8A7MS+N8lYR7AdVUC/NDCUhc2B0CVEIJR /A9fUlEWbOIn/+fkFgiOC2vQbxYp1vQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-jD0V8FpeNOqkFxE4eETZKg-1; Thu, 31 Oct 2019 11:13:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 839B11800D6B; Thu, 31 Oct 2019 15:13:20 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-40.rdu2.redhat.com [10.10.121.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97A915DA7D; Thu, 31 Oct 2019 15:13:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20191027152223.GA21194@infradead.org> References: <20191027152223.GA21194@infradead.org> <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> <30394.1571936252@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, torvalds@linux-foundation.org, Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 11/10] pipe: Add fsync() support [ver #2] MIME-Version: 1.0 Content-ID: <17041.1572534796.1@warthog.procyon.org.uk> Date: Thu, 31 Oct 2019 15:13:16 +0000 Message-ID: <17042.1572534796@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: jD0V8FpeNOqkFxE4eETZKg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > I am _really_ worried about overloading fsync for this behavior. fsync > hasn't done anything for 50 years, and suddenly adding any action > is not helpful. If you can't use FIONREAD please add a new ioctls > instead, and document it properly. Okay. David