Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1305095ybx; Thu, 31 Oct 2019 08:37:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxu730ed97UUIV5dr37V/6W0xOAbExd+oV9kw81X5VC2W5OuUU4+Y+uYJY1ciwh7IzEWPyA X-Received: by 2002:a17:906:4b16:: with SMTP id y22mr4818612eju.56.1572536260449; Thu, 31 Oct 2019 08:37:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572536260; cv=none; d=google.com; s=arc-20160816; b=xHTK1vycGcIPcNMXeh5SgYw9aPJUaXWAePbdfieEW6Deu/Avk57z8zPwsCAJCkgPB4 IzVK581jdNsxip2I3+AJdGEaG3powIdQQWL79TbMoTRru0pGsalMT2BZSuLyPL+ItqOK kvU3mMMTvMySiC8vYk+WfvBvegFPQW7+4Pk6rkkCQ0pZTtPKhrbL8qanxYffkasfMHXg 2y5yWN7R+SHP6j9KbLXGfeOPsLJd2sS+qJmfntN6lr5IJkXn/ARN/pF59ZHMwNzUpB6j AmG4wi58t1ruH/KkB9wfrqqsdn6LVpMTCDBJy7QXcweDEVhy2/O0CeGVozW6D+TaGdtv LbzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=N2iJITsX7J3IxU+A4ImEzWynPwkmLsPEHLLm8xsMKRc=; b=nsSH5QoQYiCbmXnETlhPT7Fcg85YK4/aOXyeTRmRYvlo7L32xfXDWMoWAu2AKAflq+ yuChZ9QsPrU4P5VjaJoiDAiWvIVX70npWw6AHcNkEaK8WTgwVWzQuZs5hFKRFYZ1XaGo 9ZgrRVTazSx3MpkV7Kh4dgJAuItqAGnJXelB/+BwtI3nr8Kxy06YlkLm2dBQeGajbv9H nqlVYwr1hWPhGWHTxDW6WSCJFrvA6BXNayF8psroQQrwS2f+duvNzJfBDs7oL5w8zyoJ twONzDOG/Ej14FQJS+kBsvxdqCxBpc7MEvr3iWp81tdbWOqqhiPnbOyOJ+V3l0z+T0hI qP5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SgK0nkFL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si4718872edc.403.2019.10.31.08.37.16; Thu, 31 Oct 2019 08:37:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SgK0nkFL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728207AbfJaPgE (ORCPT + 99 others); Thu, 31 Oct 2019 11:36:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:49142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbfJaPgE (ORCPT ); Thu, 31 Oct 2019 11:36:04 -0400 Received: from localhost (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BD632086D; Thu, 31 Oct 2019 15:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572536163; bh=AbvQStO4mftxwOLZ6Vl8wEv4VUDwqs8YdcH3DMqFFYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SgK0nkFL/OFf39EmgXyG/cwq07tF9zrAreYfzEZ96SVGFKha6hnCKad0/aaVbdJ+l DiTmvprYSSf1qmHgsy1CNs0dW2uNwTc9ki2AMyLcuQEeTQDVdiqNYznTyttAYf6SQZ Ug1rsN0rcIK7euU0dn26eb8hJ6iD4r6Fbi52ufKg= Date: Thu, 31 Oct 2019 11:36:00 -0400 From: Sasha Levin To: Lakshmi Ramasubramanian Cc: zohar@linux.ibm.com, dhowells@redhat.com, matthewgarrett@google.com, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, prsriva@linux.microsoft.com Subject: Re: [PATCH v3 1/9] KEYS: Defined an IMA hook to measure keys on key create or update Message-ID: <20191031153600.GR1554@sasha-vm> References: <20191031011910.2574-1-nramas@linux.microsoft.com> <20191031011910.2574-2-nramas@linux.microsoft.com> <20191031091041.GO1554@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 08:27:47AM -0700, Lakshmi Ramasubramanian wrote: >On 10/31/19 2:10 AM, Sasha Levin wrote: > >Hi Sasha, > >>On Wed, Oct 30, 2019 at 06:19:02PM -0700, Lakshmi Ramasubramanian wrote: >>>Asymmetric keys used for verifying file signatures or certificates >>>are currently not included in the IMA measurement list. >>> >>>This patch defines a new IMA hook namely ima_post_key_create_or_update() >>>to measure asymmetric keys. >>> >>>Signed-off-by: Lakshmi Ramasubramanian >> >>What are the prerequisites for this patch? > >I built this patch set on kernel v5.3 > >I applied the following patch provided by Nayna Jain@IBM and then >added my changes: > > [PATCH v9 5/8] ima: make process_buffer_measurement() generic $ git checkout v5.3 HEAD is now at 4d856f72c10ec Linux 5.3 $ git am ~/incoming/_PATCH_v9_5-8_ima_make_process_buffer_measurement__generic.patch Applying: ima: make process_buffer_measurement() generic error: patch failed: security/integrity/ima/ima.h:217 error: security/integrity/ima/ima.h: patch does not apply What am I missing? -- Thanks, Sasha