Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Michal Hocko <mhocko@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Vladimir Davydov" <vdavydov.dev@gmail.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH v2] mm: slab: make page_cgroup_ino() to recognize
 non-compound slab pages properly
Thread-Topic: [PATCH v2] mm: slab: make page_cgroup_ino() to recognize
 non-compound slab pages properly
Thread-Index: AQHVj4mh+jLaqEXqpUiu7sTYH2ejead0JMMAgABaHgCAAGeNAA==
Date:   Thu, 31 Oct 2019 15:49:22 +0000
Message-ID: <20191031154918.GB31765@tower.DHCP.thefacebook.com>
References: <20191031012151.2722280-1-guro@fb.com>
 <20191030211608.29f8fc92e07fd2ac2ef4d1d3@linux-foundation.org>
 <20191031093840.GA9178@hori.linux.bs1.fc.nec.co.jp>
In-Reply-To: <20191031093840.GA9178@hori.linux.bs1.fc.nec.co.jp>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::3:b4b3]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: aaf7965c-3a06-4990-353b-08d75e19e639
x-ms-traffictypediagnostic: BN8PR15MB2836:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR15MB2836FBD72DC5D14B1B988E30BE630@BN8PR15MB2836.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 02070414A1
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(376002)(346002)(396003)(366004)(136003)(199004)(189003)(66946007)(66556008)(8936002)(86362001)(81156014)(486006)(11346002)(8676002)(6116002)(1076003)(66446008)(52116002)(476003)(66476007)(99286004)(14454004)(64756008)(81166006)(4326008)(6246003)(446003)(316002)(76176011)(386003)(186003)(6436002)(478600001)(71200400001)(6506007)(256004)(54906003)(71190400001)(14444005)(46003)(229853002)(5660300002)(102836004)(25786009)(6512007)(9686003)(7736002)(33656002)(2906002)(6486002)(305945005)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR15MB2836;H:BN8PR15MB2626.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: X3j4kLQw3rVNiYOr+Dhcp6K49goKoeWsAyuGeDFqXAc5Sonaw3qiOyL0bsTnpHVWDFAKgocKAZlkdxGUGV/v1mzKYbjVbeKL6eYjX7KZLAwVfbp1JXffb2Kpp1viJ/PMw84ybtR8LbVlTHfKwSTCnBcHJYF75+CfnQAt/zL7kRDY9nhtdHTApoMrSTHu8f8Voc9mIadhKuP/ii7I0WmeJPEQvzDxx+xVVHli88Ul/RRTHkJBB42X06Erb3Z/Zk1nzCauC4VcozSp+o69E7cVyinc6CIg4ACW5Td2Xap9lB3X+tSX9bCrMFyxpFcsHtKnHsxklm7O9EzUoC8hjE+qn8J/gVSdTPwbFPYHCGxFk9WyaK5C18C1AVQQZMppMyCsOXyJCK2TJai+0QZYVOfrjzfbDkE5qGwULrVXmVnbGBpaXQUqIEITVxf+W4S5QFOT
Content-Type: text/plain; charset="us-ascii"
Content-ID: <93BE932408AEDF4AB353BB35E5BE1331@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aaf7965c-3a06-4990-353b-08d75e19e639
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 15:49:22.8305
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XI6BOQWb6RDF11EH01oyKblUifBv87iJ/FafGYPNzp/u0AxvosZQHsLH+ohHlcmy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2836
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-31_06:2019-10-30,2019-10-31 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 spamscore=0
 mlxscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0
 lowpriorityscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-1908290000 definitions=main-1910310159
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 31, 2019 at 09:38:40AM +0000, Naoya Horiguchi wrote:
> On Wed, Oct 30, 2019 at 09:16:08PM -0700, Andrew Morton wrote:
> > On Wed, 30 Oct 2019 18:21:51 -0700 Roman Gushchin <guro@fb.com> wrote:
> >=20
> > > page_cgroup_ino() doesn't return a valid memcg pointer for non-compou=
nd
> > > slab pages, because it depends on PgHead AND PgSlab flags to be set
> > > to determine the memory cgroup from the kmem_cache.
> > > It's correct for compound pages, but not for generic small pages. Tho=
se
> > > don't have PgHead set, so it ends up returning zero.
> > >=20
> > > Fix this by replacing the condition to PageSlab() && !PageTail().
> > >=20
> > > Before this patch:
> > > [root@localhost ~]# ./page-types -c /sys/fs/cgroup/user.slice/user-0.=
slice/user@0.service/ | grep slab
> > > 0x0000000000000080	        38        0  _______S_____________________=
______________	slab
> > >=20
> > > After this patch:
> > > [root@localhost ~]# ./page-types -c /sys/fs/cgroup/user.slice/user-0.=
slice/user@0.service/ | grep slab
> > > 0x0000000000000080	       147        0  _______S_____________________=
______________	slab
> > >=20
> > > Fixes: 4d96ba353075 ("mm: memcg/slab: stop setting page->mem_cgroup p=
ointer for slab pages")
> > > Signed-off-by: Roman Gushchin <guro@fb.com>
> > > Reviewed-by: Shakeel Butt <shakeelb@google.com>
> > > Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> > > Cc: Daniel Jordan <daniel.m.jordan@oracle.com>
> >=20
> > Affects /proc/kpagecgroup, but page_cgroup_ino() is also used in the
> > memory-failure code - I wonder what effect this bug has there?
>=20
> hwpoison_filter_task() uses output of page_cgroup_ino() in order to
> filter error injection events based on memcg.
> So if page_cgroup_ino() fails to return memcg pointer, we just fail
> to inject memory error.  Considering that hwpoison filter is for testing,
> affected users are limited and the impact should be marginal.
>=20
> >=20
> > IOW, should we backport this into -stable?
>=20
> I think yes, because the patch is small enough and clearly fixes a bug.

I agree.

Thanks!