Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5DBB03B0.5060003@huawei.com>
Date:   Thu, 31 Oct 2019 23:54:24 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Borislav Petkov <bp@alien8.de>
CC:     <peterz@infradead.org>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <hpa@zytor.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/ioremap: Use WARN_ONCE instead of printk() + WARN_ON_ONCE()
References: <1572425838-39158-1-git-send-email-zhongjiang@huawei.com> <20191031110304.GE21133@nazgul.tnic> <5DBACB61.90809@huawei.com> <20191031154916.GA24152@nazgul.tnic>
In-Reply-To: <20191031154916.GA24152@nazgul.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/10/31 23:49, Borislav Petkov wrote:
> On Thu, Oct 31, 2019 at 07:54:09PM +0800, zhong jiang wrote:
>> Look at this again, It should not works. Because that will change the logical.
>> if phys_addr_valid is false, we should drop out in time.
> That you can do too:
>
> diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
> index a39dcdb5ae34..13f44cc064af 100644
> --- a/arch/x86/mm/ioremap.c
> +++ b/arch/x86/mm/ioremap.c
> @@ -171,12 +171,10 @@ __ioremap_caller(resource_size_t phys_addr, unsigned long size,
>  	if (!size || last_addr < phys_addr)
>  		return NULL;
>  
> -	if (!phys_addr_valid(phys_addr)) {
> -		printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
> -		       (unsigned long long)phys_addr);
> -		WARN_ON_ONCE(1);
> +	if (WARN_ONCE(!phys_addr_valid(phys_addr),
> +	    "ioremap: invalid physical address %llx\n",
> +	    (unsigned long long)phys_addr))
>  		return NULL;
> -	}
>  
Yep,  WARN_ONCE alway return true in that case.

Thanks,
zhong jiang
>  	__ioremap_check_mem(phys_addr, size, &io_desc);
>  
> ---
>
> I'm not sure whether we care about printing every invalid address, as
> Joe points out. Maybe we do... *shrug*
>