Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Jacky Bai <ping.bai@nxp.com>, Jun Li <jun.li@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Duan <fugang.duan@nxp.com>
Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
 fec1
Thread-Topic: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
 fec1
Thread-Index: AQHVh/j+k1XoWkwF8kWzRGGsNvXoFQ==
Date:   Thu, 31 Oct 2019 18:59:51 +0000
Message-ID: <VI1PR04MB70239911C3C71E0503808F85EE630@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <1571652977-4754-1-git-send-email-peng.fan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b70f40ea-6da6-452e-1dd8-08d75e348262
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 18:59:51.4067
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Gzy1hvxwGphpPab87wVwFJKvQZIa0R8mRyR47HU12I9+2I8Gmfm2dhAj+o8Polr38mdUZNVP9jR4Yf/7D1QojQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5038
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21.10.2019 13:19, Peng Fan wrote:=0A=
> From: Peng Fan <peng.fan@nxp.com>=0A=
> =0A=
> We should not rely on bootloader to configure the phy reset.=0A=
> So introduce phy-reset-gpios property to let Linux handle phy reset=0A=
> itself.=0A=
> =0A=
> Signed-off-by: Peng Fan <peng.fan@nxp.com>=0A=
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>=0A=
=0A=
This broke NFS boot for me in next-20191031: board now hangs on DHCP.=0A=
=0A=
It can be fixed by reverting this DT patch or by setting =0A=
CONFIG_AT803X_PHY to y instead of m.=0A=
=0A=
Needing a phy module is not a bug but everybody will need to either =0A=
adjust .config or build modules into an initramfs somehow.=0A=
=0A=
> ---=0A=
> =0A=
> V2:=0A=
>   U-Boot->bootloader=0A=
>   Add R-b tag=0A=
> =0A=
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +=0A=
>   1 file changed, 1 insertion(+)=0A=
> =0A=
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/bo=
ot/dts/freescale/imx8mm-evk.dts=0A=
> index faefb7182af1..e4d66f7db09d 100644=0A=
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts=0A=
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts=0A=
> @@ -80,6 +80,7 @@=0A=
>   	pinctrl-0 =3D <&pinctrl_fec1>;=0A=
>   	phy-mode =3D "rgmii-id";=0A=
>   	phy-handle =3D <&ethphy0>;=0A=
> +	phy-reset-gpios =3D <&gpio4 22 GPIO_ACTIVE_LOW>;=0A=
>   	fsl,magic-packet;=0A=
>   	status =3D "okay";=0A=