Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 31 Oct 2019 13:56:10 -0700 (PDT)
Message-Id: <20191031.135610.684836389491757031.davem@davemloft.net>
To:     natechancellor@gmail.com
Cc:     jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] mlxsw: Fix 64-bit division in
 mlxsw_sp_sb_prs_init
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191030160152.11305-1-natechancellor@gmail.com>
References: <20191030160152.11305-1-natechancellor@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 30 Oct 2019 09:01:52 -0700

> When building for 32-bit ARM, there is a link time error because of a
> 64-bit division:
> 
> ld.lld: error: undefined symbol: __aeabi_uldivmod
>>>> referenced by spectrum_buffers.c
>>>>               net/ethernet/mellanox/mlxsw/spectrum_buffers.o:(mlxsw_sp_buffers_init) in archive drivers/built-in.a
>>>> did you mean: __aeabi_uidivmod
>>>> defined in: arch/arm/lib/lib.a(lib1funcs.o
> 
> Avoid this by using div_u64, which is designed to avoid this problem.
> 
> Fixes: bc9f6e94bcb5 ("mlxsw: spectrum_buffers: Calculate the size of the main pool")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied, thanks.