Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peng Fan <peng.fan@nxp.com>
To:     Leonard Crestez <leonard.crestez@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Jacky Bai <ping.bai@nxp.com>, Jun Li <jun.li@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Duan <fugang.duan@nxp.com>
Subject: RE: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
 fec1
Thread-Topic: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
 fec1
Thread-Index: AQHVh/j+k1XoWkwF8kWzRGGsNvXoFad1lK+Q
Date:   Fri, 1 Nov 2019 01:20:22 +0000
Message-ID: <AM0PR04MB448130E87B85C5F5AB31496288620@AM0PR04MB4481.eurprd04.prod.outlook.com>
References: <1571652977-4754-1-git-send-email-peng.fan@nxp.com>
 <VI1PR04MB70239911C3C71E0503808F85EE630@VI1PR04MB7023.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB70239911C3C71E0503808F85EE630@VI1PR04MB7023.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 63dc22d6-544f-4045-3fc8-08d75e69aaa3
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2019 01:20:22.2087
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zbYErQWXZQpIjuK/pboxE6EFavLN5Nf9BlnXetQb7fg3TahKlKpdjtEUydal7dy8jmx2CB+zgctnrGRAvnLgXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6148
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios f=
or
> fec1
>=20
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>=20
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.
>=20

Sorry for this. I not use sdcard when I did the test.

> It can be fixed by reverting this DT patch or by setting CONFIG_AT803X_PH=
Y
> to y instead of m.

I prefer setting CONFIG_AT803X_PHY.

Thanks,
Peng.

>=20
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.
>=20
> > ---
> >
> > V2:
> >   U-Boot->bootloader
> >   Add R-b tag
> >
> >   arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> >   	pinctrl-0 =3D <&pinctrl_fec1>;
> >   	phy-mode =3D "rgmii-id";
> >   	phy-handle =3D <&ethphy0>;
> > +	phy-reset-gpios =3D <&gpio4 22 GPIO_ACTIVE_LOW>;
> >   	fsl,magic-packet;
> >   	status =3D "okay";