Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191031231104.30725-1-karlp@tweak.net.au>
In-Reply-To: <20191031231104.30725-1-karlp@tweak.net.au>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Fri, 1 Nov 2019 10:42:37 +0800
Message-ID: <CAGb2v64pYuA6yN3CYEv=MUeD+pSb49UauukehENzVsBvHhDx=w@mail.gmail.com>
Subject: Re: [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins
To:     Karl Palsson <karlp@tweak.net.au>
Cc:     Maxime Ripard <mripard@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 1, 2019 at 7:16 AM Karl Palsson <karlp@tweak.net.au> wrote:
>
> uart1 and uart3 had existing pin definitions for the rts/cts pairs.
> Add definitions for uart2 as well.
>
> Signed-off-by: Karl Palsson <karlp@tweak.net.au>
> ---
>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 84977d4eb97a..2d8637300321 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -472,6 +472,11 @@
>                                 function = "uart2";
>                         };
>
> +                       uart2_rts_cts_pins: uart2-rts-cts-pins {

We started adding "/omit-if-no-ref/" for all pin definitions that
aren't selected by default. I think we can do this wholesale for
all the ones in this file after this patch is merged though. So,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> +                               pins = "PA2", "PA3";
> +                               function = "uart2";
> +                       };
> +
>                         uart3_pins: uart3-pins {
>                                 pins = "PA13", "PA14";
>                                 function = "uart3";
> --
> 2.20.1
>