Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Fail (protection.outlook.com: domain of arm.com does not
 designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Mihail Atanassov <Mihail.Atanassov@arm.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
        nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: Re: [3/5] drm/komeda: Optionally dump DRM state on interrupts
Thread-Topic: [3/5] drm/komeda: Optionally dump DRM state on interrupts
Thread-Index: AQHVkIRdkRYOh8AuQkiwt0Vv1/Eykw==
Date:   Fri, 1 Nov 2019 07:17:06 +0000
Message-ID: <20191101071659.GA30189@jamwan02-TSP300>
References: <20191021164654.9642-4-mihail.atanassov@arm.com>
In-Reply-To: <20191021164654.9642-4-mihail.atanassov@arm.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: c1926b1f-cc71-4489-9310-08d75e9b84b7
X-MS-TrafficTypeDiagnostic: VE1PR08MB4974:|VE1PR08MB4974:|DB6PR08MB2933:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <DB6PR08MB293332E593806D1E25E8CFC6B3620@DB6PR08MB2933.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
x-forefront-prvs: 020877E0CB
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(199004)(189003)(25786009)(8936002)(6486002)(6246003)(81166006)(229853002)(14444005)(7736002)(71190400001)(476003)(478600001)(5660300002)(486006)(256004)(8676002)(2906002)(3846002)(71200400001)(305945005)(81156014)(6116002)(64756008)(55236004)(66446008)(102836004)(66066001)(66556008)(86362001)(6506007)(4326008)(186003)(6512007)(66476007)(6436002)(316002)(386003)(6862004)(76176011)(99286004)(26005)(54906003)(14454004)(52116002)(33716001)(9686003)(446003)(11346002)(1076003)(58126008)(6636002)(33656002)(66946007);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4974;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: v8iB8w+gQYQTyhPc1S2KQy1aXfUF/eIdc41px5QGbTyugAX/N5rLybWgY6XhAM9cO3GnXmOsAjzT3ka03ifzjP4Sgqh0LUVjo/9gmnZTjuzBHksgdbeF5yyKmW9FKt0aCIpmGFfFJddIafgwksTmHtWXnyMhW0mdjAkfb9Wp3VGePet4OV0lQwREcOCu+qmjvEwlL6s8/BkAJhW6uWqWg+N9s+Dw63EvVq+syhlo86fKe2yx8Uik2OszthB08nI4ignNPMdcrrZ4xomfsLBQpptpgLAVNu83IQ3ju8pabmGjg0/c6IizmldvS2qIZ/HES8nWfQeqj1LUEFkpiMDiwNMLBILz0B7TZApifyYIAfjkLNPM+ei9x6oPByEGnlpOyXSNMFb51jFCbwtWWKlEmDG+58WgI+sDRmIUqAHmXkvE8S5o/4GAEEJ2NeZ7y4xB
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C2C318B8364FB34CBE68D86FDE7FA9C2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4974
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(39860400002)(346002)(136003)(376002)(396003)(1110001)(339900001)(199004)(189003)(47776003)(54906003)(9686003)(186003)(26005)(66066001)(58126008)(316002)(33716001)(3846002)(26826003)(6116002)(86362001)(36906005)(2906002)(486006)(23726003)(25786009)(6246003)(102836004)(4326008)(76176011)(46406003)(6862004)(6506007)(386003)(107886003)(126002)(478600001)(105606002)(14454004)(446003)(97756001)(336012)(6486002)(11346002)(6512007)(476003)(50466002)(229853002)(8676002)(81166006)(76130400001)(81156014)(8936002)(8746002)(14444005)(33656002)(70206006)(70586007)(22756006)(5660300002)(99286004)(1076003)(7736002)(305945005)(6636002)(356004);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR08MB2933;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 26127c99-a39f-4146-88bb-08d75e9b8028
NoDisclaimer: True
X-Forefront-PRVS: 020877E0CB
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Uionmm8hEXWFJaIdv7z7+no+hH86t+IE4VidWrA2sOFanJTWX9DhdW2OGWOHd2aLpSXQctLVCHeLYfPIPyUICpj+Gwbw+4G7srOu24ykl+YayTSkYwSolA9t1qJsdXOiS+/HB6oKAp7t3Ycl+dEngcYKqPFmPuFTYCr3DRIKWYkkYPP9HRP0CBvyRCzUrXzC3bagOvBgNkS1Tc7koVB/ul2kHLsBUW+5O2kQaWhboTNMsDrDuFByt5n2xQirQQVZCwHXNVbqC0KD/59MuIiLpLg4rgWoh7bDGVuKpq4/LYdw2EWd9rG8tIgwCPAFJ1JXsFISnprabyKqG+t/H4T8zsiOW4hnFJWrmqGTfnY6oJuZ+hmpKOIr63NbNfRHR0hj8UkBkLa8X6jUXsBrqVkUWthBGNecR1ksDz5n8j+t/KBfTLcVEbHAqtAxCXi89HSG
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 07:17:13.4748
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c1926b1f-cc71-4489-9310-08d75e9b84b7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2933
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 21, 2019 at 04:47:24PM +0000, Mihail Atanassov wrote:
> It's potentially useful information when diagnosing error/warn IRQs, so
> dump it to dmesg with a drm_info_printer. Hide this extra debug dumping
> behind another komeda_dev->err_verbosity bit.
>=20
> Note that there's not much sense in dumping it for INFO events,
> since the VSYNC event will swamp the log.
>=20
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.h   | 5 ++++-
>  drivers/gpu/drm/arm/display/komeda/komeda_event.c | 8 +++++++-
>  2 files changed, 11 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gp=
u/drm/arm/display/komeda/komeda_dev.h
> index 831c375180f8..4809000c1efb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -205,11 +205,14 @@ struct komeda_dev {
>  	/**
>  	 * @err_verbosity: bitmask for how much extra info to print on error
>  	 *
> -	 * See KOMEDA_DEV_* macros for details.
> +	 * See KOMEDA_DEV_* macros for details. Low byte contains the debug
> +	 * level categories, the high byte contains extra debug options.
>  	 */
>  	u16 err_verbosity;
>  	/* Print a single line per error per frame with error events. */
>  #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0)
> +	/* Dump DRM state on an error or warning event. */
> +#define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8)
>  };
> =20
>  static inline bool
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_event.c
> index 575ed4df74ed..5da61e7d75d5 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -4,6 +4,7 @@
>   * Author: James.Qian.Wang <james.qian.wang@arm.com>
>   *
>   */
> +#include <drm/drm_atomic.h>
>  #include <drm/drm_print.h>
> =20
>  #include "komeda_dev.h"
> @@ -113,6 +114,7 @@ void komeda_print_events(struct komeda_events *evts, =
struct drm_device *dev)
>  	static bool en_print =3D true;
>  	struct komeda_dev *mdev =3D dev->dev_private;
>  	u16 const err_verbosity =3D mdev->err_verbosity;
> +	u64 evts_mask =3D evts->global | evts->pipes[0] | evts->pipes[1];
> =20
>  	/* reduce the same msg print, only print the first evt for one frame */
>  	if (evts->global || is_new_frame(evts))
> @@ -123,9 +125,10 @@ void komeda_print_events(struct komeda_events *evts,=
 struct drm_device *dev)
>  	if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS)
>  		print_evts |=3D KOMEDA_ERR_EVENTS;
> =20
> -	if ((evts->global | evts->pipes[0] | evts->pipes[1]) & print_evts) {
> +	if (evts_mask & print_evts) {
>  		char msg[256];
>  		struct komeda_str str;
> +		struct drm_printer p =3D drm_info_printer(dev->dev);
> =20
>  		str.str =3D msg;
>  		str.sz  =3D sizeof(msg);
> @@ -139,6 +142,9 @@ void komeda_print_events(struct komeda_events *evts, =
struct drm_device *dev)
>  		evt_str(&str, evts->pipes[1]);
> =20
>  		DRM_ERROR("err detect: %s\n", msg);
> +		if ((err_verbosity & KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT)
> +		    && (evts_mask & (KOMEDA_ERR_EVENTS | KOMEDA_WARN_EVENTS)))
> +			drm_state_dump(dev, &p);
> =20
>  		en_print =3D false;
>  	}