Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Fail (protection.outlook.com: domain of arm.com does not
 designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Mihail Atanassov <Mihail.Atanassov@arm.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
        nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: Re: [2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
Thread-Topic: [2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
Thread-Index: AQHVkIQ++XeFcORrh0SX7O3y9pqBSA==
Date:   Fri, 1 Nov 2019 07:16:12 +0000
Message-ID: <20191101071605.GA30091@jamwan02-TSP300>
References: <20191021164654.9642-3-mihail.atanassov@arm.com>
In-Reply-To: <20191021164654.9642-3-mihail.atanassov@arm.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 076ffceb-beed-4ac6-d6e9-08d75e9b6550
X-MS-TrafficTypeDiagnostic: VE1PR08MB4974:|VE1PR08MB4974:|AM0PR08MB3699:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM0PR08MB36998E49833BDFB44BB89F53B3620@AM0PR08MB3699.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:1332;OLM:1332;
x-forefront-prvs: 020877E0CB
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(199004)(189003)(25786009)(8936002)(6486002)(6246003)(81166006)(229853002)(14444005)(7736002)(71190400001)(476003)(478600001)(5660300002)(486006)(256004)(8676002)(2906002)(3846002)(71200400001)(305945005)(81156014)(6116002)(64756008)(55236004)(66446008)(102836004)(66066001)(66556008)(86362001)(6506007)(4326008)(186003)(6512007)(66476007)(6436002)(316002)(386003)(6862004)(76176011)(99286004)(26005)(54906003)(14454004)(52116002)(33716001)(9686003)(446003)(11346002)(1076003)(58126008)(6636002)(33656002)(66946007);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4974;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: bSB5D2qXRDHJj4Kyt4Sni2GxGhGklJv5BkeS8455aPOg9WPOKg+Nq3QBDeg73XhUSbgRK+M4IxZNFOMDV4yYvAPEJ1t2b8yuKFqDZJE/CaFkfmTnZzLGJfMiEq9G38QL39nq8HOu8ec5vLkIWh5C2dcRJ80Ywc/7GVn1k+utwZx8TBgR/grzaoBBmg+KK7NZXbCEgeID9wC+h9EotBIV5MZX/f/b+Yuieg+iVjNruTVq1IWo/n61Jwjt1AAvHOEYDh4TNPvoygMeb7s/tv/RqlPRbtIFM9GL167cGawWyvmHtFSN8EgA7qsA8iEo76AlNFkgvFFLbSKKB0zbDKfmLiYNUAWyYbw6PajZbBmmJkkWIrNfDJAnkDqJ39Ny6fsetElIOD/sFTE91O26aaaPmqsoCIo7S0daHhQjmS0SjK+h7rOK2/n9kDOj1VvV1tEu
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6AF7F94864C66940BDE85813FB86B2FE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4974
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(376002)(396003)(136003)(346002)(39860400002)(1110001)(339900001)(189003)(199004)(446003)(476003)(6116002)(70586007)(3846002)(486006)(356004)(4326008)(23726003)(6512007)(6636002)(58126008)(25786009)(14454004)(126002)(11346002)(46406003)(8746002)(336012)(33656002)(9686003)(70206006)(99286004)(8936002)(76130400001)(478600001)(8676002)(6486002)(97756001)(33716001)(186003)(1076003)(102836004)(76176011)(86362001)(47776003)(6246003)(14444005)(386003)(229853002)(54906003)(5660300002)(6506007)(2906002)(107886003)(6862004)(26826003)(7736002)(305945005)(316002)(22756006)(81156014)(81166006)(105606002)(50466002)(66066001)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB3699;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 7099d37a-0e75-4296-6899-08d75e9b6079
NoDisclaimer: True
X-Forefront-PRVS: 020877E0CB
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6tdnI4J5mUbt5r59nexKa+TZ+26YxnWambx7aEiS9Ukx32ppuR3P5pegxmoIa5YBo+DhnnoLIxzPc0VhtD9Tav7XblgNHjmBwFuSfb4SmrF65lTP7p2HlaOWHl8gC/0CP2xe2QndtC9cZUDFftfDUGI5/ArnmdD/gxfzupCoCZde43fPiJyEmW2nOy0bIBCGVf3Sam/uO1uowoxTyi3zoKP4XJ2s4NwPHSGtX47HCyM4pgSsRYVYzibc7fx1tfzmFYgj7DBacHg3s+swEh36ZdrUwMu1s1WRd2fpDOeMzhwCuueRhYQYd+pGaKRP8D8gkav28LTKqENl3WTl8RQKv8frOGJdNkfW3tFnqu3nYh6m4m3ZaTo8GJPvSqeMyipnD3zRo+ExxSShk/Gj/c7DYkSuL7BuxmbJU08gGxOOHTDpoUwr0IgO43cLImdQWPay
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 07:16:20.8422
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 076ffceb-beed-4ac6-d6e9-08d75e9b6550
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3699
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 21, 2019 at 04:47:19PM +0000, Mihail Atanassov wrote:
> Now that there's a debugfs node to control the same, remove the
> config option.
>=20
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/Kconfig             | 6 ------
>  drivers/gpu/drm/arm/display/komeda/Makefile     | 5 ++---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6 ------
>  3 files changed, 2 insertions(+), 15 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/Kconfig b/drivers/gpu/drm/arm/di=
splay/Kconfig
> index e87ff8623076..cec0639e3aa1 100644
> --- a/drivers/gpu/drm/arm/display/Kconfig
> +++ b/drivers/gpu/drm/arm/display/Kconfig
> @@ -12,9 +12,3 @@ config DRM_KOMEDA
>  	  Processor driver. It supports the D71 variants of the hardware.
> =20
>  	  If compiled as a module it will be called komeda.
> -
> -config DRM_KOMEDA_ERROR_PRINT
> -	bool "Enable komeda error print"
> -	depends on DRM_KOMEDA
> -	help
> -	  Choose this option to enable error printing.
> diff --git a/drivers/gpu/drm/arm/display/komeda/Makefile b/drivers/gpu/dr=
m/arm/display/komeda/Makefile
> index f095a1c68ac7..1931a7fa1a14 100644
> --- a/drivers/gpu/drm/arm/display/komeda/Makefile
> +++ b/drivers/gpu/drm/arm/display/komeda/Makefile
> @@ -16,12 +16,11 @@ komeda-y :=3D \
>  	komeda_crtc.o \
>  	komeda_plane.o \
>  	komeda_wb_connector.o \
> -	komeda_private_obj.o
> +	komeda_private_obj.o \
> +	komeda_event.o
> =20
>  komeda-y +=3D \
>  	d71/d71_dev.o \
>  	d71/d71_component.o
> =20
> -komeda-$(CONFIG_DRM_KOMEDA_ERROR_PRINT) +=3D komeda_event.o
> -
>  obj-$(CONFIG_DRM_KOMEDA) +=3D komeda.o
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gp=
u/drm/arm/display/komeda/komeda_dev.h
> index b5bd3d5898ee..831c375180f8 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -226,13 +226,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev);
> =20
>  struct komeda_dev *dev_to_mdev(struct device *dev);
> =20
> -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT
>  void komeda_print_events(struct komeda_events *evts, struct drm_device *=
dev);
> -#else
> -static inline void komeda_print_events(struct komeda_events *evts,
> -				       struct drm_device *dev)
> -{}
> -#endif
>

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>
>  int komeda_dev_resume(struct komeda_dev *mdev);
>  int komeda_dev_suspend(struct komeda_dev *mdev);