Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp233679ybx; Fri, 1 Nov 2019 02:37:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxuDp2HfFIIJk/LJ5PKoqdnMQa2LjMi632P/l/WdwNsXgLiBp15UfBawRzIniiTBEaC69yn X-Received: by 2002:aa7:cfcf:: with SMTP id r15mr11672668edy.286.1572601044321; Fri, 01 Nov 2019 02:37:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572601044; cv=none; d=google.com; s=arc-20160816; b=06M5AoSXZcKwo9E/hvv/zTitt2RnYvO2YnhPZLehPuOiOKZlcotiJfhSYN0/1LZ1Xe 9er3qmQ8ZgZj/jY1fPWzdwefhnti+psC9yxvdXF6+1bc7+UkjlrfAWQ8Mi2SviumBAdR 7J8JElfg6sA3wv6tJzVvk4muMR+hW5d5pVDbYhPFleIlCLKcMJTYlblZSP8VPSQZ0cdq btX3ishSRlpCo/9+44zsV4Z55zDG+z184Nfa9dcausM4ku0GhstmoKWx/BG5/rgmwGWE JrLoBTwwV6zAdPhMHVj8y3EXxgstTbWeagDK00ZjPVINQNvSSxVMmbdf9AiJocYVNRS0 onSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=zoO9E6uh381+Rj2k52hRgvhP1ouBNVlNL7jBR1lEffNUH8RDN2vfSkwjDVKWyoR2+c rWE/ath0L3+F2B9+4s78DlROMh0Kpk5rtFGCPzvG1GKNZOypYmzEwhR0bby7j5KaAgZW 8N7w99GIKowh7HDwbdztQGeyg3+2kzd7wGBy/yexOiefRCV6rYPdvIxaqmN5wGdJUGs0 nFBFuNYjah/cfXESeyeW3LlfVh30M9hFLYN5E8+67SuadKRd7baenypDUmxHpC2UBbmx b7OlZZNfIlvLw8HhbYv3YnxXRFJcq2nmMRDfwxpZCibnxSMZyP2rFvRAQN9tGg7pQFhF gMsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SsOvMknt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fy3si5021329ejb.267.2019.11.01.02.37.01; Fri, 01 Nov 2019 02:37:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SsOvMknt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbfKAJHz (ORCPT + 99 others); Fri, 1 Nov 2019 05:07:55 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42306 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727026AbfKAJHz (ORCPT ); Fri, 1 Nov 2019 05:07:55 -0400 Received: by mail-wr1-f67.google.com with SMTP id a15so8975295wrf.9 for ; Fri, 01 Nov 2019 02:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=SsOvMknt1CgP4cY/63FFDv1ZR8D0n+krXXaB5s5xMmzPjmA9CkbyU0N+Ejr+ciaV13 gR97mDAeA039WaHynZ8ezlNuHhZQpK7DX9WAu7zzrQ6a0270jypZhco6I/26gnBb2jh2 Y5qUbR05PW9qioLG7ivWKF0bD/CUzuo0sU1VYiONAu+QAXowSbW8Fxf6KH06C6W/r2jK bp6z+v64ZuLc8XEj9DutDiV/dxcUXN++oy0ASMO2W98M1+gpyHAx46Ax3HGa1hz9IQlj sP1CDeTapR1u4KlRtlTZFoUr2PjV8hSeTspziMOPtFRzPizoOin36lQ5OFFG/NPh3lFB 5+WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zayuLgrU2SwBpXkDAfC9yIWopPaj/yTsmqEo3+k5o+g=; b=sSzw71KuirrOBmQvUAs+uePi0B/HarRTDyvXS6zJv1Qf+4qBhdW3E2H2a6X3UlaEsD u0JWx0N99FAf37B/9BH3djrFi7jXOEtgiDhzR6IAVPa+md3feLEJsKMJNwDWqSzgV0Uw 1lwjczCx84bRy9a5VJ2sbOrcUJN/fgZd8piNSx9r7jw29wi4SoQlzDgZkzQBhEMQmTyu tq3nMvqdkn6QsTVbdD2auxp1elxjMSuUDRWW2tIrSCEDtMHB0vU84pCsEoChh4A6ITiB Aqjjp5q2qQ/I9KH+9Dmkc+16+JdI4f4pJTarFd/VQ/k7gH5cIqNtjNgULZD7lkpMjgzT aRmg== X-Gm-Message-State: APjAAAWWqF7eeq2JB7FOro1h+k4QEg5uqT0FmMvu2HPzKfliN3Mz2/cU fFYVvuA3Lvzq3XMK8Cbnl6qREw== X-Received: by 2002:a05:6000:18d:: with SMTP id p13mr9509311wrx.396.1572599273351; Fri, 01 Nov 2019 02:07:53 -0700 (PDT) Received: from dell ([2.31.163.64]) by smtp.gmail.com with ESMTPSA id n3sm6921838wrr.50.2019.11.01.02.07.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 02:07:52 -0700 (PDT) Date: Fri, 1 Nov 2019 09:07:51 +0000 From: Lee Jones To: Lubomir Rintel Cc: Arnd Bergmann , Daniel Thompson , Mark Brown , Linus Walleij , Barry Song , stephan@gerhold.net, "linux-kernel@vger.kernel.org" , Linux ARM , Daniel Drake , James Cameron Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191101090751.GH5700@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021115339.GF4365@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Lubomir Rintel wrote: > On Mon, 2019-10-21 at 12:53 +0100, Lee Jones wrote: > > On Mon, 21 Oct 2019, Lubomir Rintel wrote: > > > > > On Mon, 2019-10-21 at 13:29 +0200, Arnd Bergmann wrote: > > > > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > > > > MFD currently has one over-complicated user. CS5535 uses a mixture of > > > > > cell cloning, reference counting and subsystem-level call-backs to > > > > > achieve its goal of requesting an IO memory region only once across 3 > > > > > consumers. The same can be achieved by handling the region centrally > > > > > during the parent device's .probe() sequence. Releasing can be handed > > > > > in a similar way during .remove(). > > > > > > > > > > While we're here, take the opportunity to provide some clean-ups and > > > > > error checking to issues noticed along the way. > > > > > > > > > > This also paves the way for clean cell disabling via Device Tree being > > > > > discussed at [0] > > > > > > > > > > [0] https://lkml.org/lkml/2019/10/18/612. > > > > > > > > As the CS5535 is primarily used on the OLPC XO1, it would be > > > > good to have someone test the series on such a machine. > > > > > > > > I've added a few people to Cc that may be able to help test it, or > > > > know someone who can. > > > > > > > > For the actual patches, see > > > > https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t > > > > > > Thanks for the pointer. I'd by happy to test this. > > > > > > Which tree do the patches apply to? > > > Or, better, is there a tree with the patches applied that I could use? > > > > Ideal. Thank you. > > > > http://git.linaro.org/people/lee.jones/linux.git/log/?h=topic/mfd-remove-clone-cs5535-mfd > > Thanks. My boot attempt ends up in a panic [1]: New patches have been drafted, reviewed and pushed to the same branch. Would you be kind enough to boot test them for me please Lubo? TIA. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog