Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191021194820.293556-1-taoren@fb.com>
In-Reply-To: <20191021194820.293556-1-taoren@fb.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Fri, 1 Nov 2019 10:08:35 +0000
Message-ID: <CACPK8XcNxs5T=ZC_mRnvkOF_kqS1AvP=9PvMB6w9Fgn_XbtZQw@mail.gmail.com>
Subject: Re: [PATCH 0/4] ARM: dts: aspeed: add dtsi for Facebook AST2500
 Network BMCs
To:     Tao Ren <taoren@fb.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Andrew Jeffery <andrew@aj.id.au>,
        devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tao,

On Mon, 21 Oct 2019 at 19:49, Tao Ren <taoren@fb.com> wrote:
>
> The patch series adds "facebook-netbmc-ast2500-common.dtsi" which defines
> devices that are common cross all Facebook AST2500 Network BMC platforms.
> The major purpose is to minimize duplicated device entries among Facebook
> Network BMC dts files.
>
> Patch #1 (of 4) adds "facebook-netbmc-ast2500-common.dtsi" file, and the
> remaining 3 patches update CMM, Minipack and Yamp device tree to consume
> the new dtsi file.

The patches look okay to me. I modified the file name to match the
convention used by other device trees in the arm directory, where it
includes the SOC name first.

I also reworded the commit messages a little.

They have been merged into the aspeed tree for submission to 5.5.

Thanks!

Joel

>
> Tao Ren (4):
>   ARM: dts: aspeed: add dtsi for Facebook AST2500 Network BMCs
>   ARM: dts: aspeed: cmm: include dtsi for common network BMC devices
>   ARM: dts: aspeed: minipack: include dtsi for common network BMC
>     devices
>   ARM: dts: aspeed: yamp: include dtsi for common network BMC devices
>
>  arch/arm/boot/dts/aspeed-bmc-facebook-cmm.dts | 66 ++++---------
>  .../boot/dts/aspeed-bmc-facebook-minipack.dts | 59 ++++--------
>  .../arm/boot/dts/aspeed-bmc-facebook-yamp.dts | 62 +-----------
>  .../dts/facebook-netbmc-ast2500-common.dtsi   | 96 +++++++++++++++++++
>  4 files changed, 136 insertions(+), 147 deletions(-)
>  create mode 100644 arch/arm/boot/dts/facebook-netbmc-ast2500-common.dtsi
>
> --
> 2.17.1
>