Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==XWc4LnSndNetJSQtLBzrXgdspr5mXY==";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Subject: Re: [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2
From:   Karl Palsson <karlp@tweak.net.au>
To:     "Chen-Yu Tsai" <wens@csie.org>
Cc:     "Maxime Ripard" <mripard@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <CAGb2v67PLemQvj+SOF2h_cfc4HcnAyvs866Bas7GRUF9Y1Lo1A@mail.gmail.com>
References: <CAGb2v67PLemQvj+SOF2h_cfc4HcnAyvs866Bas7GRUF9Y1Lo1A@mail.gmail.com>
User-Agent: Mailpile
Message-Id: <FbCSL9o7LLRZJoCAokdTzGW6y5cRWs88rHTPoqG2238c@mailpile>
Date:   Fri, 01 Nov 2019 10:00:33 -0000
OpenPGP: id=9F020B9C40DA5E6F2CAF63B319A8B50FD4D5CAF6; preference=signencrypt
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==XWc4LnSndNetJSQtLBzrXgdspr5mXY==
Content-Type: multipart/mixed; boundary="==YNFVxqfDdewuHhTDfY9tCavnXqx3Gk=="
Subject: Re: [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2
From: Karl Palsson <karlp@tweak.net.au>
To: "Chen-Yu Tsai" <wens@csie.org>
Cc: "Maxime Ripard" <mripard@kernel.org>,
 <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <CAGb2v67PLemQvj+SOF2h_cfc4HcnAyvs866Bas7GRUF9Y1Lo1A@mail.gmail.com>
References: <CAGb2v67PLemQvj+SOF2h_cfc4HcnAyvs866Bas7GRUF9Y1Lo1A@mail.gmail.com>
User-Agent: Mailpile
Date: Fri, 01 Nov 2019 10:00:33 -0000
OpenPGP: id=9F020B9C40DA5E6F2CAF63B319A8B50FD4D5CAF6; preference=signencrypt

--==YNFVxqfDdewuHhTDfY9tCavnXqx3Gk==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit


Chen-Yu Tsai <wens@csie.org> wrote:

(will fix all other comments)

> > +               // on opi-win, shutdown is pl4, is BT-RST-N is moduel pin 34
> > +               // YES; PG13 is correct.
> 
> I'm guessing all these comments are from your development
> cycle? Please remove them.

Yes, gross mistake squishing it all and rebasing, my apologies.

> 
> > +               shutdown-gpios = <&pio 6 13 GPIO_ACTIVE_HIGH>; /* PG13 */
> > +       };
> > +};
> 
> The board also has SPI flash. Can you add that as well?

It doesn't come mounted standard, it's just a blank footprint, so
I felt it should be left out?

Sincerely,
Karl Palsson
--==YNFVxqfDdewuHhTDfY9tCavnXqx3Gk==--

--==XWc4LnSndNetJSQtLBzrXgdspr5mXY==
Content-Type: application/pgp-signature; name="OpenPGP-digital-signature.html"
Content-Description: OpenPGP Digital Signature
Content-Disposition: attachment; filename="OpenPGP-digital-signature.html"

<html><body><h1>Digital Signature</h1><p>

This is a digital signature, which can be used to verify
the authenticity of this message. You can safely discard
or ignore this file if your e-mail software does not
support digital signatures.

</p><pre>
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEnwILnEDaXm8sr2OzGai1D9TVyvYFAl28Ai8ACgkQGai1D9TV
yvZqZRAAqzoj/fQIFzqbUDDwOJzUdS2I5t3imDOuMjRM7d27AXwN+Dj6lrtMMzR9
0ZFQ1z3fGELU1CwCkRyrnmLeSt4ttIxK4IgpAZ2lMPe9+gH58SzXDDvKxVN+xRSn
nczcYHYlB8/7GX3f/PA1RJiGgpSdI8q/cCVKQVRIU4SkCLU6s+05Dip6DtWJrijO
W/f/Bvwx/gqMXwYhcYnr8cVqphYr8a+URtpneHpM52IgygPDC0JujDD3Pm3K7m9E
7WM9LYxHyk+VzI2brQBqHfaWQUr7X43LB/HkEmALO/QDFBeL9ap05TLrXaGHptxK
f5rVw94zucQAsLGLVNGmEDBmOsAQUvQ0NcAg73ZUO66uBhV1l4e4tlcUsYgtVoQw
GQmqno8Rzbslll2nnMyTLNXdj9ICywSWeykpD9dFcrkRx/PjFshk8GFW2uYIPRGQ
U0RH+mqatGgqe+icELR2E6OHtIF0li/Pk3/Cq3nG9Zln+KO60MFx3cCR3F5e0Yon
GUN678VD1zRwER+2EVIr2bVdZQIkjpjXsmTbk8upTr75nlm7QQuBfWD4ElZZiluA
LuP3DEb6SuxWmPkb60R6BaMMYXE880nQx8R7cabtpQ4fv35Vy7KmnJaPLg3ti4qK
qVDO8XL300QN6b5R8b7JvXblcymfS/LWL9usCFPKnQWusKdBIho=
=n1cL
-----END PGP SIGNATURE-----

</pre><hr><i><a href='https://www.mailpile.is/'>Generated by Mailpile</a>.</i></body></html>
--==XWc4LnSndNetJSQtLBzrXgdspr5mXY==--