Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp342675ybx; Fri, 1 Nov 2019 04:29:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqx34/xn3MHf3NyfRDcLOk6Xzo/EH1Q5s8utHCmQz92WQAQIBXwNl9hH5HdTdV7Iqh3XjqNF X-Received: by 2002:a50:8a88:: with SMTP id j8mr12302635edj.35.1572607763002; Fri, 01 Nov 2019 04:29:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572607762; cv=none; d=google.com; s=arc-20160816; b=o/las8GHzh8JivwEGiIvoHvGUEVieCSWYNn1FuEs9GHaWmQg6d+cSMQaqoWLO1TYQF LFnu4IBv9NtRbxb4AT6jVafFddKAsU4HBPvw5Ad6Kt2LjcMQn4O2dkdTMy5pV5aghT8v Lr345ISFM75IbCbueQWwTDh0F6EjA3XYQQgCzcSaWv/rTIUjLzF3a+lNvpAVtfGAqP4w Q/qLbPVginjpg7mjO0fa2NFeAC+hYqO+jLVW8RwXpgXmEK6HMJC48+Up6k1ry6ubdzV+ LTPaHa+cENRgaYJCFF0/vDKBl7/mMwgAvFOZLTedP0NGYqgV2W1keYXCrPr33PLxJmlk ne3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LtFp0F0HrsUYyNBlzjAg/7imere0s3lC3VUOl+c6wWo=; b=QFx2U+ffMMlKauSA0f6rvoBsNhn2g3fH+IfxzLUpky8ba9mPfMyQx92I7JXOyfEqFr hbxmnbP1GxTrX9fN1SAPe74tkB+ex90UVg7HCecobXomh+OpOTiZ/uMs9da3ufj1jJT3 rb/cb7KggtsuZQ9SD2hizzrduxnEP30ZoamkVfFsfZLWdRR1ysXxvEYLfSEyZASV8Xwk 5c/0I41ghZybHEe3dMQUtmje1KP6JxZXbQIQgi9zLdGFPuzWNdbiuuDkKpoxjNAcHDuN ctY8qws5s3CQr9iLr14MSFQ/KxomW1NJqC4/VUGYCPTZeL64ER0jRdJTRHiBHqTE76KW YdpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=VwZmEH6B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7si121197edx.33.2019.11.01.04.29.00; Fri, 01 Nov 2019 04:29:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=VwZmEH6B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730062AbfKAK7C (ORCPT + 99 others); Fri, 1 Nov 2019 06:59:02 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55761 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729789AbfKAK7C (ORCPT ); Fri, 1 Nov 2019 06:59:02 -0400 Received: by mail-wm1-f68.google.com with SMTP id g24so8925556wmh.5 for ; Fri, 01 Nov 2019 03:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LtFp0F0HrsUYyNBlzjAg/7imere0s3lC3VUOl+c6wWo=; b=VwZmEH6BFuBX/lEfDq2gTf28+aE6bseQhEvwyXhZetLJ4XDt/sc7VtvJm2m6W3fQmY no1u3HUstUiMEtr5X1fKOoazXhc1ODwZ45XAWZVFgdDjaDzy9pJD1gt4iGfDW/vbiDzh pY0rw1SBF/npTDRTKj0yNA99/wWXgRn1wAMXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LtFp0F0HrsUYyNBlzjAg/7imere0s3lC3VUOl+c6wWo=; b=hMXsNkRFjTmNVIhEU9+tL0xK9ODAPxCF4YrsnmA9WjqKhADbpO4BFeVBZRUyBFfGSG QTSoR+ODs/apIn1jQ06dv+jlavmMZvuDQpJkrU5R9D1OBRsDRzQAZqqPO5y8LSX3WgD2 4ilHvVUGUGiKrC/HEw0O+0l5xUGzHi5Fsu8O7csv6Aovue3R+euExC8cE2FGvPxqePlK ghU0ULgYWqrYWAIxE4nQvIKo0WUDf1kSCS6i571AsxFSDPNubebTEFhICPgdzIKL1FXP HJLlaAAIAjINWvOXEa5wNv6clVC1fc285RIwJaFTA0AfL6G+CjjHAxoUviCCqYsVaKNb QI7Q== X-Gm-Message-State: APjAAAWgZbtWORLt2gpR28NLRYNmEOQmT7pd2UzUroaT4OYag5BvSTvd BEvoIrqjaWtcmXXuYOphVXnq8w== X-Received: by 2002:a1c:7704:: with SMTP id t4mr8981357wmi.4.1572605940145; Fri, 01 Nov 2019 03:59:00 -0700 (PDT) Received: from localhost ([2620:10d:c092:180::1:f970]) by smtp.gmail.com with ESMTPSA id n13sm1507441wmi.25.2019.11.01.03.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 03:58:59 -0700 (PDT) Date: Fri, 1 Nov 2019 10:58:58 +0000 From: Chris Down To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] kernel: sysctl: make drop_caches write-only Message-ID: <20191101105858.GA690103@chrisdown.name> References: <20191031221602.9375-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191031221602.9375-1-hannes@cmpxchg.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes Weiner writes: >Currently, the drop_caches proc file and sysctl read back the last >value written, suggesting this is somehow a stateful setting instead >of a one-time command. Make it write-only, like e.g. compact_memory. > >Signed-off-by: Johannes Weiner Since we already have the kmsg notifier when it's used, this seems reasonable to me. Acked-by: Chris Down