Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932636AbWAJXb0 (ORCPT ); Tue, 10 Jan 2006 18:31:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932648AbWAJXb0 (ORCPT ); Tue, 10 Jan 2006 18:31:26 -0500 Received: from smtp.osdl.org ([65.172.181.4]:43229 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932636AbWAJXbZ (ORCPT ); Tue, 10 Jan 2006 18:31:25 -0500 Date: Tue, 10 Jan 2006 15:32:57 -0800 From: Andrew Morton To: "Bryan O'Sullivan" Cc: hch@infradead.org, rdreier@cisco.com, sam@ravnborg.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1 of 3] Introduce __raw_memcpy_toio32 Message-Id: <20060110153257.1aac5370.akpm@osdl.org> In-Reply-To: <1136932162.6294.31.camel@serpentine.pathscale.com> References: <20060110011844.7a4a1f90.akpm@osdl.org> <1136909276.32183.28.camel@serpentine.pathscale.com> <20060110170722.GA3187@infradead.org> <1136915386.6294.8.camel@serpentine.pathscale.com> <20060110175131.GA5235@infradead.org> <1136915714.6294.10.camel@serpentine.pathscale.com> <20060110140557.41e85f7d.akpm@osdl.org> <1136932162.6294.31.camel@serpentine.pathscale.com> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 23 "Bryan O'Sullivan" wrote: > > On Tue, 2006-01-10 at 14:05 -0800, Andrew Morton wrote: > > > It's kinda fun playing Brian along like this ;) > > A regular barrel of monkeys, indeed... > > > One option is to just stick the thing in an existing lib/ or kernel/ file > > and mark it __attribute__((weak)). That way architectures can override it > > for free with no ifdefs, no Makefile trickery, no Kconfig trickery, etc. > > I'm easy. Would you prefer to take that, or the Kconfig-trickery-based > patch series I already posted earlier? > Unless someone can think of a problem with attribute(weak), I think you'll find that it's the simplest-by-far solution. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/