Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp553918ybx; Fri, 1 Nov 2019 07:39:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOfzEyVM36rBQrIuGjBhHIik2zMGG8YigkhtS11lXvMf0DT3msYx8TrgQBlPFvQt02ws2A X-Received: by 2002:a17:906:6a06:: with SMTP id o6mr10010828ejr.89.1572619173403; Fri, 01 Nov 2019 07:39:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572619173; cv=none; d=google.com; s=arc-20160816; b=Vo1u6/2zGDH5LlMRW9Yfaz8Bt6j20SOJAW9JrO4UXGr096LSp5D7IflyIgi8fBsa0l /UpVW+cMb6EyZJrAfmCY7aPfpzMjTnrW4QTbAGNfS2P5yi7atAk/CNQTALZszz2Mwn8h wAi/C4PpUuyg9K3U18T43e9VbwyTWUvX+NMOd11Z3oK6oKTaz2gPklTeg/eHhxhEeds6 3nye+CeflbWmO8+SsW0edyJdoCQQTNM8ntKsboYF5nHVmUtqz8ny+Dub7BZN/jIyNPYg 7TRXYaop81bGHaAnDmpbx+03LfGebBPLDf3yEVkbWKhSiCZaEAEkwBO0wEJhQV5Y6/Ue Iqxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=iDATA8UWRvuERkVCUo3sHEhaiMy110+5RvXbe9baKYQ=; b=xhPQ1USpzAOl1yBEsm/zAaFkKQ9i5QXZ9OX7QR2gKwvR9wciXkLH8XeogdfCiMcYZ3 JTm5txBmPrR2PymSIOAxouzfmiUb8vu5Mwm4zm61E7yINQEboxIpwV0m0y4h6CjsLOQO 9Lpte3YSGijaZkJgiZ9zrAHkZwBCH2sxVn/B/XT6CvBgKXNW9fX5LEMMrhCAE7FKFVEY IOteQOE5F3g+UBKkT01NWaXLrIzUNSiYsfZAoN4RdgFp0HL2iUh/oOfvDpbSkj0YV+lv wnaaNLbKCoGBqpgDq84D7/+sjbsjffKSms3AvvMooFQgkkKhCkPsuAofW1VLg3ykDchm V4oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=a0G3CKeV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l8si445595edb.234.2019.11.01.07.39.09; Fri, 01 Nov 2019 07:39:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=a0G3CKeV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727286AbfKAOhv (ORCPT + 99 others); Fri, 1 Nov 2019 10:37:51 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42051 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726658AbfKAOhv (ORCPT ); Fri, 1 Nov 2019 10:37:51 -0400 Received: by mail-wr1-f66.google.com with SMTP id a15so9857738wrf.9; Fri, 01 Nov 2019 07:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iDATA8UWRvuERkVCUo3sHEhaiMy110+5RvXbe9baKYQ=; b=a0G3CKeV4eMZvWvCK5eajXp9N4sKVrGEqIPZIYw5GZOswevSnjtindYVUVrXWrfMRI JMacgwry7FiP4VCmUhiWGkaZ7f5bYkxpt6lmdx9etuDNCo+14TpcACqzVVa4/DNbA2Cc u2HwS6yoKafmZPP1oXL3o/PX4qHIUjL7lD57BUhUCBW1+5XV7+xsRBMAWZxdRR0YRnlr Ozd0YULIoCcc2kgF/ro8ZBKfFyYnMIVVPc1E2T9lHoD9OmA5SEpxixOZNTeZuE40uNmv nSLJTGmRLeaDjfJKZsAtEiEQ3MwLZ5m5vD+RDVHJTHeHw3tQyaVNAma4+kpQ4ijcIdga aCng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iDATA8UWRvuERkVCUo3sHEhaiMy110+5RvXbe9baKYQ=; b=QBumv39ek7fAScvDwQV2PSW1W7X9CEU3RXeKNSVaBDxeO0O/DK29rNPVbtZZsd0Agh 6t0hT4ORdP/HLm5ikCw1E7AAY3lFu1M35QwQzDrp+5/SWv/K/KU5MZwOFPc1/9PaLnGB VGS/NGhnjUS5xbiQUG0eZAvtbr5vgqzkkI/+SydpXXmKjBPmMLlEV6VeEjDzeZYsojDq TScZOHi7JXxQQK9SfpwpNBIkjSU6X17Rf1osi9Glq3KX8fkf7PgwQZ2W/Mo5APcx1A34 DJu0RXhqgLgtJYHVqF1rexy+JBC63sijK4GpQiXOWMugqVHx8ldV4fdMT52xGbfKnLlP GNxQ== X-Gm-Message-State: APjAAAWjAI/rKW9lOWu42XKZFxEQL0Ke9JbI4CJouxrreKlUDnqhXk9I kwLxIryKfI9n/fkIIABwR2o= X-Received: by 2002:a5d:4409:: with SMTP id z9mr6610626wrq.22.1572619069481; Fri, 01 Nov 2019 07:37:49 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id q9sm1824816wru.83.2019.11.01.07.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 07:37:49 -0700 (PDT) From: Chuhong Yuan Cc: Antoine Tenart , Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] crypto: inside-secure - Add missed clk_disable_unprepare Date: Fri, 1 Nov 2019 22:37:15 +0800 Message-Id: <20191101143715.17708-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org safexcel_remove misses disabling priv->reg_clk like what is done when probe fails. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/crypto/inside-secure/safexcel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 4ab1bde8dd9b..24c0f2404ec6 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -1623,6 +1623,7 @@ static int safexcel_remove(struct platform_device *pdev) safexcel_unregister_algorithms(priv); safexcel_hw_reset_rings(priv); + clk_disable_unprepare(priv->reg_clk); clk_disable_unprepare(priv->clk); for (i = 0; i < priv->config.rings; i++) -- 2.23.0