Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp572104ybx; Fri, 1 Nov 2019 07:56:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9grAbfpc9bVaBllaNUaNklUtc3SD8MwComYTTX6rsRJpnEKymDHdY0M1cTp4DGIaY9rxL X-Received: by 2002:a50:c30d:: with SMTP id a13mr9879492edb.177.1572620200568; Fri, 01 Nov 2019 07:56:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572620200; cv=none; d=google.com; s=arc-20160816; b=kqAVxlnqgPzK0SZjRvYSwZDFCzGVdRwQjXJoXmlDwcCrKPIc8AMcHsQq/oj+wV8SJ4 L6yxOwgKVeZHFdeo7PxW6ESTl1CxJaiFya+cHDWuawbc5iJ7fkmGIcElmJ1BlYsGpsJb N9vtX5CR11xeJC6HW3FAoXi3/cZSl7Rj+o5fCrBNfoIo43bE4D+Vis6QhfwFuwbtNv6F 63qiiMLvVI/flXjjS5pLnenLCGfb8x7PRqbWUskThxbro3e642oBfJDHtxPKsZdF3nlS tkTu1+rCxT5vW/PPplIdm+BCH7yL6czjyRXIMxBEU5WBkS8Y43AkteM8sjElJytjgMoh ASsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id:date :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=4MrbBDQoC+y5mHa+x24tjKMzrIZqDb3nq3UowOz4YuY=; b=Ti4Y/7nmY6G0WH8ZHYNAKtG6lRqtoJMekq79BATgepJz/YwqpKSjzEP4OzefDuIISh 7jN9HMVWtAiWyF5vT4dIrC+p+GX7LBklEt+09SYNnUiaLL7ZN3wNBa3iDw+dGfsJWsnr oqj/mGLG2XNnHyT+/ouDQApqTJMabTlO4ClHF0kd6Kq1ejsCGhc3UeFkMG6lj7tiLa1Y ZOYmKOuSUpBChpZtD+3gAbVG/Xv+COJAHmaktt3Szj4x6VZ7UpsrPip7qW6ylnsqkRrs oGxnfATDP+RFu1L+9LzXcK+mRQm4ZxghX7cKKppluKMjG9bWLpln3wkR0K7/PZdpPIu2 qmDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f1rigfPG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si5660044ejp.203.2019.11.01.07.56.17; Fri, 01 Nov 2019 07:56:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f1rigfPG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbfKAOxe (ORCPT + 99 others); Fri, 1 Nov 2019 10:53:34 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:23252 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727592AbfKAOxd (ORCPT ); Fri, 1 Nov 2019 10:53:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572620012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4MrbBDQoC+y5mHa+x24tjKMzrIZqDb3nq3UowOz4YuY=; b=f1rigfPGvTB/H5OhVEpDcYnjXRTVvHpmdODmqZmpitWDVFrlTfMmbN/5TjtGlIR6AjZ2hA skc5QuBqRyut7uUj0laj1LxPrGsM7Se4L/dOcL7zroerH5slpEVz434+jA5/wyEKtF0HuY ns0fYH9VIbeKtnAMX0lwLDUcByGLYF0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-hHyjRC-_MMioG67u4CEa_w-1; Fri, 01 Nov 2019 10:53:28 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9BED01800D67; Fri, 1 Nov 2019 14:53:26 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-40.rdu2.redhat.com [10.10.121.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6466F26DEA; Fri, 1 Nov 2019 14:53:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> <157186186167.3995.7568100174393739543.stgit@warthog.procyon.org.uk> <4892d186-8eb0-a282-e7e6-e79958431a54@rasmusvillemoes.dk> <16620.1572534687@warthog.procyon.org.uk> To: Ilya Dryomov Cc: dhowells@redhat.com, Rasmus Villemoes , Linus Torvalds , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block , linux-security-module@vger.kernel.org, linux-fsdevel , linux-api@vger.kernel.org, LKML Subject: Re: [RFC PATCH 04/10] pipe: Use head and tail pointers for the ring, not cursor and length [ver #2] MIME-Version: 1.0 Content-ID: <23657.1572620001.1@warthog.procyon.org.uk> Date: Fri, 01 Nov 2019 14:53:21 +0000 Message-ID: <23658.1572620001@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: hHyjRC-_MMioG67u4CEa_w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ilya Dryomov wrote: > > * This means there isn't a dead spot in the buffer, but the ring > > * size has to be a power of two and <=3D 2^31. I'll go with that, thanks. David