Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp640794ybx; Fri, 1 Nov 2019 08:56:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxN1jlC603lRR5hKLdkrj3KOfmp5VofQDxZEGw2DSvtEyOmuwsalYMDOm3ewVTiZLFfN4f1 X-Received: by 2002:a50:b6cb:: with SMTP id f11mr13362254ede.299.1572623809825; Fri, 01 Nov 2019 08:56:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572623809; cv=none; d=google.com; s=arc-20160816; b=0oUFtHh4rV+HdRZFXiRTFUdprXAwOZ0OmtGpfdbEXjV5Urj3d0LmCPXAg7PRygXavA QZcfTn2hkD5zZeTuEB2Ycbujun54kAn/IaeWQ26k/IMui/xyFGB/I3W9Vl+yMzsf1rbZ YGpGBw5B7KgEYWlbEh9YLgPmgs7An0zxhrofg+zVPlGWCBVSsl3I/f+l+4M38dfog3Ue Fi0Fl1lAOt9wjCa/tWAReyWS53Au+fhePCtFfoBCzFBVwl1QW4WB9o7FcNriGtihDhRP ZsHTpP7/ur+Jj26YCqTfGii/0HkWFWr+Dh3mcLecEkUutBKSzx5q5MBS6NqpeUK1uxcA HMlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=d/QAmQIaJZqvBZN9gtf42lfTOPBui/1bELKuGyuJdb8=; b=v1vFXQfVGCv+M1s4zWG93plgC8Mq+GxWCiUEMZofEkCiJFqHq1K644aj5V56Lfplwr Gg7v0oOjH4nTiKR22OdVeN9KwRJgxsBc/CswOhB1x5nLt+6xmVKTulcY5Fb51AtHhXPZ 2Vdct7Jjo3vv1zPTNadFXjPlr44VtY5tZ6+RZoMm4/BIBZjDFOK/EnnTVwAI+lKAACKK BP5tJCnlveGBvC+z8XtzV5aeRqlNtbQbR/cbSkCAJ7SY6xI7E0iuCrQGT+OVjOkKlHn1 A2jOCBo5sOOtMVFSjay7N0ZWon1xtxt+0vHfcr+6VhgNpVtAGUntcGYldvdaSzYNzU6D akiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="A1/aTXY8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19si1795089ejr.411.2019.11.01.08.56.14; Fri, 01 Nov 2019 08:56:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="A1/aTXY8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727328AbfKAOiP (ORCPT + 99 others); Fri, 1 Nov 2019 10:38:15 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50348 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbfKAOiO (ORCPT ); Fri, 1 Nov 2019 10:38:14 -0400 Received: by mail-wm1-f66.google.com with SMTP id 11so9564292wmk.0 for ; Fri, 01 Nov 2019 07:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d/QAmQIaJZqvBZN9gtf42lfTOPBui/1bELKuGyuJdb8=; b=A1/aTXY88hwx0sfCCWkO613b31JI7fBe2Fo7wc0qyRX1OqGtc1ZqPTHH3fVptzI2xR kjtzIFwT28c8pyCN1rXIAb7VEv+u4LqEx23SRT2bH3mzJkw5AkHNOs4lt482evX6TdWF Owbgw07QIaJIvXlIn0YuxP0DnJ1ZY33AiQXaHs13ZhtLhRBr6AsyzgXdcRaO31s6BfbC cq/gJdjEVmPEDAHhPV8CvWUhlxccGm2a3OBVYvTtNkvqGihMhGX0GOr/Ignd7Nxemwmz JnE2XSKIlW/ZcBwn1hZtqeovVZlQjWliWYbL8JCHXD5aWz0FsGz9AIOM/1cmNSrVmNYv 19yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d/QAmQIaJZqvBZN9gtf42lfTOPBui/1bELKuGyuJdb8=; b=Y5eZIc+mqH8XH14JH2uNLUSp9xMKw8bVeo1eDkFV8tHmRfs7G/4V+LJSirFQjDp70T DeTdn2wAnEpkWqjqZrkRtls31Gp9XCBu5iZSS9Am+ho2iJZMToh5BXKLY1Pepmu+JgkA g2nOUfs8Rm5NF7/QoJpJrnM9XdVBxu6pZ4Vn5duif9o77ZBoTzgo06iUZqHwGLwn//+i NB2iFF65PqWcz3CmjiXTVNuiN4nTnqTrwT8aW8fIW17Qi77nK1519zM7IZ1PP6/VsyKQ aPBiTuKBqKdROBVgH0Q5J8egtU1MII46qzqHLC72B2p4U6TI1NYme/SsXtq/sLXuUrHA DiJw== X-Gm-Message-State: APjAAAWiDyTswFu8NhQOjdV7nMrD3myrznaElm5+YbwwVCiKK0caPTMj MlpcDL5YtO9puimx0J5ZEtk= X-Received: by 2002:a1c:10a:: with SMTP id 10mr10579982wmb.17.1572619092780; Fri, 01 Nov 2019 07:38:12 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id l15sm6391895wmh.18.2019.11.01.07.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 07:38:12 -0700 (PDT) From: Chuhong Yuan Cc: Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] gpu: ipu-v3: prg: add missed clk_disable_unprepare in remove Date: Fri, 1 Nov 2019 22:38:01 +0800 Message-Id: <20191101143801.17774-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to disable and unprepare clks when remove. Add the calls to clk_disable_unprepare to fix the problem. Signed-off-by: Chuhong Yuan --- drivers/gpu/ipu-v3/ipu-prg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c index 196797c1b4b3..6ae6d634c983 100644 --- a/drivers/gpu/ipu-v3/ipu-prg.c +++ b/drivers/gpu/ipu-v3/ipu-prg.c @@ -430,6 +430,8 @@ static int ipu_prg_remove(struct platform_device *pdev) list_del(&prg->list); mutex_unlock(&ipu_prg_list_mutex); + clk_disable_unprepare(prg->clk_axi); + clk_disable_unprepare(prg->clk_ipg); return 0; } -- 2.23.0