Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp649369ybx; Fri, 1 Nov 2019 09:04:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpI5yk/KWHPo2JrbzimGxjbvv5OCwU1bjrtYDMxl2ROkIxw4o/AiYw4k+ut2UnNSlTMwcm X-Received: by 2002:a17:906:49c9:: with SMTP id w9mr10374470ejv.309.1572624259903; Fri, 01 Nov 2019 09:04:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572624259; cv=none; d=google.com; s=arc-20160816; b=DsSnMc3Tsc+LY+0kZE8kNoJdviZfbw8nf9F23QdewLexAVUd96A/rrUcs6ygPbdmbn TFClyFi6XX+a0G5xe2UBs9cczywnQuYJh2sNR1u36omVcPvRqrfoNvrKeTiXfqUnTDvq a3R0fZ7xn9SeuIkPSJx8+nSKsiOnUPFWh1UGxa5maGxkisK7oqIr3UPxXfYbmZ/RDTbp dKzY+x9F30S2JDyY/2i0MfCVdJmlXUFOBYVNwGMNqtFJoJG0pbea7oLkp9eVVR1AHbT/ 31Dbi65fr7H0NskYpo4qRLvvDwTr77x2qd0L7Z3omIlGX7/WZj3EoHKxBdwUGNn5owvi S02Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id; bh=Gd0Mw5kt5udsYtGBIMhSwFk35a3zaYR4IFEpgpwQzpM=; b=ykd8k5Mzt2Qd+2M6b7IZA/f7TCBqQk+ZLHg+4qGiiJZ2uv0tbBKZQkqkdmt1PzTN6S CC8A3wkgMJhojA9BGW3dWLCjQl9UaqN919bHl/B6I7da1oXS7CDAIAxbY5kqOSuOXRYu 892Lj+eriFhdkzJyLN7AlQFl7eKS7FRZbbv3gxDuzzt4JbMjY3zj7wrjBm1rZlmRafsb K9uV1RGGjBb92MhMMsd8/Z3/iaa/N9akD3zdJIgGo5bkBrGS7u8q7VHfvuvsYTQYG95S iYMqY9sbuf4pREzqD/NxjgwBUPKQmXUotmQ4wdRa2sbzcdlod7hdCZY45fClcasJOKtA xajQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce1si5831830ejb.0.2019.11.01.09.03.54; Fri, 01 Nov 2019 09:04:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728580AbfKAPcS (ORCPT + 99 others); Fri, 1 Nov 2019 11:32:18 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:37496 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727100AbfKAPcR (ORCPT ); Fri, 1 Nov 2019 11:32:17 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 2BC87B0D3691E2CB7247; Fri, 1 Nov 2019 23:32:13 +0800 (CST) Received: from [127.0.0.1] (10.133.219.218) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Fri, 1 Nov 2019 23:32:12 +0800 Message-ID: <5DBC4FFB.5030200@huawei.com> Date: Fri, 1 Nov 2019 23:32:11 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Borislav Petkov CC: , , , , , , Subject: Re: [PATCH] mm/ioremap: Use WARN_ONCE instead of printk() + WARN_ON_ONCE() References: <1572425838-39158-1-git-send-email-zhongjiang@huawei.com> <20191031110304.GE21133@nazgul.tnic> <5DBACB61.90809@huawei.com> <20191031154916.GA24152@nazgul.tnic> <5DBB03B0.5060003@huawei.com> <20191101084524.GA29724@nazgul.tnic> In-Reply-To: <20191101084524.GA29724@nazgul.tnic> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.219.218] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/11/1 16:45, Borislav Petkov wrote: > On Thu, Oct 31, 2019 at 11:54:24PM +0800, zhong jiang wrote: >> Yep, WARN_ONCE alway return true in that case. > Are you sure it does that always? > WARN_ONCE will alway return true if its condition is true.:-)