Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191101035646.25644-1-linux@roeck-us.net>
In-Reply-To: <20191101035646.25644-1-linux@roeck-us.net>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Sat, 2 Nov 2019 01:19:03 +0900
Message-ID: <CAC5umyhiOiAiYWs2Y=L5133CCQNnAgi8oq6AbGzgkznZKz5f-w@mail.gmail.com>
Subject: Re: [PATCH v3] nvme: Add hardware monitoring support
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Keith Busch <kbusch@kernel.org>, Chris Healy <cphealy@gmail.com>,
        Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-nvme@lists.infradead.org, Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=E5=B9=B411=E6=9C=881=E6=97=A5(=E9=87=91) 12:56 Guenter Roeck <linux@ro=
eck-us.net>:
> +void nvme_hwmon_init(struct nvme_ctrl *ctrl)
> +{
> +       struct device *dev =3D ctrl->device;

Should we use 'ctrl->dev' instead of 'ctrl->device'?

The 'ctrl->device' is a pointer to char device and the '->of_node' member
is NULL.

So if devm_hwmon_device_register_with_info() (i.e. __hwmon_device_register)
is called with 'ctrl->device', it doesn't attempt to register a sensor to a
DT thermal zone (i.e. hwmon_thermal_add_sensor() is not called at all).

This change was required, when I tried this nvme hwmon patch with the
following DT thermal setup.

https://lore.kernel.org/linux-devicetree/1561990354-4084-3-git-send-email-a=
kinobu.mita@gmail.com/

> +       struct nvme_hwmon_data *data;
> +       struct device *hwmon;
> +       int err;
> +
> +       data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> +       if (!data)
> +               return;
> +
> +       data->ctrl =3D ctrl;
> +       mutex_init(&data->read_lock);
> +
> +       err =3D nvme_hwmon_get_smart_log(data);
> +       if (err) {
> +               dev_warn(dev, "Failed to read smart log (error %d)\n", er=
r);
> +               devm_kfree(dev, data);
> +               return;
> +       }
> +
> +       hwmon =3D devm_hwmon_device_register_with_info(dev, dev_name(dev)=
, data,
> +                                                    &nvme_hwmon_chip_inf=
o,
> +                                                    NULL);

If the above change is applied, the second 'name' argument is changed
from 'nvme0' to '0000:01:00.0' as a side effect.  So we may want to
change the second argument, too.

> +       if (IS_ERR(hwmon)) {
> +               dev_warn(dev, "Failed to instantiate hwmon device\n");
> +               devm_kfree(dev, data);
> +       }
> +}