Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp679433ybx; Fri, 1 Nov 2019 09:30:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkAqyT1fdDm7qwG7rq+T9/hqoz3+vaXFiVTbOL3hbMMPmUrbLfdVM++753+BgmA7B2/7IY X-Received: by 2002:a17:906:48c5:: with SMTP id d5mr10684143ejt.167.1572625852589; Fri, 01 Nov 2019 09:30:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572625852; cv=none; d=google.com; s=arc-20160816; b=ML/VAB2VJrWoDTANUBWL1yvTwLOm/CW6cLqe6ekWVstItU75VAHaO9vQG9lYe0w7Iw stAZH0IuW058mT/g/9QbfOQO3sOslp20xqK3mxFYvt3pfuBzIt+cJJXJMF4jAtObY3Eu o2YY6Jc/Pp9j9vBUm1BSNfP2Eo2tpFO5XtWIU43ARkgmmxjwZnqIn54bVRHGaBxOD9lg 14Llz+uTcXnp5ZIaXXKXKbgkCbfOcLWOuNY8B3xDdjW8sssBe4mRCHMifQkoXTZzgfQl TU/bRxeFYpoB+exSGLFx/4Bzw5jJHapWyRIbP9CL3ggYHFbBVAOadhawGYoL6bRut4Tc p0kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/GQwvPROkxrGiZ/7CVRjHoUFkX1F6OD+XbAKUmOONkk=; b=0oxdYA17da2Nt4j+RWJFGaKP/HaWtZ9thCwWPY9vXXtgNp3gG84V9MR1hKzHS78VJ5 7+XChR2fraUzlAWtezTEcFA7+PZbdFnWWCmJbbQufXLr+DMnw1xtuzaGQ+S1HtrmjEoO QQaYbLI4+ccVUlNqb6fDWl8rHmXU1eFR5eYYNOlYdX1bxoGlz4IS3yMmnjQbLj1V+jW9 6jsPi4vd4DbE2nk+yUT4geECHb4sQJqnqrUXWOG9uioH/9+sbrgLT2pG/13EzLSfz1xI iy8u0yu6DQ+XEYY07BdbEctu75IS10FWsbKPs59jQ7OMPU8XuqK+W+oXA4PKtfveHkcK X69A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lw2si235587ejb.440.2019.11.01.09.30.28; Fri, 01 Nov 2019 09:30:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728829AbfKAQ3M (ORCPT + 99 others); Fri, 1 Nov 2019 12:29:12 -0400 Received: from foss.arm.com ([217.140.110.172]:38210 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726701AbfKAQ3M (ORCPT ); Fri, 1 Nov 2019 12:29:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A11591FB; Fri, 1 Nov 2019 09:29:11 -0700 (PDT) Received: from blommer (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5829C3F719; Fri, 1 Nov 2019 09:29:08 -0700 (PDT) Date: Fri, 1 Nov 2019 16:28:58 +0000 From: Mark Rutland To: Sven Schnelle Cc: jthierry@redhat.com, linux-parisc@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, deller@gmx.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, James.Bottomley@HansenPartnership.com, takahiro.akashi@linaro.org, mingo@redhat.com, james.morse@arm.com, jeyu@kernel.org, amit.kachhap@arm.com, will@kernel.org, duwe@suse.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv2 0/8] arm64: ftrace cleanup + FTRACE_WITH_REGS Message-ID: <20191101162847.GA3677@blommer> References: <20191029165832.33606-1-mark.rutland@arm.com> <20191101153929.GA9053@t470p.stackframe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191101153929.GA9053@t470p.stackframe.org> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2019 at 04:39:30PM +0100, Sven Schnelle wrote: > On Tue, Oct 29, 2019 at 04:58:24PM +0000, Mark Rutland wrote: > > This series is a reworked version of Torsten's FTRACE_WITH_REGS series > > [1]. I've tried to rework the existing code in preparatory patches so > > that the patchable-function-entry bits slot in with fewer surprises. > > This version is based on v5.4-rc3, and can be found in my > > arm64/ftrace-with-regs branch [2]. > > > > Patch 1 adds an (optional) ftrace_init_nop(), which the core code uses > > to initialize callsites. This allows us to avoid a synthetic MCOUNT_ADDR > > symbol, and more cleanly separates the one-time initialization of the > > callsite from dynamic NOP<->CALL modification. Architectures which don't > > implement this get the existing ftrace_make_nop() with MCOUNT_ADDR. > > > > Recently parisc gained ftrace support using patchable-function-entry. > > Patch 2 makes the handling of module callsite locations common in > > kernel/module.c with a new FTRACE_CALLSITE_SECTION definition, and > > removed the newly redundant bits from arch/parisc. > > Since v1 [3]: > > * Add a couple of people to Cc > > * Fold in Ard's Reviewed-by tag > > * Rename ftrace_code_init_disabled() to ftrace_nop_initialize() > > * Move ftrace_init_nop() to , with kerneldoc > > * Update kerneldoc for rec parameters > [..] > > I tested this series on parisc both with ftracing kernel internal functions and > module functions. Both are working fine, so feel free to add my > > Tested-by: Sven Schnelle Thanks! That's much appreciated. I've applied that to patches 1 and 2, since the remainder of the series was confined to arch/arm64/. Mark.