Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp748983ybx; Fri, 1 Nov 2019 10:35:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzN6G/9nH2FnvzBJi5njAPAc5K9/NxF4HcsY6j22AK/WJmJSECUh6PWk2qDl6f8xK5DZAfh X-Received: by 2002:a05:6402:7c4:: with SMTP id u4mr5516316edy.135.1572629707382; Fri, 01 Nov 2019 10:35:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572629707; cv=none; d=google.com; s=arc-20160816; b=0amBOlHvNU3ciGKbsSoFEfDNYX66TCt85eGSd4CDQtkV3bJMRGCW9Lw7uNKatgTz/b ketGMt3kPUdwuvNTwnyYhH+FVaUCS2YWtA54sqSEBvntiSWbLPBEBq+AYf3mx53EQO06 fEW+ZktgiNGMiafR939FuvPQhgYeZu3II/gAJZYfHXXeW/O7bu+cC37fjYoqqvysmgmi +vlybv4+xzaA1p7IujmceCymtDQN1fkdC9e0ItpEP51Cg/BJvyBxLZFXtcgPYR0SpwKj XRX10ZT+dw5a6FS7+zNl4iNEdpeAUC/s5IqD/i4p2nPg9Kdx2hb3W3AqmkqTBJfw3Q+H OkCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ccQlb3JxfBKHeWYpHWwvhRlWVj7tO2U5jMtuu8290wo=; b=nxr1zB53Fr9SLvqAk0P0Z8kw1h8gX+zI+2sVYh4ffowYlG22JuxeXWjb1rBPdcOihu 9DCtHjNQEHlFbhDBSBdFHKo0YS3+MMaP4lYvl+R2TOasZduCs436z+vdl29oe79zWrMy DifpphNGpzPfcI/E/gXEsP5qOmy6FE/4u8kHpc70mTyJCUcvgBcroqzR3mkdg7oRpOFZ 2zH9/NF4Fz3ehVYF2+Y+qFkuwA+Nj9jkA9bU0kx9Tf0n4PISM5oSsqb7hDZ9eGu6V1PP KwrmRGGCDoC9FRzoStAwz9s13sz3XTKkd90/tOA/26OT135oxjB8IMfgxEYd4e8q0FNf FYug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TfCWJlId; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c23si6320430ejk.143.2019.11.01.10.34.42; Fri, 01 Nov 2019 10:35:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TfCWJlId; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728744AbfKARZP (ORCPT + 99 others); Fri, 1 Nov 2019 13:25:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726944AbfKARZO (ORCPT ); Fri, 1 Nov 2019 13:25:14 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE79C2085B; Fri, 1 Nov 2019 17:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572629113; bh=+qlcQrAcofigYmEOrqHZxFLTcNDou11VfkwAvg2V3Wk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TfCWJlIdlWjJkOaipR+OYMfq9mRd+Pba5vzWzfBrBYvpcbu786gFyBDTdgtaIh/lS O/3qxiKRWCj9NQr6D076jk0ZtXxj3femZv6c+xfONWDm1lhdSTpUd9UlnAeSyx9KLu 5+fi8z9iHcNDDixu9oHkqmbG3AjGlzi2w3odoGr8= Date: Fri, 1 Nov 2019 17:25:08 +0000 From: Will Deacon To: Sai Prakash Ranjan Cc: agross@kernel.org, Robin Murphy , Joerg Roedel , iommu@lists.linux-foundation.org, Stephen Boyd , Vivek Gautam , bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCHv7 0/3] QCOM smmu-500 wait-for-safe handling for sdm845 Message-ID: <20191101172508.GB3983@willie-the-truck> References: <20191101163136.GC3603@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2019 at 10:49:00PM +0530, Sai Prakash Ranjan wrote: > On 2019-11-01 22:01, Will Deacon wrote: > > On Fri, Sep 20, 2019 at 01:34:26PM +0530, Sai Prakash Ranjan wrote: > > > Previous version of the patches are at [1]: > > > > > > QCOM's implementation of smmu-500 on sdm845 adds a hardware logic > > > called > > > wait-for-safe. This logic helps in meeting the invalidation > > > requirements > > > from 'real-time clients', such as display and camera. This > > > wait-for-safe > > > logic ensures that the invalidations happen after getting an ack > > > from these > > > devices. > > > In this patch-series we are disabling this wait-for-safe logic from > > > the > > > arm-smmu driver's probe as with this enabled the hardware tries to > > > throttle invalidations from 'non-real-time clients', such as USB and > > > UFS. > > > > > > For detailed information please refer to patch [3/4] in this series. > > > I have included the device tree patch too in this series for someone > > > who > > > would like to test out this. Here's a branch [2] that gets display > > > on MTP > > > SDM845 device. > > > > > > This patch series is inspired from downstream work to handle > > > under-performance > > > issues on real-time clients on sdm845. In downstream we add separate > > > page table > > > ops to handle TLB maintenance and toggle wait-for-safe in tlb_sync > > > call so that > > > achieve required performance for display and camera [3, 4]. > > > > What's the plan for getting this merged? I'm not happy taking the > > firmware > > bits without Andy's ack, but I also think the SMMU changes should go via > > the IOMMU tree to avoid conflicts. > > > > Andy? > > > > Bjorn maintains QCOM stuff now if I am not wrong and he has already reviewed > the firmware bits. So I'm hoping you could take all these through IOMMU > tree. Oh, I didn't realise that. Is there a MAINTAINERS update someplace? If I run: $ ./scripts/get_maintainer.pl -f drivers/firmware/qcom_scm-64.c in linux-next, I get: Andy Gross (maintainer:ARM/QUALCOMM SUPPORT) linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT) linux-kernel@vger.kernel.org (open list) Will