Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp749032ybx; Fri, 1 Nov 2019 10:35:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxupbmhp5L9X6YZQoedMfEbUO8dYuSUwUqOruSIXKm8zuqiCu/5rRSCG1Q3veD/LO64S+x5 X-Received: by 2002:a17:906:1812:: with SMTP id v18mr10996320eje.86.1572629709198; Fri, 01 Nov 2019 10:35:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572629709; cv=none; d=google.com; s=arc-20160816; b=F3gXUsPmX8oSTelgaUQ9tOakwJZpCUouXO33zAxnWXGXYvfCVxr0McrGyVSYX0Sh4c wSJwSCpym4o7pwp3vdfZVZKUgGQ5EFxqUx1r14jqSxLkQLBGN+b3taotXVjDDY2Rf1jZ BSemwsKZ0VjlxLBkHfEutJuZaBmwkGGaf7KNRsqWAfpl81HUQg0j3Ff+bLSMwecnbs4v jj38zEyjoOfB3+kOV75sYhjQDxsmWivapEAAkRbv4pzb6uu71rI0Hp+1IcAkL6hlI/KP hubDzCq5LdYVIsrPesmeOz9VjNTmBKXeVavrYahmxoFW6j/1RCaAsDBTxomwdyLUGjg5 fclQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=deykE9gCJyGYmCS0uMMMqTjciPrHf6YDBvSnei5cQzE=; b=O5tYr+txke6tJHdpAVxXGe3gdz/3p3yH07H8juGX8Tgd+o5Whz7RjnKfgxJSJxP8ah W04R/qX2+CCwrprIMR+ImrTM7nOj61lti8aJrWwVGIl2RiVAxy3LD2qxU+GWqrrITGRW NF7eTVv93Hr3WqavwfW51l7vRb6MHTTF4yHhtlszy8qDmedNjb1baGi6fZYbLwaDFUoP YmOynXLvywktyuKBYDOfdO9lJbdGy+qHRPLtu7JN7k2XKOAKt80SJkdUhhekj8rU6ihT rY3dQ66aI2iCVIUoBbClcSZjfTKiJafAWqLkJp0pvARXrVqG48uxEUnua8NmSoWYV7vs sFBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cc20si1012114edb.201.2019.11.01.10.34.45; Fri, 01 Nov 2019 10:35:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728808AbfKARZ5 (ORCPT + 99 others); Fri, 1 Nov 2019 13:25:57 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43658 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726825AbfKARZ5 (ORCPT ); Fri, 1 Nov 2019 13:25:57 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B65A11511ABF7; Fri, 1 Nov 2019 10:25:56 -0700 (PDT) Date: Fri, 01 Nov 2019 10:25:56 -0700 (PDT) Message-Id: <20191101.102556.721413828280813656.davem@davemloft.net> To: hslester96@gmail.com Cc: heiko@sntech.de, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: arc: add the missed clk_disable_unprepare From: David Miller In-Reply-To: <20191101121725.13349-1-hslester96@gmail.com> References: <20191101121725.13349-1-hslester96@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Nov 2019 10:25:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan Date: Fri, 1 Nov 2019 20:17:25 +0800 > The remove misses to disable and unprepare priv->macclk like what is done > when probe fails. > Add the missed call in remove. > > Signed-off-by: Chuhong Yuan Applied, thank you.