Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 1 Nov 2019 12:14:25 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Akinobu Mita <akinobu.mita@gmail.com>
Cc:     Keith Busch <kbusch@kernel.org>, Chris Healy <cphealy@gmail.com>,
        Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-nvme@lists.infradead.org, Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3] nvme: Add hardware monitoring support
Message-ID: <20191101191425.GA16792@roeck-us.net>
References: <20191101035646.25644-1-linux@roeck-us.net>
 <CAC5umyhiOiAiYWs2Y=L5133CCQNnAgi8oq6AbGzgkznZKz5f-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAC5umyhiOiAiYWs2Y=L5133CCQNnAgi8oq6AbGzgkznZKz5f-w@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 02, 2019 at 01:19:03AM +0900, Akinobu Mita wrote:
> 2019年11月1日(金) 12:56 Guenter Roeck <linux@roeck-us.net>:
> > +void nvme_hwmon_init(struct nvme_ctrl *ctrl)
> > +{
> > +       struct device *dev = ctrl->device;
> 
> Should we use 'ctrl->dev' instead of 'ctrl->device'?
> 

Excellent point, and most definitely yes. I should have done that
from the beginning.

> The 'ctrl->device' is a pointer to char device and the '->of_node' member
> is NULL.
> 
> So if devm_hwmon_device_register_with_info() (i.e. __hwmon_device_register)
> is called with 'ctrl->device', it doesn't attempt to register a sensor to a
> DT thermal zone (i.e. hwmon_thermal_add_sensor() is not called at all).
> 
> This change was required, when I tried this nvme hwmon patch with the
> following DT thermal setup.
> 
> https://lore.kernel.org/linux-devicetree/1561990354-4084-3-git-send-email-akinobu.mita@gmail.com/
> 
> > +       struct nvme_hwmon_data *data;
> > +       struct device *hwmon;
> > +       int err;
> > +
> > +       data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> > +       if (!data)
> > +               return;
> > +
> > +       data->ctrl = ctrl;
> > +       mutex_init(&data->read_lock);
> > +
> > +       err = nvme_hwmon_get_smart_log(data);
> > +       if (err) {
> > +               dev_warn(dev, "Failed to read smart log (error %d)\n", err);
> > +               devm_kfree(dev, data);
> > +               return;
> > +       }
> > +
> > +       hwmon = devm_hwmon_device_register_with_info(dev, dev_name(dev), data,
> > +                                                    &nvme_hwmon_chip_info,
> > +                                                    NULL);
> 
> If the above change is applied, the second 'name' argument is changed
> from 'nvme0' to '0000:01:00.0' as a side effect.  So we may want to
> change the second argument, too.
> 

Yes. I'll just name it "nvme"; after all, that is sufficient and more
consistent with other drivers. Currently, we get something like
	nvme0-pci-0100
	nvme1-pci-2500
if there are multiple drives, where the "0" and "1" are not really
necessary.

Thanks!
Guenter