Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp871183ybx; Fri, 1 Nov 2019 12:37:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKi76hElxjd4e0BNklNSlpj2QNYdGAKWnXqt7xKIAG+URNIaKguay2Mqd0nf+9zjKf1JI5 X-Received: by 2002:aa7:d582:: with SMTP id r2mr15044345edq.193.1572637024982; Fri, 01 Nov 2019 12:37:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572637024; cv=none; d=google.com; s=arc-20160816; b=A5apLCdPNmb/+frUMRKo+CSjCTmEJ4pRgc9HBmo2oU8L4Zd/QKrtepHV0d41sYGh9z ezVtMvr84/yvrrqkmjlq9qQA/H8FuCYNBwSkAwubj9F6G/Zr8IRxCN/LrkGEeKzC3oET gtfZOfoxqwIw/fXgTiEzrG3JbvOn3bzoOPxBD3vObpKZmLlwl/vRTYuG+M8UfHDJgmXR edKK1TxqtIHfV25tUkJgL/uuX2G1GOPqD6gM3a8tTbClqZb9IjDu9oJg3t41UjQV/ldO boo0IhRnk1Qo67NMlwWn2fzXq4HcM6kQHTS6HrOxctur2wk/ThpXXs8FUba9cupHHVvK JyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=OtHLUn4xDhKT6QBDBC+7vVqc6TBwcOWLtLosvYS3BSk=; b=WMW09Wq1dPbnIl0uI4dk4qhmfYd+3l9jXTQzIUdUJSkBLsyol+3cda84dFdjR3NbP6 JdTPaO1RtAoYIsAOEmLH8JYWiCPMM3JXvUuEc59acb8Pe+iA/YuxH3bfJISmEkqUnh4L +6K+kvlmeeWKWWcdF4giYzPUMm/b9dXAhBWU2AwXbhf2VZ0tZxocIuKd1mBT8oZbL0jF BF4YqQAWW+495+51I86T0+UjJm3zZTYTOtq1/Dl/0oZL4eDEMfbik9np7hZKS4gHQd9O iGVNiItdD3YqMrjLvZ9LW2qbQM4bS7dPOAqwwGF0ybg4J5KwpusBM7frpiWXNbzFERCS rBXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kcj21evp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k39si1251969edb.99.2019.11.01.12.36.41; Fri, 01 Nov 2019 12:37:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kcj21evp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbfKATfq (ORCPT + 99 others); Fri, 1 Nov 2019 15:35:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:43966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbfKATfp (ORCPT ); Fri, 1 Nov 2019 15:35:45 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDF13217D9; Fri, 1 Nov 2019 19:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572636945; bh=TD/4EVGajF1pvAJu8BvCJSc0WAO+35JeCmCE73abJz8=; h=Date:From:To:Subject:In-Reply-To:References:From; b=kcj21evp7laeZ3PBP7m9bhba8T8SgvmLhPTex6Zfu4JzkEMl33NA3ZSwOg1lEwDMG ALaElUIt9ThCCZ2uo/WBuyEu1Q9/rtZ5gFk1aXIOtvnDpS+F4604rpPq3uvAqcu8rK acruqAA2YvAFT+xcRHPj35GAijhKWCAzwpiUXExg= Date: Fri, 1 Nov 2019 12:35:44 -0700 From: Andrew Morton To: Chris Down , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Alexey Dobriyan Subject: Re: [PATCH] kernel: sysctl: make drop_caches write-only Message-Id: <20191101123544.c9b0024a1e8f5ddf63148b48@linux-foundation.org> In-Reply-To: <20191101122920.798a6d61b2725da8cfe80549@linux-foundation.org> References: <20191031221602.9375-1-hannes@cmpxchg.org> <20191031162825.a545a5d4d8567368501769bd@linux-foundation.org> <20191101110901.GB690103@chrisdown.name> <20191101144540.GA12808@cmpxchg.org> <20191101115950.bb88d49849bfecb1af0a88bf@linux-foundation.org> <20191101192405.GA866154@chrisdown.name> <20191101122920.798a6d61b2725da8cfe80549@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Nov 2019 12:29:20 -0700 Andrew Morton wrote: > > Either change is an upgrade from the current situation, at least. I prefer > > towards whatever makes the API the least confusing, which appears to be > > Johannes' original change, but I'd support a patch which always set it to > > 0 instead if it was deemed safer. > > On the other hand.. As I mentioned earlier, if someone's code is > failing because of the permissions change, they can chmod > /proc/sys/vm/drop_caches at boot time and be happy. They have no such > workaround if their software misbehaves due to a read always returning > "0". I lied. I can chmod things in /proc but I can't chmod things in /proc/sys/vm. Huh, why did we do that?