Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191101180713.5470-1-robdclark@gmail.com> <20191101180713.5470-2-robdclark@gmail.com>
 <ec3c1d7b-231a-862f-ce12-8ac4c9616ca5@linux.intel.com>
In-Reply-To: <ec3c1d7b-231a-862f-ce12-8ac4c9616ca5@linux.intel.com>
From:   Rob Clark <robdclark@chromium.org>
Date:   Fri, 1 Nov 2019 12:44:04 -0700
Message-ID: <CAJs_Fx6ErP9ap=veqJSrN-coKm_VV78wxqYLj_QF+-Gutk5AZA@mail.gmail.com>
Subject: Re: [PATCH 2/2] drm/atomic: clear new_state pointers at hw_done
To:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc:     Rob Clark <robdclark@gmail.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Sean Paul <seanpaul@chromium.org>,
        Maxime Ripard <mripard@kernel.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 1, 2019 at 11:33 AM Maarten Lankhorst
<maarten.lankhorst@linux.intel.com> wrote:
>
> Op 01-11-2019 om 19:07 schreef Rob Clark:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > The new state should not be accessed after this point.  Clear the
> > pointers to make that explicit.
> >
> > This makes the error corrected in the previous patch more obvious.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
>
> Would be nice if you could cc intel-gfx@lists.freedesktop.org next time, so I know our CI infrastructure is happy;
>
> It wouldn't surprise me if it catches 1 or 2 abuses in i915.
>
> Otherwise Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Perhaps you could mail this to version to intel-gfx-trybot@lists.freedesktop.org using git-send-email so we at least get i915 results?

ok, I sent both patches to trybot, hopefully it tries them together,
as this patch without the self-refresh fix will definitely fall over

BR,
-R