Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp956184ybx; Fri, 1 Nov 2019 14:08:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZH1VMC+zbD28JBIkyTZW40qBvBnlMp0LlOJoAUdMBpaGaRztkQ7uYqgBTpNMwast+Xt0F X-Received: by 2002:a17:906:5399:: with SMTP id g25mr11980355ejo.125.1572642528495; Fri, 01 Nov 2019 14:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572642528; cv=none; d=google.com; s=arc-20160816; b=QuaAQENmD4XfLVCbK74qXvoEeF/ejdYNTYzXnDzIWefphfx4YoaVubBqyZKgoYPkkP xDBEvYtsxv6QcJPnWuD3tK7c+wOVn1STIDLpy0Wn3q5NhXcTvHICkD32Z1RAcfyTs7iS +sbZoEOoXyMCElNQVNQsGY3D9GXGyI0jS5pVgw3amR48uY0bcxTLctrmR5gtCBj81KJP xZZCwkPCldv9BUnreElAtnb40K5Y1LT82iZISRu6pYJYhUeE6XoqRkIYcQ3L7yBeM8no 1ScHSLF5ilvYvl9qxwOqo+X9IpOVvKH511nukVZMDxs8ouBy8KrPAaEDdfh6B5ITTlIV YjBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=tZ0h3EbFObpMXriwNz6TxLUzEv415VpeQRqv5BkyAzM=; b=BpqiTq9pYLfdbz9kqDAKotZDvgYmPpsmkr0TaMKg0erzVBAGDwMqv8Tw3tEaP9EwpZ MAJ1fbQvnGFbWeJmwN0lMGQQweU3OIRZZhvRYBcx08sxlP00X21mToxltazC9lW5Q5tp 7cxx3/98OZJ3qK9/ungoi4WDeZpnRr3WXnO6eeZC96QxjdC2XL9TKVkGVPqXxiAegunW C/5yLpvtctLMC13UZ6ivzoQQAxWAE9LYshsGBIyYYkBR1S6Z3yBtUqsjxtev4wYZ3PZt IBg7WQ5hCDxgfZ9BlZNbc9qh8vWOY+F1KbVaWC6a/kbFuC9ei8YjyYwi4nbl2RHTrKuy hRUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@agner.ch header.s=dkim header.b=aZ+jdaP2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16si1270127edb.23.2019.11.01.14.08.24; Fri, 01 Nov 2019 14:08:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@agner.ch header.s=dkim header.b=aZ+jdaP2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbfKAVFX (ORCPT + 99 others); Fri, 1 Nov 2019 17:05:23 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:41918 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbfKAVFX (ORCPT ); Fri, 1 Nov 2019 17:05:23 -0400 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 13B4C5C2BE5; Fri, 1 Nov 2019 22:05:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1572642318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZ0h3EbFObpMXriwNz6TxLUzEv415VpeQRqv5BkyAzM=; b=aZ+jdaP2fbJVvi7Ct9ffPndXM1r43BGv6pQuKmuFKcBj4RM4OsE/vLAZTe0ZAYd6+psrvq LN9fVToPoJkjs5IeFN4swvLqyoebECM0HMf1K9tzVMM0MEKlHCkr2kelkUZPY6LQXyGeAl PIk9EPsaaqK6Eo9s3coSxBh6OTWq2vU= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 01 Nov 2019 22:05:17 +0100 From: Stefan Agner To: Nick Desaulniers Cc: linux@armlinux.org.uk, Fangrui Song , Jian Cai , Peter Smith , Hans Ulli Kroll , Greg Kroah-Hartman , Nicolas Pitre , Enrico Weigelt , Thomas Gleixner , Roy Franz , Linus Walleij , Ard Biesheuvel , Allison Randal , Richard Fontana , Kate Stewart , Dave Martin , Sonny Rao , Doug Anderson , Vladimir Murzin , afzal mohammed , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] arm: replace Sun/Solaris style flag on section directive In-Reply-To: <20191030174429.248697-1-ndesaulniers@google.com> References: <20191030174429.248697-1-ndesaulniers@google.com> Message-ID: X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nick, On 2019-10-30 18:44, Nick Desaulniers wrote: > It looks like a section directive was using "Solaris style" to declare > the section flags. Replace this with the GNU style so that Clang's > integrated assembler can assemble this directive. > > The modified instances were identified via: > $ ag \\.section | grep \# I actually have the *very same* patch on my tree, just did not cleanup the commit message and submit :-( Anyways, this looks good to me: Reviewed-by: Stefan Agner -- Stefan > > Link: > https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 > Link: https://github.com/ClangBuiltLinux/linux/issues/744 > Link: https://bugs.llvm.org/show_bug.cgi?id=43759 > Link: https://reviews.llvm.org/D69296 > Suggested-by: Fangrui Song > Suggested-by: Jian Cai > Suggested-by: Peter Smith > Signed-off-by: Nick Desaulniers > --- > arch/arm/boot/bootp/init.S | 2 +- > arch/arm/boot/compressed/big-endian.S | 2 +- > arch/arm/boot/compressed/head.S | 2 +- > arch/arm/boot/compressed/piggy.S | 2 +- > arch/arm/mm/proc-arm1020.S | 2 +- > arch/arm/mm/proc-arm1020e.S | 2 +- > arch/arm/mm/proc-arm1022.S | 2 +- > arch/arm/mm/proc-arm1026.S | 2 +- > arch/arm/mm/proc-arm720.S | 2 +- > arch/arm/mm/proc-arm740.S | 2 +- > arch/arm/mm/proc-arm7tdmi.S | 2 +- > arch/arm/mm/proc-arm920.S | 2 +- > arch/arm/mm/proc-arm922.S | 2 +- > arch/arm/mm/proc-arm925.S | 2 +- > arch/arm/mm/proc-arm926.S | 2 +- > arch/arm/mm/proc-arm940.S | 2 +- > arch/arm/mm/proc-arm946.S | 2 +- > arch/arm/mm/proc-arm9tdmi.S | 2 +- > arch/arm/mm/proc-fa526.S | 2 +- > arch/arm/mm/proc-feroceon.S | 2 +- > arch/arm/mm/proc-mohawk.S | 2 +- > arch/arm/mm/proc-sa110.S | 2 +- > arch/arm/mm/proc-sa1100.S | 2 +- > arch/arm/mm/proc-v6.S | 2 +- > arch/arm/mm/proc-v7.S | 2 +- > arch/arm/mm/proc-v7m.S | 4 ++-- > arch/arm/mm/proc-xsc3.S | 2 +- > arch/arm/mm/proc-xscale.S | 2 +- > 28 files changed, 29 insertions(+), 29 deletions(-) > > diff --git a/arch/arm/boot/bootp/init.S b/arch/arm/boot/bootp/init.S > index 5c476bd2b4ce..b562da2f7040 100644 > --- a/arch/arm/boot/bootp/init.S > +++ b/arch/arm/boot/bootp/init.S > @@ -13,7 +13,7 @@ > * size immediately following the kernel, we could build this into > * a binary blob, and concatenate the zImage using the cat command. > */ > - .section .start,#alloc,#execinstr > + .section .start, "ax" > .type _start, #function > .globl _start > > diff --git a/arch/arm/boot/compressed/big-endian.S > b/arch/arm/boot/compressed/big-endian.S > index 88e2a88d324b..0e092c36da2f 100644 > --- a/arch/arm/boot/compressed/big-endian.S > +++ b/arch/arm/boot/compressed/big-endian.S > @@ -6,7 +6,7 @@ > * Author: Nicolas Pitre > */ > > - .section ".start", #alloc, #execinstr > + .section ".start", "ax" > > mrc p15, 0, r0, c1, c0, 0 @ read control reg > orr r0, r0, #(1 << 7) @ enable big endian mode > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > index 93dffed0ac6e..15ecad944847 100644 > --- a/arch/arm/boot/compressed/head.S > +++ b/arch/arm/boot/compressed/head.S > @@ -140,7 +140,7 @@ > #endif > .endm > > - .section ".start", #alloc, #execinstr > + .section ".start", "ax" > /* > * sort out different calling conventions > */ > diff --git a/arch/arm/boot/compressed/piggy.S b/arch/arm/boot/compressed/piggy.S > index 0284f84dcf38..27577644ee72 100644 > --- a/arch/arm/boot/compressed/piggy.S > +++ b/arch/arm/boot/compressed/piggy.S > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > - .section .piggydata,#alloc > + .section .piggydata, "a" > .globl input_data > input_data: > .incbin "arch/arm/boot/compressed/piggy_data" > diff --git a/arch/arm/mm/proc-arm1020.S b/arch/arm/mm/proc-arm1020.S > index 4fa5371bc662..2785da387c91 100644 > --- a/arch/arm/mm/proc-arm1020.S > +++ b/arch/arm/mm/proc-arm1020.S > @@ -491,7 +491,7 @@ cpu_arm1020_name: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm1020_proc_info,#object > __arm1020_proc_info: > diff --git a/arch/arm/mm/proc-arm1020e.S b/arch/arm/mm/proc-arm1020e.S > index 5d8a8339e09a..e9ea237ed785 100644 > --- a/arch/arm/mm/proc-arm1020e.S > +++ b/arch/arm/mm/proc-arm1020e.S > @@ -449,7 +449,7 @@ arm1020e_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm1020e_proc_info,#object > __arm1020e_proc_info: > diff --git a/arch/arm/mm/proc-arm1022.S b/arch/arm/mm/proc-arm1022.S > index b3dd95c345e4..920c279e7879 100644 > --- a/arch/arm/mm/proc-arm1022.S > +++ b/arch/arm/mm/proc-arm1022.S > @@ -443,7 +443,7 @@ arm1022_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm1022_proc_info,#object > __arm1022_proc_info: > diff --git a/arch/arm/mm/proc-arm1026.S b/arch/arm/mm/proc-arm1026.S > index ac5afde12f35..10e21012380b 100644 > --- a/arch/arm/mm/proc-arm1026.S > +++ b/arch/arm/mm/proc-arm1026.S > @@ -437,7 +437,7 @@ arm1026_crval: > string cpu_arm1026_name, "ARM1026EJ-S" > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm1026_proc_info,#object > __arm1026_proc_info: > diff --git a/arch/arm/mm/proc-arm720.S b/arch/arm/mm/proc-arm720.S > index c99d24363f32..39361e196d61 100644 > --- a/arch/arm/mm/proc-arm720.S > +++ b/arch/arm/mm/proc-arm720.S > @@ -172,7 +172,7 @@ arm720_crval: > * See for a definition of this structure. > */ > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro arm720_proc_info name:req, cpu_val:req, cpu_mask:req, > cpu_name:req, cpu_flush:req > .type __\name\()_proc_info,#object > diff --git a/arch/arm/mm/proc-arm740.S b/arch/arm/mm/proc-arm740.S > index 1b4a3838393f..1a94bbf6e53f 100644 > --- a/arch/arm/mm/proc-arm740.S > +++ b/arch/arm/mm/proc-arm740.S > @@ -128,7 +128,7 @@ __arm740_setup: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > .type __arm740_proc_info,#object > __arm740_proc_info: > .long 0x41807400 > diff --git a/arch/arm/mm/proc-arm7tdmi.S b/arch/arm/mm/proc-arm7tdmi.S > index 17a4687065c7..52b66cf0259e 100644 > --- a/arch/arm/mm/proc-arm7tdmi.S > +++ b/arch/arm/mm/proc-arm7tdmi.S > @@ -72,7 +72,7 @@ __arm7tdmi_setup: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro arm7tdmi_proc_info name:req, cpu_val:req, cpu_mask:req, cpu_name:req, \ > extra_hwcaps=0 > diff --git a/arch/arm/mm/proc-arm920.S b/arch/arm/mm/proc-arm920.S > index 298c76b47749..31ac8acc34dc 100644 > --- a/arch/arm/mm/proc-arm920.S > +++ b/arch/arm/mm/proc-arm920.S > @@ -434,7 +434,7 @@ arm920_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm920_proc_info,#object > __arm920_proc_info: > diff --git a/arch/arm/mm/proc-arm922.S b/arch/arm/mm/proc-arm922.S > index 824be3a0bc23..ca2c7ca8af21 100644 > --- a/arch/arm/mm/proc-arm922.S > +++ b/arch/arm/mm/proc-arm922.S > @@ -412,7 +412,7 @@ arm922_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm922_proc_info,#object > __arm922_proc_info: > diff --git a/arch/arm/mm/proc-arm925.S b/arch/arm/mm/proc-arm925.S > index d40cff8f102c..a381a0c9f109 100644 > --- a/arch/arm/mm/proc-arm925.S > +++ b/arch/arm/mm/proc-arm925.S > @@ -477,7 +477,7 @@ arm925_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro arm925_proc_info name:req, cpu_val:req, cpu_mask:req, > cpu_name:req, cache > .type __\name\()_proc_info,#object > diff --git a/arch/arm/mm/proc-arm926.S b/arch/arm/mm/proc-arm926.S > index f3cd08f353f0..3188ab2bac61 100644 > --- a/arch/arm/mm/proc-arm926.S > +++ b/arch/arm/mm/proc-arm926.S > @@ -460,7 +460,7 @@ arm926_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm926_proc_info,#object > __arm926_proc_info: > diff --git a/arch/arm/mm/proc-arm940.S b/arch/arm/mm/proc-arm940.S > index 1c26d991386d..4b8a00220cc9 100644 > --- a/arch/arm/mm/proc-arm940.S > +++ b/arch/arm/mm/proc-arm940.S > @@ -340,7 +340,7 @@ __arm940_setup: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __arm940_proc_info,#object > __arm940_proc_info: > diff --git a/arch/arm/mm/proc-arm946.S b/arch/arm/mm/proc-arm946.S > index 2dc1c75a4fd4..555becf9c758 100644 > --- a/arch/arm/mm/proc-arm946.S > +++ b/arch/arm/mm/proc-arm946.S > @@ -395,7 +395,7 @@ __arm946_setup: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > .type __arm946_proc_info,#object > __arm946_proc_info: > .long 0x41009460 > diff --git a/arch/arm/mm/proc-arm9tdmi.S b/arch/arm/mm/proc-arm9tdmi.S > index 913c06e590af..ef517530130b 100644 > --- a/arch/arm/mm/proc-arm9tdmi.S > +++ b/arch/arm/mm/proc-arm9tdmi.S > @@ -66,7 +66,7 @@ __arm9tdmi_setup: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro arm9tdmi_proc_info name:req, cpu_val:req, cpu_mask:req, cpu_name:req > .type __\name\()_proc_info, #object > diff --git a/arch/arm/mm/proc-fa526.S b/arch/arm/mm/proc-fa526.S > index 8120b6f4dbb8..dddf833fe000 100644 > --- a/arch/arm/mm/proc-fa526.S > +++ b/arch/arm/mm/proc-fa526.S > @@ -185,7 +185,7 @@ fa526_cr1_set: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __fa526_proc_info,#object > __fa526_proc_info: > diff --git a/arch/arm/mm/proc-feroceon.S b/arch/arm/mm/proc-feroceon.S > index bb6dc34d42a3..b12b76bc8d30 100644 > --- a/arch/arm/mm/proc-feroceon.S > +++ b/arch/arm/mm/proc-feroceon.S > @@ -571,7 +571,7 @@ feroceon_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro feroceon_proc_info name:req, cpu_val:req, cpu_mask:req, > cpu_name:req, cache:req > .type __\name\()_proc_info,#object > diff --git a/arch/arm/mm/proc-mohawk.S b/arch/arm/mm/proc-mohawk.S > index f08308578885..d47d6c5cee63 100644 > --- a/arch/arm/mm/proc-mohawk.S > +++ b/arch/arm/mm/proc-mohawk.S > @@ -416,7 +416,7 @@ mohawk_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __88sv331x_proc_info,#object > __88sv331x_proc_info: > diff --git a/arch/arm/mm/proc-sa110.S b/arch/arm/mm/proc-sa110.S > index d5bc5d702563..baba503ba816 100644 > --- a/arch/arm/mm/proc-sa110.S > +++ b/arch/arm/mm/proc-sa110.S > @@ -196,7 +196,7 @@ sa110_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .type __sa110_proc_info,#object > __sa110_proc_info: > diff --git a/arch/arm/mm/proc-sa1100.S b/arch/arm/mm/proc-sa1100.S > index be7b611c76c7..75ebacc8e4e5 100644 > --- a/arch/arm/mm/proc-sa1100.S > +++ b/arch/arm/mm/proc-sa1100.S > @@ -239,7 +239,7 @@ sa1100_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro sa1100_proc_info name:req, cpu_val:req, cpu_mask:req, cpu_name:req > .type __\name\()_proc_info,#object > diff --git a/arch/arm/mm/proc-v6.S b/arch/arm/mm/proc-v6.S > index c1c85eb3484f..1dd0d5ca27da 100644 > --- a/arch/arm/mm/proc-v6.S > +++ b/arch/arm/mm/proc-v6.S > @@ -261,7 +261,7 @@ v6_crval: > string cpu_elf_name, "v6" > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > /* > * Match any ARMv6 processor core. > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S > index c4e8006a1a8c..48e0ef6f0dcc 100644 > --- a/arch/arm/mm/proc-v7.S > +++ b/arch/arm/mm/proc-v7.S > @@ -644,7 +644,7 @@ __v7_setup_stack: > string cpu_elf_name, "v7" > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > /* > * Standard v7 proc info content > diff --git a/arch/arm/mm/proc-v7m.S b/arch/arm/mm/proc-v7m.S > index 1a49d503eafc..84459c1d31b8 100644 > --- a/arch/arm/mm/proc-v7m.S > +++ b/arch/arm/mm/proc-v7m.S > @@ -93,7 +93,7 @@ ENTRY(cpu_cm7_proc_fin) > ret lr > ENDPROC(cpu_cm7_proc_fin) > > - .section ".init.text", #alloc, #execinstr > + .section ".init.text", "ax" > > __v7m_cm7_setup: > mov r8, #(V7M_SCB_CCR_DC | V7M_SCB_CCR_IC| V7M_SCB_CCR_BP) > @@ -177,7 +177,7 @@ ENDPROC(__v7m_setup) > string cpu_elf_name "v7m" > string cpu_v7m_name "ARMv7-M" > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro __v7m_proc name, initfunc, cache_fns = nop_cache_fns, hwcaps = > 0, proc_fns = v7m_processor_functions > .long 0 /* proc_info_list.__cpu_mm_mmu_flags */ > diff --git a/arch/arm/mm/proc-xsc3.S b/arch/arm/mm/proc-xsc3.S > index 1ac0fbbe9f12..42eaecc43cfe 100644 > --- a/arch/arm/mm/proc-xsc3.S > +++ b/arch/arm/mm/proc-xsc3.S > @@ -496,7 +496,7 @@ xsc3_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro xsc3_proc_info name:req, cpu_val:req, cpu_mask:req > .type __\name\()_proc_info,#object > diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S > index bdb2b7749b03..18ac5a1f8922 100644 > --- a/arch/arm/mm/proc-xscale.S > +++ b/arch/arm/mm/proc-xscale.S > @@ -610,7 +610,7 @@ xscale_crval: > > .align > > - .section ".proc.info.init", #alloc > + .section ".proc.info.init", "a" > > .macro xscale_proc_info name:req, cpu_val:req, cpu_mask:req, > cpu_name:req, cache > .type __\name\()_proc_info,#object