Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1730365ybx; Sat, 2 Nov 2019 05:22:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqyoVCy9lmMTPEgVwRpQjViNRJ62zlYgUCx5NoVO+JWnZlRpHGkn5Hu5nNv5RW9lI6tCbt7D X-Received: by 2002:a17:906:1812:: with SMTP id v18mr14787672eje.86.1572697360141; Sat, 02 Nov 2019 05:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572697360; cv=none; d=google.com; s=arc-20160816; b=U1VIZ5P8pSX/tJiZy1bum00cvdLPYSzF1FAgprAJeMwKn7aoDqybB6VAqYCyh6WG1Y r9t2I5KuT3uZOK2+Mte++2kadYPMA9Wtr/3oWGSLtpNYT/RdRkLgdjJia5WMT71f+ADV cJFQix4TPc3Jlxodawx+mQs/sJParou6OQcPbajavaFW/fG29bQJZ7QwBROC7HhAH1i8 vhsMTWC0xvs5w/OzwZcZzx2A+3k/ZzMVNkO4FGTMzQqtPggh+cF58VsYqx1aRMHyd12X yATQoVlJqbBpkeqDC02Eny6T67Wi7rmeXNVmkAeODmI/fQi4tjFm13Q5ByPkfElg61C7 3aQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=oHSgpwcpONoKT8va4JfEH5/KU5Cy0LbLWriZmFhHsLQ=; b=mz8WBXDDqbD2Sdu1DEq/aFDigw4Qu7Ds0AL9iJGL1e3chsnwko0RJhozUlOVNndYi2 BLpyBvyNRXuwI9rLHpqgD/jBMazGXTxvjnXDF2RivttIsq0a5ydHkmqCeBxgquhWnlaJ 6QA+xPAliXiw7qFUFbS9dqwuaPT9SGP4beMRCNr+wNlsXMwjTvytuXvykpd4VTwvS46J /sEErUpCeqEp+ebAnaplNG/7vw1jqX1IPFaJFEkhaK05ui/CpmY0tV0FR/ELa2il2CiH dSbYEm5psWORCaCPRZZvyzVREsocUyUi9cLqS06n8m1KVGAYL55Su73eqcFhDcy5E1f6 okEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z65si3646844ede.388.2019.11.02.05.22.16; Sat, 02 Nov 2019 05:22:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbfKBMUK (ORCPT + 99 others); Sat, 2 Nov 2019 08:20:10 -0400 Received: from foss.arm.com ([217.140.110.172]:46818 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbfKBMUK (ORCPT ); Sat, 2 Nov 2019 08:20:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9B857328; Sat, 2 Nov 2019 05:20:09 -0700 (PDT) Received: from [10.162.0.144] (a075553-lin.blr.arm.com [10.162.0.144]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 076EC3F718; Sat, 2 Nov 2019 05:20:04 -0700 (PDT) From: Amit Daniel Kachhap Subject: Re: [PATCHv2 4/8] arm64: module/ftrace: intialize PLT at load time To: Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, deller@gmx.de, duwe@suse.de, James.Bottomley@HansenPartnership.com, james.morse@arm.com, jeyu@kernel.org, jpoimboe@redhat.com, jthierry@redhat.com, linux-parisc@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, svens@stackframe.org, takahiro.akashi@linaro.org, will@kernel.org References: <20191029165832.33606-1-mark.rutland@arm.com> <20191029165832.33606-5-mark.rutland@arm.com> Message-ID: Date: Sat, 2 Nov 2019 17:50:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20191029165832.33606-5-mark.rutland@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/29/19 10:28 PM, Mark Rutland wrote: > Currently we lazily-initialize a module's ftrace PLT at runtime when we > install the first ftrace call. To do so we have to apply a number of > sanity checks, transiently mark the module text as RW, and perform an > IPI as part of handling Neoverse-N1 erratum #1542419. > > We only expect the ftrace trampoline to point at ftrace_caller() (AKA > FTRACE_ADDR), so let's simplify all of this by intializing the PLT at > module load time, before the module loader marks the module RO and > performs the intial I-cache maintenance for the module. > > Thus we can rely on the module having been correctly intialized, and can > simplify the runtime work necessary to install an ftrace call in a > module. This will also allow for the removal of module_disable_ro(). > > Tested by forcing ftrace_make_call() to use the module PLT, and then > loading up a module after setting up ftrace with: > > | echo ":mod:" > set_ftrace_filter; > | echo function > current_tracer; > | modprobe > > Since FTRACE_ADDR is only defined when CONFIG_DYNAMIC_FTRACE is > selected, we wrap its use along with most of module_init_ftrace_plt() > with ifdeffery rather than using IS_ENABLED(). > > Signed-off-by: Mark Rutland > Reviewed-by: Ard Biesheuvel > Cc: Catalin Marinas > Cc: James Morse > Cc: Peter Zijlstra > Cc: Will Deacon > --- > arch/arm64/kernel/ftrace.c | 55 ++++++++++++---------------------------------- > arch/arm64/kernel/module.c | 32 +++++++++++++++++---------- > 2 files changed, 35 insertions(+), 52 deletions(-) > > diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c > index 06e56b470315..822718eafdb4 100644 > --- a/arch/arm64/kernel/ftrace.c > +++ b/arch/arm64/kernel/ftrace.c > @@ -73,10 +73,22 @@ int ftrace_make_call(struct dyn_ftrace *rec, unsigned long addr) > > if (offset < -SZ_128M || offset >= SZ_128M) { > #ifdef CONFIG_ARM64_MODULE_PLTS > - struct plt_entry trampoline, *dst; > struct module *mod; > > /* > + * There is only one ftrace trampoline per module. For now, > + * this is not a problem since on arm64, all dynamic ftrace > + * invocations are routed via ftrace_caller(). This will need > + * to be revisited if support for multiple ftrace entry points > + * is added in the future, but for now, the pr_err() below > + * deals with a theoretical issue only. > + */ > + if (addr != FTRACE_ADDR) { > + pr_err("ftrace: far branches to multiple entry points unsupported inside a single module\n"); > + return -EINVAL; > + } > + > + /* > * On kernels that support module PLTs, the offset between the > * branch instruction and its target may legally exceed the > * range of an ordinary relative 'bl' opcode. In this case, we > @@ -93,46 +105,7 @@ int ftrace_make_call(struct dyn_ftrace *rec, unsigned long addr) > if (WARN_ON(!mod)) > return -EINVAL; > > - /* > - * There is only one ftrace trampoline per module. For now, > - * this is not a problem since on arm64, all dynamic ftrace > - * invocations are routed via ftrace_caller(). This will need > - * to be revisited if support for multiple ftrace entry points > - * is added in the future, but for now, the pr_err() below > - * deals with a theoretical issue only. > - * > - * Note that PLTs are place relative, and plt_entries_equal() > - * checks whether they point to the same target. Here, we need > - * to check if the actual opcodes are in fact identical, > - * regardless of the offset in memory so use memcmp() instead. > - */ > - dst = mod->arch.ftrace_trampoline; > - trampoline = get_plt_entry(addr, dst); > - if (memcmp(dst, &trampoline, sizeof(trampoline))) { > - if (plt_entry_is_initialized(dst)) { > - pr_err("ftrace: far branches to multiple entry points unsupported inside a single module\n"); > - return -EINVAL; > - } > - > - /* point the trampoline to our ftrace entry point */ > - module_disable_ro(mod); > - *dst = trampoline; > - module_enable_ro(mod, true); > - > - /* > - * Ensure updated trampoline is visible to instruction > - * fetch before we patch in the branch. Although the > - * architecture doesn't require an IPI in this case, > - * Neoverse-N1 erratum #1542419 does require one > - * if the TLB maintenance in module_enable_ro() is > - * skipped due to rodata_enabled. It doesn't seem worth > - * it to make it conditional given that this is > - * certainly not a fast-path. > - */ > - flush_icache_range((unsigned long)&dst[0], > - (unsigned long)&dst[1]); > - } > - addr = (unsigned long)dst; > + addr = (unsigned long)mod->arch.ftrace_trampoline; > #else /* CONFIG_ARM64_MODULE_PLTS */ > return -EINVAL; > #endif /* CONFIG_ARM64_MODULE_PLTS */ > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > index 763a86d52fef..5f5bc3b94da7 100644 > --- a/arch/arm64/kernel/module.c > +++ b/arch/arm64/kernel/module.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -485,24 +486,33 @@ static const Elf_Shdr *find_section(const Elf_Ehdr *hdr, > return NULL; > } > > +int module_init_ftrace_plt(const Elf_Ehdr *hdr, > + const Elf_Shdr *sechdrs, > + struct module *mod) I think this function can be made static as it is not used anywhere. Thanks, Amit Daniel > +{ > +#if defined(CONFIG_ARM64_MODULE_PLTS) && defined(CONFIG_DYNAMIC_FTRACE) > + const Elf_Shdr *s; > + struct plt_entry *plt; > + > + s = find_section(hdr, sechdrs, ".text.ftrace_trampoline"); > + if (!s) > + return -ENOEXEC; > + > + plt = (void *)s->sh_addr; > + *plt = get_plt_entry(FTRACE_ADDR, plt); > + mod->arch.ftrace_trampoline = plt; > +#endif > + return 0; > +} > + > int module_finalize(const Elf_Ehdr *hdr, > const Elf_Shdr *sechdrs, > struct module *me) > { > const Elf_Shdr *s; > - > s = find_section(hdr, sechdrs, ".altinstructions"); > if (s) > apply_alternatives_module((void *)s->sh_addr, s->sh_size); > > -#ifdef CONFIG_ARM64_MODULE_PLTS > - if (IS_ENABLED(CONFIG_DYNAMIC_FTRACE)) { > - s = find_section(hdr, sechdrs, ".text.ftrace_trampoline"); > - if (!s) > - return -ENOEXEC; > - me->arch.ftrace_trampoline = (void *)s->sh_addr; > - } > -#endif > - > - return 0; > + return module_init_ftrace_plt(hdr, sechdrs, me); > } >