Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1963935ybx; Sat, 2 Nov 2019 09:32:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1aCIpTig7DFSsYzqikShp8Betm8IEkNY/7wPabPTVHbtnlTV7S3fvclr75uhAcTVaGOF2 X-Received: by 2002:a17:907:4300:: with SMTP id oa24mr2511760ejb.8.1572712358282; Sat, 02 Nov 2019 09:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572712358; cv=none; d=google.com; s=arc-20160816; b=lJxKRQOgZ1+YXF9wsbsTNg4JTakN/E5unl1ZgPzTvByxR2aULRMTSBnaheGjfg1KbQ hmVbUUpd5dBit4WYrkkG9Vec2sPCo5tcDqTD1+9LYQGTHbvIK7F0ylEChUSkCivagwpY IJS8l1iWrwQzi/atd00nRMqugoN33WggTO3hfruFF9mB2U3YqxAlu27RG+JUD2yukpe2 oS4/r815iTr4kJA7B0usjwC2p+OqweWQT2+SlhxEDHLrtAKFtH2QMcXu5rJwCzFGowGj AJjxX8jJ4N209cgoMBcgmPsEkIsmvQCL+1Q2nWlU1P5eAwmZmRml0JumjGgHnE678sen +EAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Qd5RzM8JCXkyITsm1AK1Wi5FgB4p2iPIJeHV7D38U6s=; b=kzVTx9KHPxf2BNa0CkH+ZmupW32cYHPxp7JIRnP4l3KSu/52H7+AcoRdCX4raKGVSk xda/TMssT5D+UT5HtXJaxG3LfBW1f61rjRTYLBN+1KokZqBO8QCvSW7Dh1nEQvpxk5pF IQVpZR5tOOb2hPwuGxjN7oynrWi3y1qn73tQ+2QDdZbmMlW29Q1k5GAXaqMtpa8mH3d2 9NPvq0D9i0uxQpUdbH1oVZIKw9GiHteykZkGJIHhpFY1pPHoVna4QuSvhHss2kidp6pk 2fdOMN03OiFAne+NVYuSLpeiaSU9Fh9onCjQ0ZXervOcptcdUn5UKG3thSKGJ1IGqudw HueQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="saUcRD/x"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dt11si4349388ejb.126.2019.11.02.09.32.13; Sat, 02 Nov 2019 09:32:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="saUcRD/x"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbfKBQaO (ORCPT + 99 others); Sat, 2 Nov 2019 12:30:14 -0400 Received: from mail.skyhub.de ([5.9.137.197]:48426 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbfKBQaO (ORCPT ); Sat, 2 Nov 2019 12:30:14 -0400 Received: from nazgul.tnic (x59cc87ab.dyn.telefonica.de [89.204.135.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C42531EC072D; Sat, 2 Nov 2019 17:30:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1572712213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Qd5RzM8JCXkyITsm1AK1Wi5FgB4p2iPIJeHV7D38U6s=; b=saUcRD/xqnmPyOe7ixBBQEC2v/rT/LcGVZyHU3FTwzpJq8Homdx6/jpdJGBS6FfxQ0Icmg lnU5Vy6cvqiAs30GactFsAPbE8K8n5QNx6+PobptoKYbO3DBp9een749+tQRNEZtKuVP7+ tRUhMm0N6YhRAxIVKI6Npa03o6E0DSM= Date: Sat, 2 Nov 2019 17:30:05 +0100 From: Borislav Petkov To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, "Paul E. McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Andi Kleen , Andy Lutomirski , Fenghua Yu , Kees Cook , "Rafael J. Wysocki" , Sebastian Andrzej Siewior , Dave Hansen , Babu Moger , Rik van Riel , "Chang S. Bae" , Jann Horn , David Windsor , Elena Reshetova , Yuyang Du , Anshuman Khandual , Richard Guy Briggs , Andrew Morton , Christian Brauner , Michal Hocko , Andrea Arcangeli , Al Viro , "Dmitry V. Levin" , rcu@vger.kernel.org Subject: Re: [PATCH V2 7/7] x86,rcu: use percpu rcu_preempt_depth Message-ID: <20191102163005.GA11705@nazgul.tnic> References: <20191102124559.1135-1-laijs@linux.alibaba.com> <20191102124559.1135-8-laijs@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191102124559.1135-8-laijs@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Resending again because your mail has the craziest header: Reply-To: 20191101162109.GN20975@paulmck-ThinkPad-P72 and hitting Reply-to-all creates only confusion. WTF? On Sat, Nov 02, 2019 at 12:45:59PM +0000, Lai Jiangshan wrote: > Convert x86 to use a per-cpu rcu_preempt_depth. The reason for doing so > is that accessing per-cpu variables is a lot cheaper than accessing > task_struct or thread_info variables. > > We need to save/restore the actual rcu_preempt_depth when switch. > We also place the per-cpu rcu_preempt_depth close to __preempt_count > and current_task variable. > > Using the idea of per-cpu __preempt_count. > > No function call when using rcu_read_[un]lock(). > Single instruction for rcu_read_lock(). > 2 instructions for fast path of rcu_read_unlock(). > > CC: Peter Zijlstra > Signed-off-by: Lai Jiangshan > --- > arch/x86/Kconfig | 2 + > arch/x86/include/asm/rcu_preempt_depth.h | 87 ++++++++++++++++++++++++ > arch/x86/kernel/cpu/common.c | 7 ++ > arch/x86/kernel/process_32.c | 2 + > arch/x86/kernel/process_64.c | 2 + > include/linux/rcupdate.h | 24 +++++++ > init/init_task.c | 2 +- > kernel/fork.c | 2 +- > kernel/rcu/Kconfig | 3 + > kernel/rcu/tree_exp.h | 2 + > kernel/rcu/tree_plugin.h | 37 +++++++--- > 11 files changed, 158 insertions(+), 12 deletions(-) > create mode 100644 arch/x86/include/asm/rcu_preempt_depth.h > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index d6e1faa28c58..af9fedc0fdc4 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -18,6 +18,7 @@ config X86_32 > select MODULES_USE_ELF_REL > select OLD_SIGACTION > select GENERIC_VDSO_32 > + select ARCH_HAVE_RCU_PREEMPT_DEEPTH WTF is a "DEEPTH"? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --