Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2003051ybx; Sat, 2 Nov 2019 10:15:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvsTza66+BMvs64sQEaBpFBeX2h9mVbtsajobrStDGt0Og7+MmsNXMtdY24aEWpRXlZMHJ X-Received: by 2002:a17:906:3e41:: with SMTP id t1mr15870226eji.103.1572714933270; Sat, 02 Nov 2019 10:15:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572714933; cv=none; d=google.com; s=arc-20160816; b=zWK5cwhJ5OxJTSRlTjz7qCE87myIqlbtGnuik3snxuCmE6wkvqMLjhqa3SAfawof37 Fz6vTfPWXrUaHw7tRCM0fs66+vAmuVqDq6g51I/d2tL1qoCh581OiwgfRWau/aVddXLv 19wQ91Ni9bBg8AT6939hSZkjb6+Xij4SAdVpoRhSJlcBLhFisyvag65+Z5B7AcvgFDG5 9penHABDC/P6PxXsZXvB3HqtU1n92o9CXtQwY0zpExMVXF++/g38B9AHcsCEwQ7yTgVo 1IVUMZGkT7k7LJzNK8PpUpqbsy5EMmkOhaHny7dS4PSNY4E88jAfE1LBcOumFhOD/Jj8 3Hdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=q/eCocx3ZVAr2qU1ts69cnwiYNZXqmIQFBWTfFwYh08=; b=MvS5u0IGC2i41XIK0UmTW2qnQRrmo3AsjOzfomyep+TmKRfOByCKXmTIKtziGIlWMx 3ETSXtZs++jstOB+amS782viQhMQ9h29ELCPCmS6OQ0gTfD1unwwgi7OSyEeVT5vJD/U v/XAJD0/45S6nvmvQm2RRQgglpGo2eZ7BdBfkSWnbZduA+UEpmdIjiAh4LZnybpFW/Ov bs93BeyVn98vVEUDDpkH3YTN0+5mSX6P4NNAr3xhX1IdpYhBUqXxyI6GV/bNfxBFEU6m JwRooy6cyfb90pZMbvSA6UEbX0Imma92aDvInGJIhQ4wCplnCAvvKldR+XEOL39bW3sR 9JfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i22si6111222ejr.189.2019.11.02.10.15.09; Sat, 02 Nov 2019 10:15:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727091AbfKBRMD convert rfc822-to-8bit (ORCPT + 99 others); Sat, 2 Nov 2019 13:12:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45724 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbfKBRMD (ORCPT ); Sat, 2 Nov 2019 13:12:03 -0400 Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30B2BC04BE1B for ; Sat, 2 Nov 2019 17:12:03 +0000 (UTC) Received: by mail-ot1-f69.google.com with SMTP id f17so7971881otp.13 for ; Sat, 02 Nov 2019 10:12:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zl9fDks+mlVguzbhaExkNR5P4dBXCVz91rnRw1qkYoM=; b=bMHK0Fhd7ExIhxx0tSmQAwuU5Y+dy1WNNPmhXv0VuscxxjK4M7RRCifvDyaN9pn8dT RkUJ7+8oolTPhytnK7HdmoASrhCv5H2YK6CyJkWv9VAnfGnMgDze/1frgrHqp2zZq0D0 XCYRukavmG1Z7cn2m2is1lVvhGkx4zpVykuPrUA3iz0U1GyvzuJ68WnmyDKCUvaEzCux cOCYnpxMoWLVNlGT7aiPt7/ghshwNf9NmE+bUuV4zrl/ogHQwRp2r5rbuQ4dcVVFBiSa oL9hQjgL27zACC2ZbuCIz0IITC/vwIHS9CMGFIBE4bqemAseF+5qJ1P+2+cTGzBUqpMo QrYw== X-Gm-Message-State: APjAAAWg+vyGA7xTRipqWJ4jjE09l1WWfOEOzWfaaTVDkwmqXaJKvkdU mjiFV7oWETrTO3AE9qj9i9kxdcThH3V8lFy6uIN/v+QsvvHTD/3Qt7YQFPH6y8lB619IdheZ1di 6HKCakYoMFkoZOuQLJwNPnFu2+5O5TMwwr3eC5OmL X-Received: by 2002:aca:b03:: with SMTP id 3mr8429427oil.24.1572714722655; Sat, 02 Nov 2019 10:12:02 -0700 (PDT) X-Received: by 2002:aca:b03:: with SMTP id 3mr8429400oil.24.1572714722376; Sat, 02 Nov 2019 10:12:02 -0700 (PDT) MIME-Version: 1.0 References: <20191031064741.4567-1-christophe.jaillet@wanadoo.fr> <1b33ca33-a02b-1923-cbee-814e520b9700@wanadoo.fr> In-Reply-To: <1b33ca33-a02b-1923-cbee-814e520b9700@wanadoo.fr> From: Stefano Garzarella Date: Sat, 2 Nov 2019 18:11:50 +0100 Message-ID: Subject: Re: [PATCH] vsock: Simplify '__vsock_release()' To: Christophe JAILLET Cc: Sergei Shtylyov , "David S. Miller" , sunilmut@microsoft.com, Willem de Bruijn , Stefan Hajnoczi , ytht.net@gmail.com, Arnd Bergmann , tglx@linutronix.de, Dexuan Cui , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 10:49 AM Christophe JAILLET wrote: > > Le 31/10/2019 à 10:36, Sergei Shtylyov a écrit : > > Hello! > > > > On 31.10.2019 9:47, Christophe JAILLET wrote: > > > >> Use '__skb_queue_purge()' instead of re-implementing it. > > > > In don't see that double underscore below... > This is a typo in the commit message. > > There is no need for __ because skb_dequeue was used. > > Could you fix it directly in the commit message (preferred solution for > me) or should I send a V2? > I think is better if you send a v2 fixing this and including the R-b tags. My R-b stays with that fixed :-) Thanks, Stefano