Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2190569ybx; Sat, 2 Nov 2019 13:57:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzp3toEjxNfA2uxf4qS+teBJIdaq+g0T7wPzLrdvwNN7k/raCYdlpzZb4PIXWNmRym5GFiC X-Received: by 2002:a50:a69b:: with SMTP id e27mr20763461edc.188.1572728259005; Sat, 02 Nov 2019 13:57:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572728258; cv=none; d=google.com; s=arc-20160816; b=RIq4Fxm3Sjl3Qw228Qa1liYhtL1y0KftaDsyUI+5jstUF5yQSx3V3jk2POPSKd3Asy qtdB+lGmxBnwH4Qp3ipGhAUz9HEyKf+ne5qsqQAmiB4WoMm/IsHI5v92KXefvIYpwsAI vyTz/IJ3Wyzj2adyAM+O52IYsVmx/i6QSmNr3D2eqK5xOdpBauO8xBdu5Ruvh/pehD+9 B5Zs1ZpLtAQ0FeSdLgZkAFCVfXtW+csc0f/EpuzuyXv8xS7UnIVAYeCtMpNeyLhTQQIF Fqa3ZE1adpff1QGFWWiwWhWepE02kpE7L7uybPJ1iZXqIGmdTKRaWsT+aMQ7589/wUIg Z5kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Y2BVSZGLOtYso2UmMC8FMik2nU6NLubpKQk779x8UUA=; b=GPIPb26WnT8q8q1bU6+E6Np3MUWdu7aeUI9gk5HJttja9hMt7MDw007yXhfhdzZB6K P/RjZayN5SNVy41gY/x/D+ObqF2w6UYX4RQOm1q5mbOv5EQnngtAD+FJXbfNpOCzDKEP d8I+3AXq5MfzMU2XInR4jgItSPRArFQ62GzM5LI7WYMi7JmYJt2sEBKNIouU3tvTX1AW MlDaqyQyKXH3RXOyna5Z9jUXFPOBWWJnU4wk2GGU+MyAVVgKKP6IKUxhCIv6UREPKU0o M5lVLDitM7ihyykSGBaPhypZe8YG2glbuwUce/2Jk9aicE5M9ZOjm7MiNrQ9Epxled6x gSYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qblkL1ZR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s10si8652790ejq.255.2019.11.02.13.57.14; Sat, 02 Nov 2019 13:57:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qblkL1ZR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbfKBUyU (ORCPT + 99 others); Sat, 2 Nov 2019 16:54:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:58412 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbfKBUyT (ORCPT ); Sat, 2 Nov 2019 16:54:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y2BVSZGLOtYso2UmMC8FMik2nU6NLubpKQk779x8UUA=; b=qblkL1ZRBi5PEhgfR+0PdSvaM OoECO8pA8R/h1IGIg62xtdJFz2ETSgNR5qdCqMYzXR+Xvxka8MmYzk0GSANGIfSYkmfu27NRkljzD 1R2mOuCwqi8h1rynk/ioaRXnDR3wJDTQaYdfmKfqrVUg8bevsJav5BuKW7k2+uyMbsDrqRvvViyg/ Qp9MV+6++6otwJBZmppdg08qUb3DW7Tk/BQILYEOwe9ZAbE74oMhBxov42PfKiK0tuPuqUHMXbLgj PXKtS5gTzH/umvyTqWrnYHOIzrCu/waCZua9bVQR5eEUclIkkvhIdEwh/tIJpNzkubXHvWJ1pfCfx g8PEF6zTQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iR0PT-0000LU-Rz; Sat, 02 Nov 2019 20:54:11 +0000 Date: Sat, 2 Nov 2019 13:54:11 -0700 From: Matthew Wilcox To: hui yang Cc: akpm@linux-foundation.org, mhocko@suse.com, dan.j.williams@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: There should have an unit (kB) Message-ID: <20191102205411.GB15832@bombadil.infradead.org> References: <1572704287-4444-1-git-send-email-yanghui.def@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572704287-4444-1-git-send-email-yanghui.def@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 02, 2019 at 10:18:07PM +0800, hui yang wrote: > From: YangHui > > - printk(KERN_CONT " %ld", zone->lowmem_reserve[i]); > + printk(KERN_CONT " %ldkB", zone->lowmem_reserve[i]); > Make it look more perfect I don't think this is accounted in kilobytes though. Isn't it the number of pages?